|
| 1 | +"""Tests for LaunchedKubernetesJob.ended_at — the property fixed to use |
| 2 | +"Complete" instead of the incorrect "Succeeded" K8s Job condition type. |
| 3 | +""" |
| 4 | + |
| 5 | +from __future__ import annotations |
| 6 | + |
| 7 | +import datetime |
| 8 | +from typing import Any |
| 9 | +from unittest import mock |
| 10 | + |
| 11 | +from cloud_pipelines_backend.launchers import kubernetes_launchers as kl |
| 12 | + |
| 13 | + |
| 14 | +def _utc( |
| 15 | + *, |
| 16 | + year: int = 2026, |
| 17 | + month: int = 3, |
| 18 | + day: int = 20, |
| 19 | + hour: int = 12, |
| 20 | + minute: int = 0, |
| 21 | +) -> datetime.datetime: |
| 22 | + return datetime.datetime( |
| 23 | + year, month, day, hour, minute, tzinfo=datetime.timezone.utc |
| 24 | + ) |
| 25 | + |
| 26 | + |
| 27 | +def _make_condition( |
| 28 | + *, |
| 29 | + type: str, |
| 30 | + status: str = "True", |
| 31 | + last_transition_time: datetime.datetime | None = None, |
| 32 | +) -> mock.Mock: |
| 33 | + c = mock.Mock() |
| 34 | + c.type = type |
| 35 | + c.status = status |
| 36 | + c.last_transition_time = last_transition_time or _utc() |
| 37 | + return c |
| 38 | + |
| 39 | + |
| 40 | +def _make_job( |
| 41 | + *, |
| 42 | + conditions: list[Any] | None = None, |
| 43 | + active: int | None = None, |
| 44 | + succeeded: int | None = None, |
| 45 | + failed: int | None = None, |
| 46 | + start_time: datetime.datetime | None = None, |
| 47 | + completions: int | None = 1, |
| 48 | +) -> mock.Mock: |
| 49 | + job = mock.Mock() |
| 50 | + job.status = mock.Mock() |
| 51 | + job.status.conditions = conditions |
| 52 | + job.status.active = active |
| 53 | + job.status.succeeded = succeeded |
| 54 | + job.status.failed = failed |
| 55 | + job.status.start_time = start_time |
| 56 | + job.spec = mock.Mock() |
| 57 | + job.spec.completions = completions |
| 58 | + return job |
| 59 | + |
| 60 | + |
| 61 | +def _make_launched_job( |
| 62 | + *, |
| 63 | + job: mock.Mock | None = None, |
| 64 | +) -> kl.LaunchedKubernetesJob: |
| 65 | + if job is None: |
| 66 | + job = _make_job() |
| 67 | + return kl.LaunchedKubernetesJob( |
| 68 | + job_name="test-job", |
| 69 | + namespace="default", |
| 70 | + output_uris={}, |
| 71 | + log_uri="gs://bucket/log", |
| 72 | + debug_job=job, |
| 73 | + ) |
| 74 | + |
| 75 | + |
| 76 | +class TestEndedAt: |
| 77 | + """Tests for LaunchedKubernetesJob.ended_at. |
| 78 | +
|
| 79 | + This property reads job.status.conditions and returns the |
| 80 | + last_transition_time of the first terminal condition (Complete or Failed) |
| 81 | + with status=True. |
| 82 | +
|
| 83 | + Code under test: kubernetes_launchers.py LaunchedKubernetesJob.ended_at |
| 84 | + """ |
| 85 | + |
| 86 | + def test_returns_none_when_no_status(self) -> None: |
| 87 | + job = mock.Mock() |
| 88 | + job.status = None |
| 89 | + launched = _make_launched_job(job=job) |
| 90 | + assert launched.ended_at is None |
| 91 | + |
| 92 | + def test_returns_none_when_no_conditions(self) -> None: |
| 93 | + launched = _make_launched_job(job=_make_job(conditions=None)) |
| 94 | + assert launched.ended_at is None |
| 95 | + |
| 96 | + def test_returns_none_when_empty_conditions(self) -> None: |
| 97 | + launched = _make_launched_job(job=_make_job(conditions=[])) |
| 98 | + assert launched.ended_at is None |
| 99 | + |
| 100 | + def test_returns_none_when_only_suspended_condition(self) -> None: |
| 101 | + """A Suspended=True condition is not terminal — ended_at stays None.""" |
| 102 | + condition = _make_condition(type="Suspended", status="True") |
| 103 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 104 | + assert launched.ended_at is None |
| 105 | + |
| 106 | + def test_returns_time_for_complete_condition(self) -> None: |
| 107 | + """Job finished successfully: condition type=Complete, status=True.""" |
| 108 | + t = _utc(hour=14) |
| 109 | + condition = _make_condition( |
| 110 | + type="Complete", status="True", last_transition_time=t |
| 111 | + ) |
| 112 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 113 | + assert launched.ended_at == t |
| 114 | + |
| 115 | + def test_returns_time_for_failed_condition(self) -> None: |
| 116 | + """Job failed: condition type=Failed, status=True.""" |
| 117 | + t = _utc(hour=15) |
| 118 | + condition = _make_condition( |
| 119 | + type="Failed", status="True", last_transition_time=t |
| 120 | + ) |
| 121 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 122 | + assert launched.ended_at == t |
| 123 | + |
| 124 | + def test_ignores_complete_condition_with_status_false(self) -> None: |
| 125 | + condition = _make_condition(type="Complete", status="False") |
| 126 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 127 | + assert launched.ended_at is None |
| 128 | + |
| 129 | + def test_ignores_failed_condition_with_status_unknown(self) -> None: |
| 130 | + condition = _make_condition(type="Failed", status="Unknown") |
| 131 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 132 | + assert launched.ended_at is None |
| 133 | + |
| 134 | + def test_does_not_match_succeeded_string(self) -> None: |
| 135 | + """Regression: 'Succeeded' is not a valid K8s Job condition type. |
| 136 | + The old code had condition.type in ("Succeeded", "Failed") which |
| 137 | + caused ended_at to always be None for successful jobs. |
| 138 | + """ |
| 139 | + condition = _make_condition(type="Succeeded", status="True") |
| 140 | + launched = _make_launched_job(job=_make_job(conditions=[condition])) |
| 141 | + assert launched.ended_at is None |
| 142 | + |
| 143 | + def test_picks_terminal_condition_ignoring_suspended(self) -> None: |
| 144 | + """Real scenario: a job was suspended then resumed and completed. |
| 145 | + Conditions list has Suspended=True followed by Complete=True. |
| 146 | + ended_at should come from the Complete condition. |
| 147 | + """ |
| 148 | + t_suspended = _utc(hour=10) |
| 149 | + t_complete = _utc(hour=14) |
| 150 | + conditions = [ |
| 151 | + _make_condition( |
| 152 | + type="Suspended", status="True", last_transition_time=t_suspended |
| 153 | + ), |
| 154 | + _make_condition( |
| 155 | + type="Complete", status="True", last_transition_time=t_complete |
| 156 | + ), |
| 157 | + ] |
| 158 | + launched = _make_launched_job(job=_make_job(conditions=conditions)) |
| 159 | + assert launched.ended_at == t_complete |
0 commit comments