BlueSky using BADA

[tinpusher]

I had a BADA performance model usage problem. I get the Successfully loaded, but was not convinced that it was using BADA.
Found in Traffic.py a section of code related to BADA, after uncommenting, it still failed, but it gave a clue.
The issue is that line 34

  print('Using BADA Performance model')
  from .performance.bada.perfbada import PerfBADA as Perf,

but, the file perfbada (bada directory), the import is just BADA.
so the correction is (at least for me ):

from .performance.bada.perfbada import BADA as Perf

At least it worked for me, the boot output after the fix:

Successfully loaded OpenAP performance model
Successfully loaded BADA performance model
Successfully loaded legacy performance model

Using BADA Performance model

Found BADA version 3.16 (release date May 24 2022)
1832 aircraft entries loaded
264 unique aircraft coefficient sets loaded

[jooste]

Hi @tinpusher,

The commented out code in traffic.py should be removed. You can select a performance model from the available performance models using the PERF command. BlueSky won't automatically switch to BADA if it is loaded.

[tinpusher]

Hi, thanks., for the quick response, appreciate it.
I know that loading is different from using.
The PERF command, are you referring to, is that in the settings.cfg : Performance_model, where you can select the required Performance_model,

I would like some kind of 'positive' feedback, during the loading process, or as close as possible to the use (in this case BADA), confirming the performance _model is use.
I have been "caught out", many times over the years, working on mainstream simulators ( and live systems that use trajectory management) , and learnt not to assuming that some value is set, only to find there was another 'entry point'

This line ( about L29), just above, section of to be re-commented out code, made me a bit cautious.

Register settings defaults

bs.settings.set_variable_defaults(performance_model='openap', asas_dt=1.0)

many thanks again for the feedback.

[jooste]

Understandable!

In that case what may be useful for you: if you call the PERF command without arguments it will tell you which performance model it is currently using. If you want confirmation from inside the code you can always put a print statement in one of the perfBADA functions, and see if it is indeed triggered when you select BADA with the perf command.

[tinpusher]

Thanks