Remove semicolons and add comprehensive tests

Author: Definence

.cursor/rules/swipecast.mdc

@@ -0,0 +1,5 @@
+---
+alwaysApply: true
+---
+- use snake case for file naming
+- avoid using ";"

.gitignore

@@ -1,5 +1,6 @@
 node_modules
 dist
+coverage
 *.log
 .DS_Store
 .idea

__tests__/stripe_helpers.test.ts

@@ -0,0 +1,299 @@
+import {
+  StripeHelpers,
+  StripeCard,
+  StripeUSBankAccount,
+  StripePaymentMethod,
+  StripeCustomer,
+} from '../src/helpers/stripe_helpers'
+
+describe('StripeHelpers', () => {
+  describe('getCardBrandLabel', () => {
+    it('should format American Express as Amex', () => {
+      const card: StripeCard = {
+        brand: 'American Express',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('Amex')
+    })
+
+    it('should format Visa correctly', () => {
+      const card: StripeCard = {
+        brand: 'Visa',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('Visa')
+    })
+
+    it('should format Mastercard correctly', () => {
+      const card: StripeCard = {
+        brand: 'Mastercard',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('Mastercard')
+    })
+
+    it('should capitalize unknown brands', () => {
+      const card: StripeCard = {
+        brand: 'visa',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('Visa')
+    })
+
+    it('should handle empty brand', () => {
+      const card: StripeCard = {
+        brand: '',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('')
+    })
+
+    it('should handle missing brand', () => {
+      const card: StripeCard = {
+        brand: undefined as any,
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardBrandLabel(card)).toBe('')
+    })
+  })
+
+  describe('getCardLabel', () => {
+    it('should format card label correctly', () => {
+      const card: StripeCard = {
+        brand: 'Visa',
+        last4: '1234',
+        exp_month: 12,
+        exp_year: 2025,
+      }
+      expect(StripeHelpers.getCardLabel(card)).toBe('Visa •••• 1234 · exp 12/2025')
+    })
+
+    it('should handle single digit month', () => {
+      const card: StripeCard = {
+        brand: 'Mastercard',
+        last4: '5678',
+        exp_month: 1,
+        exp_year: 2026,
+      }
+      expect(StripeHelpers.getCardLabel(card)).toBe('Mastercard •••• 5678 · exp 1/2026')
+    })
+  })
+
+  describe('getUSBankAccountLabel', () => {
+    it('should format bank account label correctly', () => {
+      const account: StripeUSBankAccount = {
+        bank_name: 'Chase',
+        last4: '1234',
+      }
+      expect(StripeHelpers.getUSBankAccountLabel(account)).toBe('Chase · *1234')
+    })
+
+    it('should handle different bank names', () => {
+      const account: StripeUSBankAccount = {
+        bank_name: 'Bank of America',
+        last4: '5678',
+      }
+      expect(StripeHelpers.getUSBankAccountLabel(account)).toBe('Bank of America · *5678')
+    })
+  })
+
+  describe('getPaymentMethodLabel', () => {
+    it('should format card payment method', () => {
+      const pm: StripePaymentMethod = {
+        data: {
+          type: 'card',
+          card: {
+            brand: 'Visa',
+            last4: '1234',
+            exp_month: 12,
+            exp_year: 2025,
+          },
+        },
+      }
+      expect(StripeHelpers.getPaymentMethodLabel(pm)).toBe('Visa •••• 1234 · exp 12/2025')
+    })
+
+    it('should format bank account payment method', () => {
+      const pm: StripePaymentMethod = {
+        data: {
+          type: 'us_bank_account',
+          us_bank_account: {
+            bank_name: 'Chase',
+            last4: '1234',
+          },
+        },
+      }
+      expect(StripeHelpers.getPaymentMethodLabel(pm)).toBe('Chase · *1234')
+    })
+
+    it('should return Unknown Card for invalid payment method', () => {
+      const pm: StripePaymentMethod = {
+        data: {
+          type: 'card',
+        },
+      }
+      expect(StripeHelpers.getPaymentMethodLabel(pm)).toBe('Unknown Card')
+    })
+  })
+
+  describe('getCustomerDefaultPaymentMethod', () => {
+    it('should return null for null customer', () => {
+      expect(StripeHelpers.getCustomerDefaultPaymentMethod(null)).toBeNull()
+    })
+
+    it('should return null for customer without data', () => {
+      const customer: StripeCustomer = {
+        data: {},
+      }
+      expect(StripeHelpers.getCustomerDefaultPaymentMethod(customer)).toBeNull()
+    })
+
+    it('should extract default card payment method from customer', () => {
+      const customer: StripeCustomer = {
+        data: {
+          invoice_settings: {
+            default_payment_method: {
+              id: 'pm_123',
+              type: 'card',
+              object: 'payment_method',
+              card: {
+                brand: 'Visa',
+                last4: '1234',
+                exp_month: 12,
+                exp_year: 2025,
+              },
+            },
+          },
+        },
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer)
+      expect(result).not.toBeNull()
+      expect(result?.isPaymentMethod).toBe(true)
+      expect(result?.last4).toBe('1234')
+      expect(result?.expMonth).toBe(12)
+      expect(result?.expYear).toBe(2025)
+      expect(result?.brand).toBe('Visa')
+      expect(result?.id).toBe('pm_123')
+      expect(result?.label).toBe('Visa •••• 1234 · exp 12/2025')
+    })
+
+    it('should extract default US bank account payment method from customer', () => {
+      const customer: StripeCustomer = {
+        data: {
+          invoice_settings: {
+            default_payment_method: {
+              id: 'pm_456',
+              type: 'us_bank_account',
+              object: 'payment_method',
+              us_bank_account: {
+                bank_name: 'Chase',
+                last4: '5678',
+              },
+            },
+          },
+        },
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer)
+      expect(result).not.toBeNull()
+      expect(result?.isPaymentMethod).toBe(true)
+      expect(result?.last4).toBe('5678')
+      expect(result?.bankName).toBe('Chase')
+      expect(result?.id).toBe('pm_456')
+      expect(result?.label).toBe('Chase · *5678')
+    })
+
+    it('should fallback to source when no default payment method', () => {
+      const customer: StripeCustomer = {
+        data: {
+          sources: {
+            data: [
+              {
+                brand: 'Mastercard',
+                last4: '9999',
+                exp_month: 6,
+                exp_year: 2027,
+                id: 'card_123',
+                object: 'card',
+              },
+            ],
+          },
+        },
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer)
+      expect(result).not.toBeNull()
+      expect(result?.isPaymentMethod).toBe(false)
+      expect(result?.last4).toBe('9999')
+      expect(result?.expMonth).toBe(6)
+      expect(result?.expYear).toBe(2027)
+      expect(result?.brand).toBe('Mastercard')
+      expect(result?.id).toBe('card_123')
+      expect(result?.label).toBe('Mastercard •••• 9999 · exp 6/2027')
+    })
+
+    it('should return fallback card when useFallback is true', () => {
+      const customer: StripeCustomer = {
+        data: {},
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer, true)
+      expect(result).not.toBeNull()
+      expect(result?.isPaymentMethod).toBe(false)
+      expect(result?.last4).toBe('XXXX')
+      expect(result?.expMonth).toBe(0)
+      expect(result?.expYear).toBe(0)
+      expect(result?.brand).toBe('Unknown')
+      expect(result?.id).toBe('N/A')
+      expect(result?.label).toBe('Unknown Card')
+    })
+
+    it('should return null when no payment method and useFallback is false', () => {
+      const customer: StripeCustomer = {
+        data: {},
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer, false)
+      expect(result).toBeNull()
+    })
+
+    it('should handle missing optional fields in card', () => {
+      const customer: StripeCustomer = {
+        data: {
+          invoice_settings: {
+            default_payment_method: {
+              id: 'pm_789',
+              type: 'card',
+              card: {
+                brand: 'Visa',
+                last4: undefined,
+                exp_month: undefined,
+                exp_year: undefined,
+              },
+            },
+          },
+        },
+      }
+
+      const result = StripeHelpers.getCustomerDefaultPaymentMethod(customer)
+      expect(result).not.toBeNull()
+      expect(result?.last4).toBe('')
+      expect(result?.expMonth).toBeUndefined()
+      expect(result?.expYear).toBeUndefined()
+    })
+  })
+})
+

jest.config.js

@@ -0,0 +1,13 @@
+module.exports = {
+  preset: 'ts-jest',
+  testEnvironment: 'node',
+  roots: ['<rootDir>/src', '<rootDir>/__tests__'],
+  testMatch: ['**/__tests__/**/*.test.ts', '**/?(*.)+(spec|test).ts'],
+  collectCoverageFrom: [
+    'src/**/*.ts',
+    '!src/**/*.d.ts',
+  ],
+  coverageDirectory: 'coverage',
+  coverageReporters: ['text', 'lcov', 'html'],
+}
+