Skip to content

Commit e037a64

Browse files
committed
Fix grid spacing persistence + indentation
1 parent 0dcaacd commit e037a64

3 files changed

Lines changed: 10 additions & 9 deletions

File tree

src/core/modules/GridLinesMgr.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ static const double STEP_SIZES_HMS[] = {0.05, 0.2, 1.5, 7.5, 15., 15.*5., 15.*10
148148
//! Return the angular grid step in degree which best fits the given scale
149149
static double getClosestResolutionDMS(double pixelPerRad, double spacingMultiplier)
150150
{
151-
// Apply spacing multiplier: higher values = denser grid
151+
// Apply spacing multiplier: higher values = denser grid
152152
double minResolution = 80.0 / spacingMultiplier;
153153
double minSizeArcsec = minResolution/pixelPerRad*M_180_PI*3600;
154154
for (unsigned int i=0;i<12;++i)
@@ -162,7 +162,7 @@ static double getClosestResolutionDMS(double pixelPerRad, double spacingMultipli
162162
//! Return the angular grid step in degree which best fits the given scale
163163
static double getClosestResolutionHMS(double pixelPerRad, double spacingMultiplier)
164164
{
165-
// Apply spacing multiplier: higher values = denser grid
165+
// Apply spacing multiplier: higher values = denser grid
166166
double minResolution = 80.0 / spacingMultiplier;
167167
double minSizeArcsec = minResolution/pixelPerRad*M_180_PI*3600;
168168
for (unsigned int i=0;i<11;++i)
@@ -1992,7 +1992,7 @@ void GridLinesMgr::init()
19921992
setPartThickness(conf->value("viewing/part_thickness", 1.f).toFloat());
19931993
// Set the point size
19941994
setPointSize(conf->value("viewing/point_size", 5.f).toFloat());
1995-
// Set gridline spacing
1995+
// Set gridline spacing
19961996
setGridSpacingMultiplier(conf->value("viewing/grid_spacing_multiplier", 1.0).toDouble());
19971997

19981998
// Load colors from config file
@@ -4187,7 +4187,7 @@ void GridLinesMgr::setFontSizeFromApp(int size)
41874187
}
41884188
double GridLinesMgr::getGridSpacingMultiplier() const
41894189
{
4190-
return gridSpacingMultiplier;
4190+
return gridSpacingMultiplier;
41914191
}
41924192

41934193
void GridLinesMgr::setGridSpacingMultiplier(double multiplier)

src/gui/ConfigurationDialog.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1244,6 +1244,7 @@ void ConfigurationDialog::saveAllSettings()
12441244
conf->setValue("viewing/line_thickness", propMgr->getStelPropertyValue("GridLinesMgr.lineThickness").toInt());
12451245
conf->setValue("viewing/part_thickness", propMgr->getStelPropertyValue("GridLinesMgr.partThickness").toInt());
12461246
conf->setValue("viewing/point_size", propMgr->getStelPropertyValue("GridLinesMgr.pointSize").toInt());
1247+
conf->setValue("viewing/grid_spacing_multiplier", propMgr->getStelPropertyValue("GridLinesMgr.gridSpacingMultiplier").toDouble());
12471248

12481249
conf->setValue("viewing/constellation_font_size", propMgr->getStelPropertyValue("ConstellationMgr.fontSize").toInt());
12491250
conf->setValue("viewing/flag_constellation_abbreviations", propMgr->getStelPropertyValue("StelSkyCultureMgr.flagUseAbbreviatedNames").toBool());

src/gui/ViewDialog.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -446,8 +446,9 @@ void ViewDialog::createDialogContent()
446446
updateDefaultLandscape();
447447
connect(lmgr, SIGNAL(landscapesChanged()), this, SLOT(populateLists()));
448448
connect(ui->pushButtonAddRemoveLandscapes, SIGNAL(clicked()), this, SLOT(showAddRemoveLandscapesDialog()));
449-
// Connect grid spacing combo box
449+
// Connect grid spacing combo box
450450
connect(ui->gridSpacingComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(gridSpacingChanged(int)));
451+
updateGridSpacingComboBox();
451452

452453
// Grid and lines
453454
connectGroupBox(ui->celestialSphereGroupBox, "actionShow_Gridlines");
@@ -1846,15 +1847,15 @@ void ViewDialog::gridSpacingChanged(int index)
18461847
{
18471848
GridLinesMgr* gridMgr = GETSTELMODULE(GridLinesMgr);
18481849

1849-
// Map combo box index to multiplier values
1850-
// Index 0 = Fine (2.0x), Index 1 = Normal (1.0x), Index 2 = Coarse (0.5x)
1850+
// Map combo box index to multiplier values
1851+
// Index 0 = Fine (2.0x), Index 1 = Normal (1.0x), Index 2 = Coarse (0.5x)
18511852
double multiplier = 1.0;
18521853
switch(index)
18531854
{
18541855
case 0: // Fine
18551856
multiplier = 2.0;
18561857
break;
1857-
case 1: // Normal
1858+
case 1: // Normal
18581859
multiplier = 1.0;
18591860
break;
18601861
case 2: // Coarse
@@ -1890,5 +1891,4 @@ void ViewDialog::updateGridSpacingComboBox()
18901891
ui->gridSpacingComboBox->blockSignals(true);
18911892
ui->gridSpacingComboBox->setCurrentIndex(index);
18921893
ui->gridSpacingComboBox->blockSignals(false);
1893-
updateGridSpacingComboBox();
18941894
}

0 commit comments

Comments
 (0)