Improve transaction detail header layout and merchant name handling - #1959
Merged
Conversation
The card purchase activity header used justify-between, which offset the merchant title based on the ChevronLeft width, and the location was pinned with ml-10. Absolutely position the back button so the title truly centers, and drop the spacer. Also center the location text and trim merchant_name/description so stray whitespace from the upstream data doesn't misalign the header.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the transaction detail header layout to use absolute positioning for better centering and improves merchant name handling by trimming whitespace.
Key Changes
justify-betweentojustify-centerwith absolute positioning for the back button, removing the need for a spacer View.trim()calls to merchant name and description to handle whitespace properlyml-10) to center-aligned to match the new header layoutImplementation Details
https://claude.ai/code/session_01T6zZc5Zr1FCcFV89aBkEJN