refactor: deprecate CoreRegistry-based ReadWriteStorageManager constructor

Mark the old constructor that resolves dependencies via CoreRegistry as
@deprecated. The @Inject constructor is the correct DI path. No callers
use the old constructor directly — it exists only as a fallback.

BSA flagged this on PR MovingBlocks#5299.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Cervator

engine/src/main/java/org/terasology/engine/persistence/internal/ReadWriteStorageManager.java

@@ -116,6 +116,11 @@ public final class ReadWriteStorageManager extends AbstractStorageManager
     private final Game game;
     private final BlockManager blockManager;
 
+    /**
+     * @deprecated Use the @Inject constructor instead. This constructor relies on CoreRegistry
+     *             for implicit dependencies which conflicts with the DI migration.
+     */
+    @Deprecated
     public ReadWriteStorageManager(Path savePath, ModuleEnvironment environment, EngineEntityManager entityManager, BlockManager blockManager,
                                    ExtraBlockDataManager extraDataManager, RecordAndReplaySerializer recordAndReplaySerializer,
                                    RecordAndReplayUtils recordAndReplayUtils, RecordAndReplayCurrentStatus recordAndReplayCurrentStatus) {