From 0ff3978190a86af3cb3c02db9b3cbdd90649058a Mon Sep 17 00:00:00 2001 From: ritik Date: Tue, 22 Aug 2023 15:46:02 +0530 Subject: [PATCH 1/8] removed depreciation from consignment apis --- lib/consignment.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/consignment.js b/lib/consignment.js index 66254aa..b4a0f34 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -198,7 +198,7 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) log.debug('retry # ' + retryCounter); } - var path = '/api/consignment'; + var path = '/api/2.0/consignment'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; log.debug('GET ' + vendUrl); @@ -251,7 +251,7 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/1.0/consignment/' + args.apiId.value; + var path = '/api/2.0/consignment/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; log.debug('Requesting vend consignment ' + vendUrl); var authString = 'Bearer ' + connectionInfo.accessToken; @@ -513,7 +513,7 @@ var createStockOrder = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/consignment'; + var path = '/api/2.0/consignment'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; @@ -588,7 +588,7 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/consignment/' + args.apiId.value; + var path = '/api/2.0/consignments/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; var body = args.body.value; @@ -623,7 +623,7 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/consignment/' + args.apiId.value; + var path = '/api/2.0/consignments/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; var body = args.body.value; @@ -659,7 +659,7 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { } log.debug(args.apiId.value); - var path = '/api/consignment/' + args.apiId.value; + var path = '/api/2.0/consignments/' + args.apiId.value; log.debug(path); var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; From b6231e97f04015ef4f2e989963e3c9fa067de068 Mon Sep 17 00:00:00 2001 From: ritik Date: Mon, 11 Sep 2023 13:22:05 +0530 Subject: [PATCH 2/8] handle the new response --- lib/consignment.js | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/lib/consignment.js b/lib/consignment.js index b4a0f34..a8cff93 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -198,7 +198,7 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) log.debug('retry # ' + retryCounter); } - var path = '/api/2.0/consignment'; + var path = '/api/2.0/consignments'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; log.debug('GET ' + vendUrl); @@ -215,8 +215,9 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) page_size: args.pageSize.value // eslint-disable-line camelcase } }; - - return utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); + const getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); + const result = getOrdersFromSuppliers?.data ? getOrdersFromSuppliers?.data : getOrdersFromSuppliers; + return result; }; // TODO: need to add a test @@ -251,7 +252,7 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/2.0/consignment/' + args.apiId.value; + var path = '/api/2.0/consignments/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; log.debug('Requesting vend consignment ' + vendUrl); var authString = 'Bearer ' + connectionInfo.accessToken; @@ -264,8 +265,9 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { 'Accept': 'application/json' } }; - - return utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter); + const getConsignment = utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter); + const result = getConsignment?.data ? getConsignment?.data : getConsignment; + return result; }; // TODO: need to add a test @@ -606,8 +608,9 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - - return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); + const updateConsignmentToSent = utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); + const result = updateConsignmentToSent?.data ? updateConsignmentToSent?.data : updateConsignmentToSent; + return result; }; var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { @@ -642,7 +645,9 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); + const updateConsignmentToReceived = utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); + const result = updateConsignmentToReceived?.data ? updateConsignmentToReceived?.data : updateConsignmentToReceived; + return result; }; var deleteStockOrder = function(args, connectionInfo, retryCounter) { @@ -675,7 +680,9 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); - return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); + const consignmentDelete = utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); + const result = consignmentDelete?.data ? consignmentDelete?.data : consignmentDelete; + return result; }; var deleteConsignmentProduct = function(args, connectionInfo, retryCounter) { From 21ed534a5d7bb0800378ce36eb875ffc7fa5b725 Mon Sep 17 00:00:00 2001 From: ritik Date: Tue, 26 Sep 2023 10:03:46 +0530 Subject: [PATCH 3/8] replaced optional condition & const with var --- lib/consignment.js | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/lib/consignment.js b/lib/consignment.js index a8cff93..2902560 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -215,9 +215,8 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) page_size: args.pageSize.value // eslint-disable-line camelcase } }; - const getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); - const result = getOrdersFromSuppliers?.data ? getOrdersFromSuppliers?.data : getOrdersFromSuppliers; - return result; + var getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); + return getOrdersFromSuppliers.data; }; // TODO: need to add a test @@ -265,9 +264,8 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { 'Accept': 'application/json' } }; - const getConsignment = utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter); - const result = getConsignment?.data ? getConsignment?.data : getConsignment; - return result; + var getConsignment = utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter); + return getConsignment.data; }; // TODO: need to add a test @@ -515,7 +513,7 @@ var createStockOrder = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/2.0/consignment'; + var path = '/api/2.0/consignments'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; @@ -539,7 +537,8 @@ var createStockOrder = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); - return utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter); + var createdStockOrder = utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter); + return createdStockOrder.data; }; // TODO: need to add a test @@ -608,9 +607,8 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - const updateConsignmentToSent = utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); - const result = updateConsignmentToSent?.data ? updateConsignmentToSent?.data : updateConsignmentToSent; - return result; + var updateConsignmentToSent = utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); + return updateConsignmentToSent.data; }; var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { @@ -645,9 +643,8 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - const updateConsignmentToReceived = utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); - const result = updateConsignmentToReceived?.data ? updateConsignmentToReceived?.data : updateConsignmentToReceived; - return result; + var updateConsignmentToReceived = utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); + return updateConsignmentToReceived.data; }; var deleteStockOrder = function(args, connectionInfo, retryCounter) { @@ -680,9 +677,8 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); - const consignmentDelete = utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); - const result = consignmentDelete?.data ? consignmentDelete?.data : consignmentDelete; - return result; + var consignmentDelete = utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); + return consignmentDelete.data; }; var deleteConsignmentProduct = function(args, connectionInfo, retryCounter) { From 5ceb36ea437d7b42400ecaa2a2af68c5b3666210 Mon Sep 17 00:00:00 2001 From: ritik Date: Fri, 29 Sep 2023 21:03:48 +0530 Subject: [PATCH 4/8] handle reponse and updated consignment_product endpoint --- lib/consignment.js | 69 +++++++++++++++++++++++++++------------------- 1 file changed, 41 insertions(+), 28 deletions(-) diff --git a/lib/consignment.js b/lib/consignment.js index 2902560..b271178 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -215,8 +215,10 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) page_size: args.pageSize.value // eslint-disable-line camelcase } }; - var getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); - return getOrdersFromSuppliers.data; + return utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter) + .then(function(response){ + return response.data; + }) }; // TODO: need to add a test @@ -264,8 +266,10 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { 'Accept': 'application/json' } }; - var getConsignment = utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter); - return getConsignment.data; + return utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter) + .then(function(response){ + return response.data; + }) }; // TODO: need to add a test @@ -275,8 +279,8 @@ var fetchProductsByConsignment = function(args, connectionInfo, retryCounter) { } else { log.debug('retry # ' + retryCounter); } - - var path = '/api/consignment_product'; + var path = `/api/2.0/consignments/${args.consignmentId.value}/products`; + //var path = '/api/consignment_product'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; log.debug('Requesting vend product ' + vendUrl); var authString = 'Bearer ' + connectionInfo.accessToken; @@ -295,7 +299,10 @@ var fetchProductsByConsignment = function(args, connectionInfo, retryCounter) { } }; - return utils.sendRequest(options, args, connectionInfo, fetchProductsByConsignment, retryCounter); + return utils.sendRequest(options, args, connectionInfo, fetchProductsByConsignment, retryCounter) + .then(function(response){ + return response.data; + }); }; // TODO: need to add a test @@ -445,8 +452,7 @@ var fetchConsignmentProductById = function(args, connectionInfo, retryCounter) }; var createConsignmentProduct = function(args, connectionInfo, retryCounter) { - log.debug('inside createConsignmentProduct()'); - + log.debug('inside createConsignmentProduct()'+ JSON.stringify(args)); var body = null; if (args && args.body) { body = args.body; @@ -456,23 +462,19 @@ var createConsignmentProduct = function(args, connectionInfo, retryCounter) { return Promise.reject('missing required arguments for createConsignmentProduct()'); } body = { - 'consignment_id': args.consignmentId.value, 'product_id': args.productId.value, 'count': args.count.value, 'cost': args.cost.value, - 'sequence_number': args.sequenceNumber.value, 'received': args.received.value, }; } - - if (!retryCounter) { retryCounter = 0; } else { log.debug('retry # ' + retryCounter); } - - var path = '/api/consignment_product'; + var path = `/api/2.0/consignments/${args.body.consignment_id}/products`; + //var path = '/api/consignment_product'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; @@ -490,13 +492,13 @@ var createConsignmentProduct = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, createConsignmentProduct, retryCounter) .then(function(response){ - if(!response.id){ + if(!response.data.product_id){ var error = new Error("Error adding consignment product"); response.statusCode = 500; error.response = response; return Promise.reject(error); } - return Promise.resolve(response); + return Promise.resolve(response.data); }); }; @@ -537,8 +539,10 @@ var createStockOrder = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); - var createdStockOrder = utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter); - return createdStockOrder.data; + return utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter) + .then(function(response){ + return response.data; + }); }; // TODO: need to add a test @@ -554,8 +558,8 @@ var updateConsignmentProduct = function(args, connectionInfo, retryCounter) { } else { log.debug('retry # ' + retryCounter); } - - var path = '/api/consignment_product/' + args.apiId.value; + var path = `/api/2.0/consignments/${args.body.vendConsignmentId}/products/${args.body.value.product_id}`; + //var path = '/api/consignment_product/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; var body = args.body.value; @@ -573,7 +577,10 @@ var updateConsignmentProduct = function(args, connectionInfo, retryCounter) { log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - return utils.sendRequest(options, args, connectionInfo, updateConsignmentProduct, retryCounter); + return utils.sendRequest(options, args, connectionInfo, updateConsignmentProduct, retryCounter) + .then(function(response){ + return response.data; + }); }; var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { @@ -607,8 +614,10 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - var updateConsignmentToSent = utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); - return updateConsignmentToSent.data; + return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter) + .then(function(response){ + return response.data; + }) }; var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { @@ -643,8 +652,10 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { log.debug(options.method + ' ' + options.url); log.debug( { message: 'body', body: options.json } ); - var updateConsignmentToReceived = utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); - return updateConsignmentToReceived.data; + return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter) + .then(function(response){ + return response.data; + }); }; var deleteStockOrder = function(args, connectionInfo, retryCounter) { @@ -677,8 +688,10 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { }; log.debug(options.method + ' ' + options.url); - var consignmentDelete = utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); - return consignmentDelete.data; + return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter) + .then(function(response){ + return response.data; + }); }; var deleteConsignmentProduct = function(args, connectionInfo, retryCounter) { From 595411a4d622372807b6093c72d6fe969e61fd6b Mon Sep 17 00:00:00 2001 From: ritik Date: Sat, 30 Sep 2023 08:27:58 +0530 Subject: [PATCH 5/8] added catch block --- lib/consignment.js | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/lib/consignment.js b/lib/consignment.js index b271178..603d347 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -218,7 +218,9 @@ var fetchStockOrdersForSuppliers = function(args, connectionInfo, retryCounter) return utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter) .then(function(response){ return response.data; - }) + }).catch(function(error){ + throw error; + }); }; // TODO: need to add a test @@ -269,7 +271,9 @@ var fetchConsignment = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, fetchConsignment, retryCounter) .then(function(response){ return response.data; - }) + }).catch(function(error){ + throw error; + }); }; // TODO: need to add a test @@ -280,7 +284,6 @@ var fetchProductsByConsignment = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } var path = `/api/2.0/consignments/${args.consignmentId.value}/products`; - //var path = '/api/consignment_product'; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; log.debug('Requesting vend product ' + vendUrl); var authString = 'Bearer ' + connectionInfo.accessToken; @@ -302,6 +305,8 @@ var fetchProductsByConsignment = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, fetchProductsByConsignment, retryCounter) .then(function(response){ return response.data; + }).catch(function(error){ + throw error; }); }; @@ -499,7 +504,9 @@ var createConsignmentProduct = function(args, connectionInfo, retryCounter) { return Promise.reject(error); } return Promise.resolve(response.data); - }); + }).catch(function(error){ + throw error; + }) }; var createStockOrder = function(args, connectionInfo, retryCounter) { @@ -542,7 +549,9 @@ var createStockOrder = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter) .then(function(response){ return response.data; - }); + }).catch(function(error){ + throw error; + }) }; // TODO: need to add a test @@ -580,7 +589,9 @@ var updateConsignmentProduct = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, updateConsignmentProduct, retryCounter) .then(function(response){ return response.data; - }); + }).catch(function(error){ + throw error; + }) }; var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { @@ -617,6 +628,8 @@ var markStockOrderAsSent = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter) .then(function(response){ return response.data; + }).catch(function(error){ + throw error; }) }; @@ -655,7 +668,9 @@ var markStockOrderAsReceived = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter) .then(function(response){ return response.data; - }); + }).catch(function(error){ + throw error; + }) }; var deleteStockOrder = function(args, connectionInfo, retryCounter) { @@ -691,7 +706,9 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter) .then(function(response){ return response.data; - }); + }).catch(function(error){ + throw error; + }) }; var deleteConsignmentProduct = function(args, connectionInfo, retryCounter) { From c8e78d540b1c41795ead19e124987d51a5e8cca0 Mon Sep 17 00:00:00 2001 From: ritikatsp Date: Fri, 16 Feb 2024 15:45:54 +0530 Subject: [PATCH 6/8] fix delete consignment api --- lib/consignment.js | 2 +- lib/utils.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/consignment.js b/lib/consignment.js index 603d347..d968f4a 100644 --- a/lib/consignment.js +++ b/lib/consignment.js @@ -705,7 +705,7 @@ var deleteStockOrder = function(args, connectionInfo, retryCounter) { return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter) .then(function(response){ - return response.data; + return response; }).catch(function(error){ throw error; }) diff --git a/lib/utils.js b/lib/utils.js index 01e7ab1..41ad26e 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -33,6 +33,9 @@ var successHandler = function (response) { else if (_.isString(response)) { log.debug('response is a string'); try { + if(!response.size){ + return Promise.resolve(response); + } var responseObject = JSON.parse(response); //log.trace( { message: 'responseObject', data: responseObject } ); return Promise.resolve(responseObject); From 6bf25b99b1476986d3ceaa3f572957faf47ea320 Mon Sep 17 00:00:00 2001 From: Suraj Mandal Date: Wed, 23 Oct 2024 22:42:37 +0530 Subject: [PATCH 7/8] Replace size with length. --- lib/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 41ad26e..ff866ee 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -33,7 +33,7 @@ var successHandler = function (response) { else if (_.isString(response)) { log.debug('response is a string'); try { - if(!response.size){ + if(!response.length){ return Promise.resolve(response); } var responseObject = JSON.parse(response); From 553d7375fb71e5158baae219131e709fe71973b5 Mon Sep 17 00:00:00 2001 From: Suraj Mandal Date: Fri, 25 Oct 2024 16:54:45 +0530 Subject: [PATCH 8/8] Added product update api changes --- lib/product.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/product.js b/lib/product.js index 53e391b..31c1a20 100644 --- a/lib/product.js +++ b/lib/product.js @@ -259,13 +259,13 @@ var updateProductById = function(args, connectionInfo, retryCounter) { log.debug('retry # ' + retryCounter); } - var path = '/api/products'; + var path = '/api/2.1/products/' + args.apiId.value; var vendUrl = 'https://' + connectionInfo.domainPrefix + '.vendhq.com' + path; var authString = 'Bearer ' + connectionInfo.accessToken; var body = args.body.value; var options = { - method: 'POST', + method: 'PUT', url: vendUrl, headers: { 'Authorization': authString,