Harden ECore XML parsing against XXE (#29)#67
Merged
Conversation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Hardens ECoreParser.ParseXml against XML External Entity (XXE) attacks and entity-expansion DoS by setting DtdProcessing = Prohibit and XmlResolver = null on the XmlReaderSettings, and XmlResolver = null on the XmlDocument. Valid .ecore files (which contain no DTD) are unaffected.
Adds XxeHardeningTestFixture with regression tests proving that a document with an external SYSTEM entity and a "billion laughs" entity-expansion document are both rejected (XmlException) rather than resolved. Existing sample-model loading tests continue to pass.