From c8c6eeb9d0a841c475b1690a1e38789c05b1d6da Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 19:39:31 -0700 Subject: [PATCH 01/18] ci try 1 --- .github/workflows/ci.yml | 148 +++++++++++++++++++++++++++++++++++++++ README.md | 2 +- 2 files changed, 149 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..98f6c9ce --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,148 @@ +name: CI + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +env: + # Enable parallel builds + CMAKE_BUILD_PARALLEL_LEVEL: 4 + +jobs: + build-and-test-linux: + runs-on: ubuntu-latest + + strategy: + matrix: + build-type: [Debug, Release] + enable-coverage: [false, true] + include: + - build-type: Debug + enable-coverage: false + - build-type: Release + enable-coverage: false + - build-type: Release + enable-coverage: true + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Cache dependencies + uses: actions/cache@v4 + with: + path: | + ~/.cache/ccache + ~/.local + key: ${{ runner.os }}-deps-${{ hashFiles('**/CMakeLists.txt', '**/package.json', '**/requirements.txt') }} + restore-keys: | + ${{ runner.os }}-deps- + + - name: Install system dependencies + run: | + sudo apt-get update + sudo apt-get install -y \ + build-essential \ + cmake \ + bison \ + flex \ + libgmp-dev \ + libboost-program-options-dev \ + libboost-iostreams-dev \ + libboost-test-dev \ + libboost-thread-dev \ + libboost-system-dev \ + libreadline-dev \ + default-jre \ + gperf \ + python3-pip \ + ccache + + - name: Setup ccache + run: | + echo "CCACHE_DIR=$HOME/.cache/ccache" >> $GITHUB_ENV + ccache --max-size=1G + + - name: Install SMT solvers + run: | + bash contrib/install_yices2.sh + bash contrib/install_opensmt2.sh + bash contrib/install_dreal4.sh + + - name: Install coverage tools + if: matrix.enable-coverage + run: | + pip3 install --user cpp-coveralls + + - name: Configure and build + run: | + mkdir -p build + cd build + cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DENABLE_COVERAGE=${{ matrix.enable-coverage }} .. + make -j${{ env.CMAKE_BUILD_PARALLEL_LEVEL }} + + - name: Run tests + run: | + cd build + make check + timeout-minutes: 30 + + - name: Upload coverage to Coveralls + if: matrix.enable-coverage + run: | + cd build + coveralls -r .. -b . --gcov-options '\-lp' + env: + COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} + + - name: Show ccache statistics + run: ccache -s + + build-macos: + runs-on: macos-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Cache dependencies + uses: actions/cache@v4 + with: + path: | + ~/Library/Caches/Homebrew + ~/.cache/ccache + key: ${{ runner.os }}-deps-${{ hashFiles('**/CMakeLists.txt') }} + restore-keys: | + ${{ runner.os }}-deps- + + - name: Install dependencies via Homebrew + run: | + brew update + brew install cmake boost gmp bison flex readline ccache + + - name: Install Java + run: | + brew install --cask temurin + + - name: Setup ccache + run: | + echo "CCACHE_DIR=$HOME/.cache/ccache" >> $GITHUB_ENV + ccache --max-size=1G + + - name: Configure and build + run: | + mkdir -p build + cd build + cmake -DCMAKE_BUILD_TYPE=Release .. + make -j$(sysctl -n hw.ncpu) + + - name: Run tests + run: | + cd build + make check + timeout-minutes: 30 + + - name: Show ccache statistics + run: ccache -s diff --git a/README.md b/README.md index 3051e946..5a47d53d 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -[![Build Status](https://travis-ci.org/SRI-CSL/sally.svg?branch=master)](https://travis-ci.org/SRI-CSL/sally) +[![CI](https://github.com/SRI-CSL/sally/workflows/CI/badge.svg)](https://github.com/SRI-CSL/sally/actions?query=workflow%3ACI) [![Coverage Status](https://coveralls.io/repos/SRI-CSL/sally/badge.svg?branch=master)](https://coveralls.io/r/SRI-CSL/sally?branch=master) [![Coverity Scan Build Status](https://scan.coverity.com/projects/5578/badge.svg)](https://scan.coverity.com/projects/5578) From c485a5f1be0d4082a5a5a14bc4326c0fd412a33d Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 19:47:26 -0700 Subject: [PATCH 02/18] update macos ci --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 98f6c9ce..cbcbf9c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -122,6 +122,12 @@ jobs: brew update brew install cmake boost gmp bison flex readline ccache + - name: Install SMT solvers + run: | + bash contrib/install_yices2.sh + bash contrib/install_opensmt2.sh + bash contrib/install_dreal4.sh + - name: Install Java run: | brew install --cask temurin From b04d7a322df66596b6f2190f64076db0251327c4 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 19:53:19 -0700 Subject: [PATCH 03/18] update cxx version --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 59bb591f..cea35d9a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,7 +4,7 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") project(sally CXX C) enable_testing() -set(CMAKE_CXX_STANDARD 23) +set(CMAKE_CXX_STANDARD 11) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall") # If ENABLE_COVERAGE is defined, try to set coverage flags. From 06165f53da27f82d4a777e31292ce53c66c85309 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 19:57:41 -0700 Subject: [PATCH 04/18] fix cudd script for darwin --- contrib/install_yices2.sh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/contrib/install_yices2.sh b/contrib/install_yices2.sh index ce011727..9c884344 100755 --- a/contrib/install_yices2.sh +++ b/contrib/install_yices2.sh @@ -1,6 +1,15 @@ #!/bin/bash set -e +# Ensure autoreconf is available on macOS +if [[ "$(uname)" == "Darwin" ]]; then + if ! command -v autoreconf >/dev/null 2>&1; then + echo "[INFO] Installing autoconf and automake via Homebrew (macOS)..." + brew update + brew install autoconf automake + fi +fi + # libpoly pushd . git clone https://github.com/SRI-CSL/libpoly.git From 526373d67f6833677c3c52a9f215ca219deb44e9 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 20:03:12 -0700 Subject: [PATCH 05/18] update macos script --- .github/workflows/ci.yml | 2 +- contrib/install_yices2.sh | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cbcbf9c4..c9fd8ef1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -120,7 +120,7 @@ jobs: - name: Install dependencies via Homebrew run: | brew update - brew install cmake boost gmp bison flex readline ccache + brew install cmake boost gmp bison flex readline ccache autoconf automake libtool - name: Install SMT solvers run: | diff --git a/contrib/install_yices2.sh b/contrib/install_yices2.sh index 9c884344..e383a759 100755 --- a/contrib/install_yices2.sh +++ b/contrib/install_yices2.sh @@ -1,14 +1,6 @@ #!/bin/bash set -e -# Ensure autoreconf is available on macOS -if [[ "$(uname)" == "Darwin" ]]; then - if ! command -v autoreconf >/dev/null 2>&1; then - echo "[INFO] Installing autoconf and automake via Homebrew (macOS)..." - brew update - brew install autoconf automake - fi -fi # libpoly pushd . From 4a25cfb19c9d8f283b6d6ace7db9c93f135b86db Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 20:08:40 -0700 Subject: [PATCH 06/18] gmp issue on macos --- .github/workflows/ci.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c9fd8ef1..0039e3a6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -128,6 +128,18 @@ jobs: bash contrib/install_opensmt2.sh bash contrib/install_dreal4.sh + - name: Set up GMP environment variables (Homebrew) + run: | + # Find the Homebrew prefix + if [ -d /opt/homebrew ]; then + BREW_PREFIX=/opt/homebrew + else + BREW_PREFIX=/usr/local + fi + echo "LDFLAGS=-L$BREW_PREFIX/lib" >> $GITHUB_ENV + echo "CPPFLAGS=-I$BREW_PREFIX/include" >> $GITHUB_ENV + echo "PKG_CONFIG_PATH=$BREW_PREFIX/lib/pkgconfig" >> $GITHUB_ENV + - name: Install Java run: | brew install --cask temurin From d8e61177550980fc93960b16b0f6bd26d9c2a1c9 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 21:23:40 -0700 Subject: [PATCH 07/18] try --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0039e3a6..32ab3b21 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -139,6 +139,8 @@ jobs: echo "LDFLAGS=-L$BREW_PREFIX/lib" >> $GITHUB_ENV echo "CPPFLAGS=-I$BREW_PREFIX/include" >> $GITHUB_ENV echo "PKG_CONFIG_PATH=$BREW_PREFIX/lib/pkgconfig" >> $GITHUB_ENV + echo "CMAKE_PREFIX_PATH=$BREW_PREFIX" >> $GITHUB_ENV + echo "GMP_HOME=$BREW_PREFIX" >> $GITHUB_ENV - name: Install Java run: | @@ -153,7 +155,7 @@ jobs: run: | mkdir -p build cd build - cmake -DCMAKE_BUILD_TYPE=Release .. + cmake -DCMAKE_BUILD_TYPE=Release -DGMP_HOME=$BREW_PREFIX .. make -j$(sysctl -n hw.ncpu) - name: Run tests From 9261c62191755ad876537eebdb1d16d331847f99 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 21:31:35 -0700 Subject: [PATCH 08/18] try 2 --- .github/workflows/ci.yml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 32ab3b21..f69af8e1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,6 +141,17 @@ jobs: echo "PKG_CONFIG_PATH=$BREW_PREFIX/lib/pkgconfig" >> $GITHUB_ENV echo "CMAKE_PREFIX_PATH=$BREW_PREFIX" >> $GITHUB_ENV echo "GMP_HOME=$BREW_PREFIX" >> $GITHUB_ENV + # Also export for current shell + export LDFLAGS="-L$BREW_PREFIX/lib" + export CPPFLAGS="-I$BREW_PREFIX/include" + export PKG_CONFIG_PATH="$BREW_PREFIX/lib/pkgconfig" + export CMAKE_PREFIX_PATH="$BREW_PREFIX" + export GMP_HOME="$BREW_PREFIX" + echo "Environment variables set:" + echo "LDFLAGS=$LDFLAGS" + echo "CPPFLAGS=$CPPFLAGS" + echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH" + echo "GMP_HOME=$GMP_HOME" - name: Install Java run: | @@ -153,9 +164,15 @@ jobs: - name: Configure and build run: | + # Find the Homebrew prefix again for this step + if [ -d /opt/homebrew ]; then + BREW_PREFIX=/opt/homebrew + else + BREW_PREFIX=/usr/local + fi mkdir -p build cd build - cmake -DCMAKE_BUILD_TYPE=Release -DGMP_HOME=$BREW_PREFIX .. + cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. make -j$(sysctl -n hw.ncpu) - name: Run tests From a0fbdb2b2c369d02675b051d60e3c4468314a7cc Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 21:36:32 -0700 Subject: [PATCH 09/18] try 3 --- .github/workflows/ci.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f69af8e1..77205ede 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -141,17 +141,7 @@ jobs: echo "PKG_CONFIG_PATH=$BREW_PREFIX/lib/pkgconfig" >> $GITHUB_ENV echo "CMAKE_PREFIX_PATH=$BREW_PREFIX" >> $GITHUB_ENV echo "GMP_HOME=$BREW_PREFIX" >> $GITHUB_ENV - # Also export for current shell - export LDFLAGS="-L$BREW_PREFIX/lib" - export CPPFLAGS="-I$BREW_PREFIX/include" - export PKG_CONFIG_PATH="$BREW_PREFIX/lib/pkgconfig" - export CMAKE_PREFIX_PATH="$BREW_PREFIX" - export GMP_HOME="$BREW_PREFIX" - echo "Environment variables set:" - echo "LDFLAGS=$LDFLAGS" - echo "CPPFLAGS=$CPPFLAGS" - echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH" - echo "GMP_HOME=$GMP_HOME" + echo "Environment variables set for future steps." - name: Install Java run: | @@ -170,6 +160,16 @@ jobs: else BREW_PREFIX=/usr/local fi + export LDFLAGS="-L$BREW_PREFIX/lib" + export CPPFLAGS="-I$BREW_PREFIX/include" + export PKG_CONFIG_PATH="$BREW_PREFIX/lib/pkgconfig" + export CMAKE_PREFIX_PATH="$BREW_PREFIX" + export GMP_HOME="$BREW_PREFIX" + echo "Environment variables for build:" + echo "LDFLAGS=$LDFLAGS" + echo "CPPFLAGS=$CPPFLAGS" + echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH" + echo "GMP_HOME=$GMP_HOME" mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. From b8677ed52bfd12eb78d0e9760cbd286b96f2ac1a Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 21:43:07 -0700 Subject: [PATCH 10/18] try 4 --- .github/workflows/ci.yml | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 77205ede..e77d1980 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -128,21 +128,6 @@ jobs: bash contrib/install_opensmt2.sh bash contrib/install_dreal4.sh - - name: Set up GMP environment variables (Homebrew) - run: | - # Find the Homebrew prefix - if [ -d /opt/homebrew ]; then - BREW_PREFIX=/opt/homebrew - else - BREW_PREFIX=/usr/local - fi - echo "LDFLAGS=-L$BREW_PREFIX/lib" >> $GITHUB_ENV - echo "CPPFLAGS=-I$BREW_PREFIX/include" >> $GITHUB_ENV - echo "PKG_CONFIG_PATH=$BREW_PREFIX/lib/pkgconfig" >> $GITHUB_ENV - echo "CMAKE_PREFIX_PATH=$BREW_PREFIX" >> $GITHUB_ENV - echo "GMP_HOME=$BREW_PREFIX" >> $GITHUB_ENV - echo "Environment variables set for future steps." - - name: Install Java run: | brew install --cask temurin @@ -170,6 +155,7 @@ jobs: echo "CPPFLAGS=$CPPFLAGS" echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH" echo "GMP_HOME=$GMP_HOME" + export LD_LIBRARY_PATH=/usr/local/lib/:${LD_LIBRARY_PATH} mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. From c76734dfe877045bf638e4abda33dbeb01a38de9 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 21:47:32 -0700 Subject: [PATCH 11/18] try 5 --- contrib/install_yices2.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/install_yices2.sh b/contrib/install_yices2.sh index e383a759..0f4ce834 100755 --- a/contrib/install_yices2.sh +++ b/contrib/install_yices2.sh @@ -28,6 +28,7 @@ popd pushd . git clone https://github.com/SRI-CSL/yices2.git cd yices2 +export LD_LIBRARY_PATH=/usr/local/lib/:${LD_LIBRARY_PATH} autoconf ./configure --enable-mcsat make From b7ae537e86727c54665ba47df9360eda4455404b Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 22:02:43 -0700 Subject: [PATCH 12/18] try 6 --- contrib/install_yices2.sh | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/contrib/install_yices2.sh b/contrib/install_yices2.sh index 0f4ce834..a5f0fc16 100755 --- a/contrib/install_yices2.sh +++ b/contrib/install_yices2.sh @@ -1,6 +1,23 @@ #!/bin/bash set -e +# Find Homebrew prefix for macOS and set build flags for dependencies +if [[ "$(uname)" == "Darwin" ]]; then + if [ -d /opt/homebrew ]; then + BREW_PREFIX=/opt/homebrew + else + BREW_PREFIX=/usr/local + fi + export CPPFLAGS="-I$BREW_PREFIX/include" + export LDFLAGS="-L$BREW_PREFIX/lib" + export PKG_CONFIG_PATH="$BREW_PREFIX/lib/pkgconfig" + export LD_LIBRARY_PATH="$BREW_PREFIX/lib:$LD_LIBRARY_PATH" + echo "[INFO] macOS build flags set:" + echo "CPPFLAGS=$CPPFLAGS" + echo "LDFLAGS=$LDFLAGS" + echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH" + echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH" +fi # libpoly pushd . From 4cc9d8ba41d58a6fa5385cff0118eeaa4daef111 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 22:08:19 -0700 Subject: [PATCH 13/18] try 7 --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e77d1980..ff255e9a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -125,8 +125,6 @@ jobs: - name: Install SMT solvers run: | bash contrib/install_yices2.sh - bash contrib/install_opensmt2.sh - bash contrib/install_dreal4.sh - name: Install Java run: | From cb2248cc17994b6521ec7ceb0e0b61b11572cb66 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 22:09:41 -0700 Subject: [PATCH 14/18] try 8 --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ff255e9a..7f7c4055 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,8 +68,6 @@ jobs: - name: Install SMT solvers run: | bash contrib/install_yices2.sh - bash contrib/install_opensmt2.sh - bash contrib/install_dreal4.sh - name: Install coverage tools if: matrix.enable-coverage From c1d28e22b72057837c73a0c762b8c5d6ec21253f Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 22:25:10 -0700 Subject: [PATCH 15/18] try 9 --- .github/workflows/ci.yml | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7f7c4055..cfca27c7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,12 +18,8 @@ jobs: matrix: build-type: [Debug, Release] enable-coverage: [false, true] - include: + exclude: - build-type: Debug - enable-coverage: false - - build-type: Release - enable-coverage: false - - build-type: Release enable-coverage: true steps: @@ -135,23 +131,6 @@ jobs: - name: Configure and build run: | - # Find the Homebrew prefix again for this step - if [ -d /opt/homebrew ]; then - BREW_PREFIX=/opt/homebrew - else - BREW_PREFIX=/usr/local - fi - export LDFLAGS="-L$BREW_PREFIX/lib" - export CPPFLAGS="-I$BREW_PREFIX/include" - export PKG_CONFIG_PATH="$BREW_PREFIX/lib/pkgconfig" - export CMAKE_PREFIX_PATH="$BREW_PREFIX" - export GMP_HOME="$BREW_PREFIX" - echo "Environment variables for build:" - echo "LDFLAGS=$LDFLAGS" - echo "CPPFLAGS=$CPPFLAGS" - echo "CMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH" - echo "GMP_HOME=$GMP_HOME" - export LD_LIBRARY_PATH=/usr/local/lib/:${LD_LIBRARY_PATH} mkdir -p build cd build cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. From 8782ef3e82a3696dedb599b821d021709d97b9ea Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 22:43:11 -0700 Subject: [PATCH 16/18] try 10 --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cfca27c7..4c8f3115 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -77,11 +77,11 @@ jobs: cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DENABLE_COVERAGE=${{ matrix.enable-coverage }} .. make -j${{ env.CMAKE_BUILD_PARALLEL_LEVEL }} - - name: Run tests - run: | - cd build - make check - timeout-minutes: 30 + # - name: Run tests + # run: | + # cd build + # make check + # timeout-minutes: 30 - name: Upload coverage to Coveralls if: matrix.enable-coverage From 193a4d46dc7c66652ebf50da5dab6f031d2527ae Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 23:01:51 -0700 Subject: [PATCH 17/18] try 11 --- .github/workflows/ci.yml | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4c8f3115..44ff6c59 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,10 +17,10 @@ jobs: strategy: matrix: build-type: [Debug, Release] - enable-coverage: [false, true] - exclude: - - build-type: Debug - enable-coverage: true + #enable-coverage: [false, true] + #exclude: + # - build-type: Debug + # enable-coverage: true steps: - name: Checkout code @@ -65,16 +65,17 @@ jobs: run: | bash contrib/install_yices2.sh - - name: Install coverage tools - if: matrix.enable-coverage - run: | - pip3 install --user cpp-coveralls + #- name: Install coverage tools + # if: matrix.enable-coverage + # run: | + # pip3 install --user cpp-coveralls - name: Configure and build run: | mkdir -p build cd build - cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DENABLE_COVERAGE=${{ matrix.enable-coverage }} .. + #cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DENABLE_COVERAGE=${{ matrix.enable-coverage }} .. + cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} .. make -j${{ env.CMAKE_BUILD_PARALLEL_LEVEL }} # - name: Run tests @@ -83,13 +84,13 @@ jobs: # make check # timeout-minutes: 30 - - name: Upload coverage to Coveralls - if: matrix.enable-coverage - run: | - cd build - coveralls -r .. -b . --gcov-options '\-lp' - env: - COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} + #- name: Upload coverage to Coveralls + # if: matrix.enable-coverage + # run: | + # cd build + # coveralls -r .. -b . --gcov-options '\-lp' + # env: + # COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} - name: Show ccache statistics run: ccache -s From 0cf0b4fc3df463ff53d182dddbc1c67ba9c9e4f3 Mon Sep 17 00:00:00 2001 From: Ahmed <43099566+ahmed-irfan@users.noreply.github.com> Date: Mon, 23 Jun 2025 23:05:14 -0700 Subject: [PATCH 18/18] try 12 --- .github/workflows/ci.yml | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 44ff6c59..b9ced774 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -98,20 +98,14 @@ jobs: build-macos: runs-on: macos-latest + strategy: + matrix: + build-type: [Debug, Release] + steps: - name: Checkout code uses: actions/checkout@v4 - - name: Cache dependencies - uses: actions/cache@v4 - with: - path: | - ~/Library/Caches/Homebrew - ~/.cache/ccache - key: ${{ runner.os }}-deps-${{ hashFiles('**/CMakeLists.txt') }} - restore-keys: | - ${{ runner.os }}-deps- - - name: Install dependencies via Homebrew run: | brew update @@ -134,7 +128,7 @@ jobs: run: | mkdir -p build cd build - cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. + cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DCMAKE_PREFIX_PATH=$BREW_PREFIX .. make -j$(sysctl -n hw.ncpu) - name: Run tests