Skip to content

Commit 5271af8

Browse files
committed
return false on error and no origin provided
1 parent ddc6923 commit 5271af8

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

app/lib/methods/helpers/isSameOrigin.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ describe('isSameOrigin', () => {
1919
});
2020

2121
test('returns true when origin is undefined', () => {
22-
expect(isSameOrigin('https://releases.rocket.chat/x')).toBe(true);
22+
expect(isSameOrigin('https://releases.rocket.chat/x')).toBe(false);
2323
});
2424
});
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
export const isSameOrigin = (url: string, origin?: string): boolean => {
22
if (!origin) {
3-
return true;
3+
return false;
44
}
55
try {
6-
return new URL(url).origin === new URL(origin).origin;
6+
return new URL(url, origin).origin === new URL(origin).origin;
77
} catch {
8-
// Relative/internal URL — safe to attach auth headers.
9-
return true;
8+
return false;
109
}
1110
};

0 commit comments

Comments
 (0)