RU-T42 PR#214 fixes

Author: ucswift

.eslintignore

@@ -1,4 +1,4 @@
-.eslintignorenode_modules
+node_modules
 __tests__/
 .vscode/
 android/
@@ -7,4 +7,9 @@ ios/
 .expo
 .expo-shared
 docs/
-cli/
+cli/
+electron/
+fastlane/
+patches/
+public/
+scripts/

.eslintrc.js

@@ -1,11 +1,11 @@
 const path = require('path');
 
 module.exports = {
-  extends: ['expo', 'plugin:tailwindcss/recommended', 'prettier'],
-  plugins: ['prettier', 'unicorn', '@typescript-eslint', 'unused-imports', 'tailwindcss', 'simple-import-sort', 'eslint-plugin-react-compiler'],
-  parserOptions: {
-    project: './tsconfig.json',
-  },
+  extends: ['expo', 'prettier'],
+  plugins: ['prettier', 'unicorn', '@typescript-eslint', 'unused-imports', 'simple-import-sort', 'eslint-plugin-react-compiler'],
+  // parserOptions: {
+  //   project: './tsconfig.json',
+  // },
   rules: {
     'prettier/prettier': 'warn',
     'max-params': ['error', 10], // Limit the number of parameters in a function to use object instead
@@ -24,17 +24,10 @@ module.exports = {
       },
     ], // Ensure `import type` is used when it's necessary
     'import/prefer-default-export': 'off', // Named export is easier to refactor automatically
-    'import/no-cycle': ['error', { maxDepth: '∞' }],
-    'tailwindcss/classnames-order': [
-      'warn',
-      {
-        officialSorting: true,
-      },
-    ], // Follow the same ordering as the official plugin `prettier-plugin-tailwindcss`
+    'import/no-cycle': 'off', // Disabled due to performance issues
     'simple-import-sort/imports': 'error', // Import configuration for `eslint-plugin-simple-import-sort`
     'simple-import-sort/exports': 'error', // Export configuration for `eslint-plugin-simple-import-sort`
     '@typescript-eslint/no-unused-vars': 'off',
-    'tailwindcss/no-custom-classname': 'off',
     'unused-imports/no-unused-imports': 'off',
     'unused-imports/no-unused-vars': [
       'off',

__mocks__/react-native-svg.ts

@@ -0,0 +1,43 @@
+import React from 'react';
+
+const createMockComponent = (name: string) => {
+  const Component = React.forwardRef((props: any, ref: any) =>
+    React.createElement(name, { ...props, ref })
+  );
+  Component.displayName = name;
+  return Component;
+};
+
+export const Svg = createMockComponent('Svg');
+export const Circle = createMockComponent('Circle');
+export const Ellipse = createMockComponent('Ellipse');
+export const G = createMockComponent('G');
+export const Text = createMockComponent('SvgText');
+export const TSpan = createMockComponent('TSpan');
+export const TextPath = createMockComponent('TextPath');
+export const Path = createMockComponent('Path');
+export const Polygon = createMockComponent('Polygon');
+export const Polyline = createMockComponent('Polyline');
+export const Line = createMockComponent('Line');
+export const Rect = createMockComponent('Rect');
+export const Use = createMockComponent('Use');
+export const Image = createMockComponent('SvgImage');
+export const Symbol = createMockComponent('SvgSymbol');
+export const Defs = createMockComponent('Defs');
+export const LinearGradient = createMockComponent('LinearGradient');
+export const RadialGradient = createMockComponent('RadialGradient');
+export const Stop = createMockComponent('Stop');
+export const ClipPath = createMockComponent('ClipPath');
+export const Pattern = createMockComponent('Pattern');
+export const Mask = createMockComponent('Mask');
+export const ForeignObject = createMockComponent('ForeignObject');
+export const Marker = createMockComponent('Marker');
+export const SvgFromUri = createMockComponent('SvgFromUri');
+export const SvgFromXml = createMockComponent('SvgFromXml');
+export const SvgXml = createMockComponent('SvgXml');
+export const SvgUri = createMockComponent('SvgUri');
+export const SvgCss = createMockComponent('SvgCss');
+export const SvgCssUri = createMockComponent('SvgCssUri');
+export const parse = jest.fn();
+
+export default Svg;

electron/main.js

@@ -2,6 +2,7 @@
 const { app, BrowserWindow, ipcMain, Notification, nativeTheme, Menu, protocol, net } = require('electron');
 const path = require('path');
 const fs = require('fs');
+const { pathToFileURL } = require('url');
 
 // Register custom protocol scheme before app is ready
 // This allows serving the Expo web export with absolute paths (/_expo/static/...)
@@ -179,25 +180,35 @@ app.whenReady().then(() => {
   // Register custom protocol handler for serving the Expo web export
   // This resolves absolute paths like /_expo/static/js/... from the dist directory
   const distPath = path.join(__dirname, '..', 'dist');
+  const resolvedDist = path.resolve(distPath);
 
   protocol.handle('app', (request) => {
     const url = new URL(request.url);
     // Decode the pathname and resolve to a file in dist/
-    let filePath = path.join(distPath, decodeURIComponent(url.pathname));
-
-    // If the path points to a directory or file doesn't exist, fall back to index.html
-    // This supports SPA client-side routing
-    try {
-      const stat = fs.statSync(filePath);
-      if (stat.isDirectory()) {
-        filePath = path.join(distPath, 'index.html');
+    const resolvedPath = path.resolve(distPath, decodeURIComponent(url.pathname));
+
+    // Security check: ensure resolved path is within distPath to prevent directory traversal
+    let filePath;
+    if (!resolvedPath.startsWith(resolvedDist + path.sep) && resolvedPath !== resolvedDist) {
+      // Path escapes distPath - fall back to index.html
+      filePath = path.join(resolvedDist, 'index.html');
+    } else {
+      filePath = resolvedPath;
+
+      // If the path points to a directory or file doesn't exist, fall back to index.html
+      // This supports SPA client-side routing
+      try {
+        const stat = fs.statSync(filePath);
+        if (stat.isDirectory()) {
+          filePath = path.join(resolvedDist, 'index.html');
+        }
+      } catch {
+        // File not found - serve index.html for client-side routing
+        filePath = path.join(resolvedDist, 'index.html');
       }
-    } catch {
-      // File not found - serve index.html for client-side routing
-      filePath = path.join(distPath, 'index.html');
     }
 
-    return net.fetch('file://' + filePath);
+    return net.fetch(pathToFileURL(filePath).toString());
   });
 
   createMenu();

jest-setup.ts

@@ -6,6 +6,34 @@ global.window = {};
 // @ts-ignore
 global.window = global;
 
+// Mock react-native Platform globally
+// Must include `default` export because react-native/index.js and processColor.js
+// access Platform via require('./Libraries/Utilities/Platform').default
+jest.mock('react-native/Libraries/Utilities/Platform', () => {
+  const platform = {
+    OS: 'ios' as const,
+    select: jest.fn((obj: any) => obj.ios ?? obj.native ?? obj.default),
+    Version: 14,
+    constants: {
+      osVersion: '14.0',
+      interfaceIdiom: 'phone',
+      isTesting: true,
+      reactNativeVersion: { major: 0, minor: 76, patch: 0 },
+      systemName: 'iOS',
+    },
+    isTesting: true,
+    isPad: false,
+    isTV: false,
+    isVision: false,
+    isMacCatalyst: false,
+  };
+  return {
+    __esModule: true,
+    default: platform,
+    ...platform,
+  };
+});
+
 // Mock expo-audio globally
 jest.mock('expo-audio', () => ({
   createAudioPlayer: jest.fn(() => ({

package.json

@@ -35,7 +35,7 @@
     "build:internal:android": "cross-env APP_ENV=internal EXPO_NO_DOTENV=1 eas build --profile internal --platform android",
     "postinstall": "patch-package",
     "app-release": "cross-env SKIP_BRANCH_PROTECTION=true np --no-publish --no-cleanup --no-release-draft",
-    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "lint": "eslint src --ext .ts,.tsx --cache --cache-location node_modules/.cache/eslint",
     "type-check": "tsc  --noemit",
     "lint:translations": "eslint ./src/translations/ --fix --ext .json  ",
     "test": "jest --coverage=true --coverageReporters=cobertura",