fix(update): set_ids by symbol columns

Author: singaraiona

core/io.c

@@ -531,7 +531,7 @@ obj_p io_read_csv(i8_t *types, i64_t num_types, str_p buf, i64_t size, i64_t tot
     return NULL_OBJ;  // Success
 }
 
-static i64_t symbol_from_str_trimmed(str_p src, i64_t len) {
+i64_t io_symbol_from_str_trimmed(str_p src, i64_t len) {
     c8_t buf[256];  // Stack buffer for common case
     c8_t *trimmed;
     i64_t i, j = 0;
@@ -681,7 +681,7 @@ obj_p ray_read_csv(obj_p *x, i64_t n) {
                         pos--;
                 }
 
-                AS_SYMBOL(names)[i] = symbol_from_str_trimmed(prev, pos - prev);
+                AS_SYMBOL(names)[i] = io_symbol_from_str_trimmed(prev, pos - prev);
                 pos++;
                 len -= (pos - prev);
             }

core/io.h

@@ -41,5 +41,6 @@ obj_p io_set_table(obj_p path, obj_p table);
 obj_p io_set_table_splayed(obj_p path, obj_p table, obj_p symfile);
 obj_p io_get_table_splayed(obj_p path, obj_p symfile);
 obj_p io_read_csv(i8_t *types, i64_t num_types, str_p buf, i64_t size, i64_t total_lines, obj_p cols, c8_t sep);
+i64_t io_symbol_from_str_trimmed(str_p src, i64_t len);
 
 #endif  // IO_H

core/rayforce.c

@@ -1464,8 +1464,8 @@ obj_p set_ids(obj_p* obj, i64_t ids[], i64_t len, obj_p vals) {
             drop_obj(vals);
             return *obj;
         case MTYPE2(TYPE_I64, -TYPE_I64):
-        case MTYPE2(TYPE_SYMBOL, -TYPE_I64):
-        case MTYPE2(TYPE_TIMESTAMP, -TYPE_I64):
+        case MTYPE2(TYPE_SYMBOL, -TYPE_SYMBOL):
+        case MTYPE2(TYPE_TIMESTAMP, -TYPE_TIMESTAMP):
             for (i = 0; i < len; i++)
                 AS_I64(*obj)[ids[i]] = vals->i64;
             drop_obj(vals);
@@ -1513,8 +1513,8 @@ obj_p set_ids(obj_p* obj, i64_t ids[], i64_t len, obj_p vals) {
             drop_obj(vals);
             return *obj;
         case MTYPE2(TYPE_I64, TYPE_I64):
-        case MTYPE2(TYPE_SYMBOL, TYPE_I64):
-        case MTYPE2(TYPE_TIMESTAMP, TYPE_I64):
+        case MTYPE2(TYPE_SYMBOL, TYPE_SYMBOL):
+        case MTYPE2(TYPE_TIMESTAMP, TYPE_TIMESTAMP):
             for (i = 0; i < len; i++)
                 AS_I64(*obj)[ids[i]] = AS_I64(vals)[i];
             drop_obj(vals);

tests/lang.c

@@ -3188,6 +3188,57 @@ test_result_t test_lang_update() {
         "t",
         "(table [id val] (list [1i 2i 3i] [100i 300i 450i]))");
 
+    // ========== SYMBOL/TIMESTAMP UPDATE TESTS (regression for set_ids type handling) ==========
+
+    // Test 42: Update symbol column with symbol atom value and where clause
+    TEST_ASSERT_EQ(
+        "(set t (table [id name age] (list [1 2 3] ['alice 'bob 'charlie] [10 20 30])))"
+        "(update {name: 'baba from: 't where: (== age 10)})"
+        "t",
+        "(table [id name age] (list [1 2 3] [baba bob charlie] [10 20 30]))");
+
+    // Test 43: Update symbol column with symbol atom value (multiple rows match)
+    TEST_ASSERT_EQ(
+        "(set t (table [id name age] (list [1 2 3] ['alice 'bob 'charlie] [10 20 10])))"
+        "(update {name: 'updated from: 't where: (== age 10)})"
+        "t",
+        "(table [id name age] (list [1 2 3] [updated bob updated] [10 20 10]))");
+
+    // Test 44: Update symbol column without where clause (all rows)
+    TEST_ASSERT_EQ(
+        "(set t (table [id name] (list [1 2 3] ['x 'y 'z])))"
+        "(update {name: 'same from: 't})"
+        "t",
+        "(table [id name] (list [1 2 3] [same same same]))");
+
+    // Test 45: Update timestamp column with timestamp atom value and where clause
+    TEST_ASSERT_EQ(
+        "(set t (table [id ts val] (list [1 2 3] [2024.01.01D00:00:00.0 2024.01.02D00:00:00.0 2024.01.03D00:00:00.0] [10 20 30])))"
+        "(update {ts: 2025.06.15D12:30:00.0 from: 't where: (== val 20)})"
+        "t",
+        "(table [id ts val] (list [1 2 3] [2024.01.01D00:00:00.000000000 2025.06.15D12:30:00.000000000 2024.01.03D00:00:00.000000000] [10 20 30]))");
+
+    // Test 46: Update timestamp column with timestamp atom value (multiple rows match)
+    TEST_ASSERT_EQ(
+        "(set t (table [id ts val] (list [1 2 3] [2024.01.01D00:00:00.0 2024.01.02D00:00:00.0 2024.01.03D00:00:00.0] [10 20 10])))"
+        "(update {ts: 2099.12.31D23:59:59.0 from: 't where: (== val 10)})"
+        "t",
+        "(table [id ts val] (list [1 2 3] [2099.12.31D23:59:59.000000000 2024.01.02D00:00:00.000000000 2099.12.31D23:59:59.000000000] [10 20 10]))");
+
+    // Test 47: Update timestamp column without where clause (all rows)
+    TEST_ASSERT_EQ(
+        "(set t (table [id ts] (list [1 2 3] [2024.01.01D00:00:00.0 2024.01.02D00:00:00.0 2024.01.03D00:00:00.0])))"
+        "(update {ts: 2000.01.01D00:00:00.0 from: 't})"
+        "t",
+        "(table [id ts] (list [1 2 3] [2000.01.01D00:00:00.000000000 2000.01.01D00:00:00.000000000 2000.01.01D00:00:00.000000000]))");
+
+    // Test 48: Update both symbol and timestamp columns in same update
+    TEST_ASSERT_EQ(
+        "(set t (table [id name ts] (list [1 2] ['alice 'bob] [2024.01.01D00:00:00.0 2024.01.02D00:00:00.0])))"
+        "(update {name: 'updated ts: 2025.01.01D00:00:00.0 from: 't where: (== id 1)})"
+        "t",
+        "(table [id name ts] (list [1 2] [updated bob] [2025.01.01D00:00:00.000000000 2024.01.02D00:00:00.000000000]))");
+
     PASS();
 }