feat: add remote storage loaders and writers (S3, GCS, Azure Blob, SQL)#1102
Open
CoronRing wants to merge 5 commits into
Open
feat: add remote storage loaders and writers (S3, GCS, Azure Blob, SQL)#1102CoronRing wants to merge 5 commits into
CoronRing wants to merge 5 commits into
Conversation
4cdece1 to
b354919
Compare
Pooria90
reviewed
May 21, 2026
Pooria90
reviewed
May 21, 2026
Pooria90
reviewed
May 21, 2026
5a4c7fe to
57be8ec
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…iter Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
57be8ec to
e0e6f9e
Compare
Pooria90
requested changes
May 22, 2026
Contributor
Pooria90
left a comment
There was a problem hiding this comment.
Good work @CoronRing
I went over the code. A few substantial changes needs to be applied:
- We need to move
loadersandwritersmodules topackages/railtracks/src/railtracks/retrieval/loadersas they are being built on top of Amir's work on loaders. I recommend having all classes for a specific provider under one single module: for example havingloaders/s3.pyandwriters/s3.pyall under ones3.py.
Or we can also have them under aloaders/cloudfolder. We can discuss the structure. - The modules are returning
Chunkwhich is located in our oldvector_storesmodule. That module is deprecated now and will be removed from the framework. The new type that we use for our retrieval module is calledDocumentwhich is located inpackages/railtracks/src/railtracks/retrieval/models.py. Please refer to Amir's loaders for examples. - Please adjust the Base classes, data models, and the docs accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3Loader/S3Writer,GCSLoader/GCSWriter,AzureBlobLoader/AzureBlobWriter, andSQLLoader/SQLWriterunderrailtracks.loadersandrailtracks.writersrailtracks[aws],railtracks[gcp],railtracks[azure-blob],railtracks[sql]) so the core package stays leanload/aload,write/awrite)with SQLLoader(...) as l) and explicitclose()for engine lifecycle managementdocs/integrations/storage/with pip + uv install tabs, security callouts, and provider-specific auth guidanceSecurity hardening
__init__time — raisesValueErroron any metacharacter ([A-Za-z_][A-Za-z0-9_$]*allowlist, supportsschema.table)ValueErrorwhencontent_columnis missing from query results (was a bareKeyError)__repr__on all classes exposes only non-sensitive fields (bucket/container name); credentials never appear in reprUserWarningemitted whenprefixis passed toSQLLoader.load()orSQLWriter.write()(unsupported, silently ignored before)ImportErrormessages include bothpip installanduv addformsLimitations documented
WITH …) queries not supported astable_or_query; workaround shown in docsaload/awriteare thread-backed (asyncio.to_thread) not true-async; noted in docs with guidance for high-concurrency casesSQLWriter.write()is all-or-nothing (single transaction); partial-failure pattern documentedTest plan
🤖 Generated with Claude Code