Direct and Persistent Interfaces to SCIP#3744
Merged
Merged
Conversation
Co-authored-by: Miranda Mundt <55767766+mrmundt@users.noreply.github.com>
michaelbynum
changed the title
This was
linked to
issues
May 15, 2026
mrmundt
approved these changes
May 15, 2026
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
Test results depending. I made the changes I wanted to see already.
Contributor
Author
|
Thanks, @mrmundt! I've been meaning to split that file up for a while now... |
Contributor
Author
|
(It completely slipped my mind) |
Contributor
Author
|
I confirmed that |
Contributor
Author
|
@mrmundt - I made a few minor changes since you reviewed in order to improve test coverage. |
blnicho
approved these changes
May 18, 2026
mrmundt
approved these changes
May 18, 2026
jsiirola
reviewed
May 18, 2026
| for con in cons: | ||
| self._add_sos_constraint(con) | ||
|
|
||
| def _create_solver_model(self, model, config): |
Member
There was a problem hiding this comment.
This routine should be updated to use the component_data_collector so that unhandled component errors are raised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #849, #3107, #1615.
Summary/Motivation:
The primary purpose of the PR is to port the direct and persistent interfaces for SCIP from #3200 to contrib/solver. I worked off of the branch created by @Opt-Mucca, so all of their commits are preserved. I will close #3200 shortly.
Changes proposed in this PR:
ModelChangeDetectorincontrib/observerslightlyLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: