replace schtasks with scheduletask commandlet

mark last few potential legacy commands

Author: mastercoms

pbpy/pbtools.py

@@ -240,6 +240,7 @@ def it_has_all(it, *args):
 def whereis(app):
     result = None
 
+    # todo: do we need a replacement for this?
     command = "where"
     if os.name != "nt":
         command = "which"
@@ -468,11 +469,24 @@ def maintain_repo():
 
     if os.name == "nt" and pbgit.get_git_executable() == "git":
         proc = run_with_combined_output(
-            ["schtasks" "/query", "/TN", "Git for Windows Updater"]
+            [
+                "powershell",
+                "-Command",
+                "Get-ScheduledTask",
+                "-TaskName",
+                '"Git for Windows Updater"',
+            ]
         )
         # if exists
         if proc.returncode == 0:
-            cmdline = ["schtasks", "/delete", "/F", "/TN", '"Git for Windows Updater"']
+            cmdline = [
+                "powershell",
+                "-Command",
+                "Unregister-ScheduledTask",
+                "-TaskName",
+                '"Git for Windows Updater"',
+                "-Confirm:$false",
+            ]
             pblog.info(
                 "Requesting admin permission to delete the Git for Windows Updater..."
             )
@@ -492,9 +506,9 @@ def maintain_repo():
         == "hourly"
     )
     if not does_maintainence:
-        commands.insert(0, f"scalar register .")
+        commands.insert(0, "scalar register .")
     else:
-        commands.insert(0, f"scalar reconfigure .")
+        commands.insert(0, "scalar reconfigure .")
 
     # fill in the git repo optionally
     is_shallow = get_one_line_output(

pbpy/pbunreal.py

@@ -362,6 +362,7 @@ def uses_longtail():
 
 def check_ue_file_association():
     if os.name == "nt":
+        # todo: do we need a replacement for this?
         file_assoc_result = pbtools.get_combined_output(["assoc", uproject_ext])
         return "Unreal.ProjectFile" in file_assoc_result
     else:
@@ -659,6 +660,7 @@ def get_unreal_version_selector_path():
         )
         if selector_path.exists():
             return selector_path, True
+    # todo: do we need a replacement for this?
     ftype_info = pbtools.get_one_line_output(["ftype", "Unreal.ProjectFile"])
     if ftype_info is not None:
         ftype_split = ftype_info.split('"')
@@ -1221,6 +1223,7 @@ def get_sln_path():
 
 @lru_cache()
 def get_vs_basepath():
+    # todo: do we need a replacement for this?
     return pbtools.get_one_line_output(
         [
             "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere.exe",

pbsync/actions.py

@@ -6,7 +6,6 @@
 from pbpy import pbconfig, pbgh, pbgit, pblog, pbtools, pbunreal
 from pbsync import prereqs
 
-
 actions = {}
 action_pairs = {}
 active_pairs = {}
@@ -304,6 +303,7 @@ def launch_project():
         os.startfile(pbunreal.get_sln_path())
     elif launch_pref == "rider":
         pblog.info("Launching Rider...")
+        # todo: do we need a replacement for this?
         rider_bin = pbtools.get_one_line_output(["echo", "%Rider for Unreal Engine%"])
         rider_bin = rider_bin.replace(";", "")
         rider_bin = rider_bin.replace('"', "")