fix checkpoint deployment cli validation

Author: kevinjosethomas

packages/prime/src/prime_cli/commands/deployments.py

@@ -192,7 +192,19 @@ def create_deployment(
 
         prime deployments create --checkpoint-id <checkpoint_id>
     """
-    if model_id and checkpoint_id:
+    if model_id is not None:
+        model_id = model_id.strip()
+        if not model_id:
+            console.print("[red]Error:[/red] MODEL_ID cannot be empty.")
+            raise typer.Exit(1)
+
+    if checkpoint_id is not None:
+        checkpoint_id = checkpoint_id.strip()
+        if not checkpoint_id:
+            console.print("[red]Error:[/red] --checkpoint-id cannot be empty.")
+            raise typer.Exit(1)
+
+    if model_id is not None and checkpoint_id is not None:
         console.print("[red]Error:[/red] Use either MODEL_ID or --checkpoint-id, not both.")
         raise typer.Exit(1)
 
@@ -204,7 +216,7 @@ def create_deployment(
         api_client = APIClient()
         deployments_client = DeploymentsClient(api_client)
 
-        if checkpoint_id:
+        if checkpoint_id is not None:
             console.print("[bold]Deploying checkpoint:[/bold]")
             console.print(f"  Checkpoint ID: {checkpoint_id}")
             console.print()

packages/prime/tests/test_deployments.py

@@ -1,5 +1,5 @@
 from types import SimpleNamespace
-from typing import Any
+from typing import Any, cast
 
 from prime_cli.api.deployments import DeploymentsClient
 from prime_cli.client import APIError
@@ -98,7 +98,7 @@ def post(self, endpoint: str, json: dict[str, Any] | None = None) -> dict:
             captured["json"] = json
             return _adapter_response()
 
-    adapter = DeploymentsClient(DummyAPIClient()).deploy_checkpoint("ckpt-123")
+    adapter = DeploymentsClient(cast(Any, DummyAPIClient())).deploy_checkpoint("ckpt-123")
 
     assert captured["endpoint"] == "/rft/checkpoints/ckpt-123/deploy"
     assert captured["json"] is None
@@ -145,6 +145,20 @@ def deploy_checkpoint(self, checkpoint_id: str) -> Any:
     assert "prime deployments list" in output
 
 
+def test_deployments_create_checkpoint_rejects_empty_checkpoint_id(monkeypatch) -> None:
+    monkeypatch.setattr("prime_cli.main.check_for_update", lambda: (False, None))
+
+    result = runner.invoke(
+        app,
+        ["deployments", "create", "--checkpoint-id", "", "--yes"],
+        env=TEST_ENV,
+    )
+    output = strip_ansi(result.output)
+
+    assert result.exit_code == 1
+    assert "Error: --checkpoint-id cannot be empty." in output
+
+
 def test_deployments_create_checkpoint_surfaces_conflict_errors(monkeypatch) -> None:
     monkeypatch.setattr("prime_cli.main.check_for_update", lambda: (False, None))