Apply review suggestions

- Use getString() instead of get() for typed parameter access
- Use dirname(__DIR__, N) instead of __DIR__.'/..' concatenation

Author: Rafikooo

Controller/NotifyController.php

@@ -9,7 +9,7 @@ class NotifyController extends PayumController
 {
     public function doUnsafeAction(Request $request): Response
     {
-        $gateway = $this->getPayum()->getGateway($request->attributes->get('gateway'));
+        $gateway = $this->getPayum()->getGateway($request->attributes->getString('gateway'));
 
         $gateway->execute(new Notify(null));
 

DependencyInjection/Factory/Storage/DoctrineStorageFactory.php

@@ -32,7 +32,7 @@ public function addConfiguration(ArrayNodeDefinition $builder): void
 
     protected function createStorage(ContainerBuilder $container, string $modelClass, array $config): ChildDefinition
     {
-        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../../Resources/config/storage'));
+        $loader = new PhpFileLoader($container, new FileLocator(dirname(__DIR__, 3).'/Resources/config/storage'));
         $loader->load('doctrine.'.$config['driver'].'.php');
 
         $storage = new ChildDefinition(sprintf('payum.storage.doctrine.%s', $config['driver']));

DependencyInjection/Factory/Storage/FilesystemStorageFactory.php

@@ -29,7 +29,7 @@ public function addConfiguration(ArrayNodeDefinition $builder): void
 
     protected function createStorage(ContainerBuilder $container, string $modelClass, array $config): ChildDefinition
     {
-        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../../Resources/config/storage'));
+        $loader = new PhpFileLoader($container, new FileLocator(dirname(__DIR__, 3).'/Resources/config/storage'));
         $loader->load('filesystem.php');
 
         $storage = new ChildDefinition('payum.storage.filesystem.prototype');

DependencyInjection/Factory/Storage/Propel1StorageFactory.php

@@ -18,7 +18,7 @@ public function getName(): string
 
     protected function createStorage(ContainerBuilder $container, string $modelClass, array $config): ChildDefinition
     {
-        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../../Resources/config/storage'));
+        $loader = new PhpFileLoader($container, new FileLocator(dirname(__DIR__, 3).'/Resources/config/storage'));
         $loader->load('propel1.php');
 
         $storage = new ChildDefinition('payum.storage.propel1');

DependencyInjection/Factory/Storage/Propel2StorageFactory.php

@@ -18,7 +18,7 @@ public function getName(): string
 
     protected function createStorage(ContainerBuilder $container, string $modelClass, array $config): ChildDefinition
     {
-        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../../../Resources/config/storage'));
+        $loader = new PhpFileLoader($container, new FileLocator(dirname(__DIR__, 3).'/Resources/config/storage'));
         $loader->load('propel2.php');
 
         $storage = new ChildDefinition('payum.storage.propel2');

DependencyInjection/PayumExtension.php

@@ -52,7 +52,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $config = $this->processConfiguration($mainConfig, $configs);
 
         // load services
-        $loader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new PhpFileLoader($container, new FileLocator(dirname(__DIR__).'/Resources/config'));
         $loader->load('payum.php');
         $loader->load('commands.php');
         $loader->load('controller.php');

Security/HttpRequestVerifier.php

@@ -36,7 +36,7 @@ public function verify($httpRequest)
             ));
         }
 
-        if (! $hash = $httpRequest->attributes->get('payum_token', $httpRequest->query->get('payum_token', $httpRequest->request->get('payum_token')))) {
+        if (! $hash = $httpRequest->attributes->getString('payum_token', $httpRequest->query->getString('payum_token', $httpRequest->request->getString('payum_token')))) {
             throw new NotFoundHttpException('Token parameter not set in request');
         }