Defenders are listed in duplicate when using defenders list

[dukekautington3rd]

Describe the bug

pc defenders list produces duplicate output of each defender

Expected behavior

I would expect to see a single entry for each defender.

Current behavior

When using pc defenders list and any output format, each defender is listed double.

Possible solution

Discover why this duplicate output happens.
During debug I noticed that the data stored from the api call, is singular and doesn't seem to become duplicate until formatting or output occurs.

Steps to reproduce

pc defenders list

Screenshots

Output from command showing double:

Debug showing single data store:

Context

None needed

Your Environment

• Version used: Python 3.10.6
• Operating System and version (desktop or mobile): MacOS

[dukekautington3rd]

Also pc discovery results are duplicated.

The duplication appears to be happening during the data_frame = flatten_nested_json_df(data_frame_normalized)
flatten_nested_json_df function

[dukekautington3rd]

The following edit produces the appropriate output (singular). This essentially bypasses the whole flatten function, but I fear this would cause issues with other outputs.

diff --git a/prismacloud/cli/__init__.py b/prismacloud/cli/__init__.py
index 70942a6..d30280a 100644
--- a/prismacloud/cli/__init__.py
+++ b/prismacloud/cli/__init__.py
@@ -222,7 +222,8 @@ def process_data_frame(data):
     # If the size of our normalized data is 0, something went wrong but no exception was raised.
     if data_frame_normalized.size > 0:
         logging.debug("Using json_normalize() data")
-        data_frame = flatten_nested_json_df(data_frame_normalized)
+        # data_frame = flatten_nested_json_df(data_frame_normalized)
+        data_frame = data_frame_normalized
     else:
         try:
             data_frame = pd.DataFrame(data)

[steven-deboer]

There is much room for improvement within the flatten function. Will keep it open for now and look for a permanent improvement for this.

[SimOnPanw]

@steven-deboer, I open a pull request on this. Can you review it ?
#91

[sgordon46]

@dukekautington3rd This PR has been merged and it fixed the issue for me. Take a look and we can close this issue if it is solved.