F #7172: refresh actions (#3880)

- Upgrade zeromq to 6.5.1
- Upgrade fast-xml-parser to v4
- Remove manual HE encoding
- Update PCI profile selector
- Add missing data-cy selector(s)
- Reverts 524da99 (This needs to be further tested to measure performance impact => Uploaded files are not deleted from /var/tmp one#7252)
- Fixes sec_group update call

Signed-off-by: Victor Hansson <vhansson@opennebula.io>
Co-authored-by: Jorge Miguel Lobo Escalona <jlobo@opennebula.io>

Author: vichansson

src/fireedge/package-lock.json

@@ -18,6 +18,7 @@
     "build:remotes": "npm run build:um && npm run build:cm && npm run build:ctm && npm run build:cpm && npm run build:mm && npm run build:fm && npm run build:hm && npm run build:pm",
     "build": "NODE_ENV=production npm run build-client && NODE_ENV=production npm run build-server && NODE_ENV=production npm run build:remotes",
     "start": "NODE_ENV=production node ./dist/index.js",
+    "start:dev": "NODE_ENV=development node ./dist/index.js",
     "pot": "node potfile.js",
     "po2json": "node po2json.js",
     "lint": "npm run lint-client && npm run lint-server",
@@ -92,7 +93,7 @@
     "dompurify": "2.2.6",
     "express": "4.17.1",
     "external-remotes-plugin": "1.0.0",
-    "fast-xml-parser": "3.19.0",
+    "fast-xml-parser": "4.4.1",
     "file-loader": "5.1.0",
     "fs-extra": "9.0.1",
     "fuse.js": "6.4.1",
@@ -168,6 +169,6 @@
     "xmlrpc": "1.3.2",
     "yaml": "1.10.0",
     "yup": "0.32.9",
-    "zeromq": "5.2.0"
+    "zeromq": "6.5.0"
   }
 }

src/fireedge/package.json

@@ -14,8 +14,8 @@
  * limitations under the License.                                            *
  * ------------------------------------------------------------------------- */
 import { Box, Stack, Tooltip, Typography, useTheme } from '@mui/material'
-import PropTypes from 'prop-types'
 import { getResourceLabels, prettyBytes } from '@UtilsModule'
+import PropTypes from 'prop-types'
 import { ReactElement, memo, useMemo } from 'react'
 
 import {

src/fireedge/src/modules/components/Cards/VirtualMachineCard.js

@@ -26,11 +26,11 @@ import { T, INPUT_TYPES } from '@ConstantsModule'
 import { uniqWith } from 'lodash'
 import { useFormContext } from 'react-hook-form'
 
-const samePciDevice = (obj1, obj2) =>
-  obj1.VENDOR === obj2.VENDOR &&
-  obj1.DEVICE === obj2.DEVICE &&
-  obj1.CLASS === obj2.CLASS &&
-  obj1.SHORT_ADDRESS === obj2.SHORT_ADDRESS
+const samePciDevice = (a, b) =>
+  a &&
+  b &&
+  ['DEVICE', 'VENDOR', 'CLASS'].every((k) => a[k] === b[k]) &&
+  a.SHORT_ADDRESS?.split('.')[0] === b.SHORT_ADDRESS?.split('.')[0]
 
 /**
  * Transform a PCI device to String.
@@ -81,6 +81,8 @@ const NAME_FIELD = {
 
     return arrayToOptions(uniqWith(pciDevices, samePciDevice), {
       getText: ({ DEVICE_NAME } = {}) => DEVICE_NAME,
+      addDescription: true,
+      getDescription: (opt) => opt?.TYPE,
       getValue: transformPciToString,
     })
   },

src/fireedge/src/modules/components/Forms/Vm/AttachPciForm/schema.js

@@ -20,7 +20,6 @@ import {
   decodeBase64,
   getUnknownAttributes,
   isBase64,
-  transformXmlString,
 } from '@UtilsModule'
 import { set } from 'lodash'
 import { reach } from 'yup'
@@ -74,7 +73,7 @@ const UpdateConfigurationForm = createForm(SCHEMA, undefined, {
       if (template.RAW.DATA) {
         // DATA exists, so we add TYPE and transform DATA
         knownTemplate.RAW.TYPE = template.HYPERVISOR
-        knownTemplate.RAW.DATA = transformXmlString(template.RAW.DATA)
+        knownTemplate.RAW.DATA = template.RAW.DATA
       } else {
         // DATA doesn't exist, remove RAW from template
         delete knownTemplate.RAW

src/fireedge/src/modules/components/Forms/Vm/UpdateConfigurationForm/index.js

@@ -231,7 +231,7 @@ export const DISK_COST = generateCostCapacityInput({
     step: 0.1,
     inputProps: {
       setValueAs: (v) => (v === '' ? undefined : Number(v)),
-      'data-cy': 'general-showback-DISK_COST',
+      'data-cy': 'general-showback-DISK_COST', // Overwrites auto generated data cy
     },
     helperText: <HelperDiskCost />,
   }),

src/fireedge/src/modules/components/Forms/VmTemplate/CreateForm/Steps/General/capacitySchema.js

@@ -136,7 +136,7 @@ const StatusChip = memo(
 
 StatusChip.propTypes = {
   stateColor: PropTypes.string,
-  text: PropTypes.oneOfType([PropTypes.string, PropTypes.node]),
+  text: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),
   clipboard: PropTypes.oneOfType([PropTypes.bool, PropTypes.string]),
   forceWhiteColor: PropTypes.bool,
   dataCy: PropTypes.string,

src/fireedge/src/modules/components/Status/Chip.js

@@ -124,7 +124,7 @@ Pagination.propTypes = {
   useTableProps: PropTypes.object.isRequired,
   count: PropTypes.number.isRequired,
   showPageCount: PropTypes.bool,
-  styles: PropTypes.object,
+  styles: PropTypes.oneOfType([PropTypes.object, PropTypes.string]),
 }
 
 export default Pagination

src/fireedge/src/modules/components/Tables/Enhanced/pagination.js

@@ -28,7 +28,12 @@ import Information from '@modules/components/Tabs/SecurityGroup/Info/information
 
 import { Tr } from '@modules/components/HOC'
 import { T } from '@ConstantsModule'
-import { getActionsAvailable, jsonToXml, filterAttributes, prettySecurityGroup } from '@ModelsModule'
+import {
+  getActionsAvailable,
+  jsonToXml,
+  filterAttributes,
+  prettySecurityGroup,
+} from '@ModelsModule'
 import { cloneObject, set } from '@UtilsModule'
 
 const HIDDEN_ATTRIBUTES = /^(RULE)$/
@@ -131,11 +136,12 @@ const SecurityGroupInfoTab = ({ tabProps = {}, id }) => {
       {rulesPanel?.enabled && (
         <RulesSecGroupsTable
           title={Tr(T.SecurityGroup)}
-          rules={
-            (Array.isArray(TEMPLATE?.RULE) ? TEMPLATE?.RULE : [TEMPLATE?.RULE])
-              .filter(Boolean)
-              .map(prettySecurityGroup)
-          }
+          rules={(Array.isArray(TEMPLATE?.RULE)
+            ? TEMPLATE?.RULE
+            : [TEMPLATE?.RULE]
+          )
+            .filter(Boolean)
+            .map(prettySecurityGroup)}
         />
       )}
       {attributesPanel?.enabled && (

src/fireedge/src/modules/components/Tabs/SecurityGroup/Info/index.js

@@ -106,7 +106,10 @@ const SecurityTab = ({
   const { data: vnet } = VnAPI.useGetVNetworkQuery({ id })
 
   const [update] = VnAPI.useUpdateVNetMutation()
-  const splittedSecGroups = vnet?.TEMPLATE.SECURITY_GROUPS?.split(',') ?? []
+
+  const splittedSecGroups = []
+    .concat(vnet?.TEMPLATE?.SECURITY_GROUPS)
+    ?.flatMap((n) => String(n)?.split(','))
   const secGroups = [splittedSecGroups].flat().map((sgId) => +sgId)
 
   const { enqueueSuccess } = useGeneralApi()