B #7590: set target bus on disk hotplug

using SD_DISK_BUS when available.

Check if the bus is SATA and raisese error as it is unsupported.

Author: atodorov-storpool

src/mad/sh/scripts_common.sh

@@ -931,6 +931,7 @@ function get_disk_information {
         XPATH_ELEMENTS[i++]="$element"
     done < <($CMD       /VMM_DRIVER_ACTION_DATA/VM/ID \
                         /VMM_DRIVER_ACTION_DATA/VM/TEMPLATE/VCPU \
+                        /VMM_DRIVER_ACTION_DATA//OS/SD_DISK_BUS \
                         $DISK_XPATH/DRIVER \
                         $DISK_XPATH/TYPE \
                         $DISK_XPATH/READONLY \
@@ -980,6 +981,7 @@ function get_disk_information {
 
     VMID="${XPATH_ELEMENTS[j++]}"
     VCPU="${XPATH_ELEMENTS[j++]:-1}"
+    SD_DISK_BUS="${XPATH_ELEMENTS[j++]}"
     DRIVER="${XPATH_ELEMENTS[j++]:-$DEFAULT_TYPE}"
     TYPE="${XPATH_ELEMENTS[j++]}"
     READONLY="${XPATH_ELEMENTS[j++]}"

src/vmm_mad/remotes/kvm/attach_disk

@@ -118,7 +118,14 @@ XML+="</source>"
 
 [ -n "${AUTH}" ] && XML+=" ${AUTH}"
 
-XML+="<target dev='$(xml_esc "${TARGET}")'/>"
+if [[ -n "${SD_DISK_BUS}" ]]; then
+    if [[ "${SD_DISK_BUS,,}" == "sata" ]]; then
+        log_error "The SATA disks are not hot-pluggable!"
+        exit 1
+    fi
+    [[ "${TARGET:0:2}" == "sd" ]] && TARGET_BUS="bus='$(xml_esc "${SD_DISK_BUS,,}")'" || TARGET_BUS=""
+fi
+XML+="<target dev='$(xml_esc "${TARGET}")'${TARGET_BUS:+ ${TARGET_BUS}}/>"
 [ -n "${ORDER}" ] && XML+=" <boot order='$(xml_esc "${ORDER}")'/>"
 [ "${READONLY}" = 'yes' ] && XML+="<readonly/>"
 [ "${SHAREABLE}" = 'yes' ] && XML+="<shareable/>"