F #7494: Improve message when scheduler fails

Include more specific reasons when a VM cannot be scheduled.
Increased sheduling matching and dispatch errors to DDDEBUG category

co-authored-by: MarioRobres <mrobres@opennebula.io>

Author: rsmontero

src/schedm_mad/remotes/rank/include/HostXML.h

@@ -23,6 +23,7 @@
 #include "ObjectXML.h"
 #include "HostShare.h"
 #include "PoolObjectAuth.h"
+#include "SchedulerFailure.h"
 
 /**
  *  This class represents the needed information HostShare for a Host to
@@ -38,9 +39,11 @@ class HostShareXML
     /**
      *  Tests whether a new VM can be hosted by the host or not
      *    @param sr the share request including CPU, memory, PCI and NUMA nodes
+     *    @param error error reason
+     *    @param ft failure type
      *    @return true if the share can host the VM
      */
-    bool test_capacity(HostShareCapacity& sr, std::string & error);
+    bool test_capacity(HostShareCapacity& sr, std::string & error, SchedulerFailure::FailureType & ft);
 
     /**
      *  Adds a new VM to the given share by incrementing the cpu,mem and disk
@@ -178,11 +181,12 @@ class HostXML : public ObjectXML
      *    @param sr, the host share capacity request including cpu, mem, pci
      *    devices and numa topology
      *    @param error error message
+     *    @param ft FailureType
      *    @return true if the share can host the VM
      */
-    bool test_capacity(HostShareCapacity &sr, std::string & error)
+    bool test_capacity(HostShareCapacity &sr, std::string & error, SchedulerFailure::FailureType & ft)
     {
-        return share.test_capacity(sr, error);
+        return share.test_capacity(sr, error, ft);
     }
 
     /**

src/schedm_mad/remotes/rank/include/SchedulerFailure.h

@@ -0,0 +1,75 @@
+/* -------------------------------------------------------------------------- */
+/* Copyright 2002-2025, OpenNebula Project, OpenNebula Systems                */
+/*                                                                            */
+/* Licensed under the Apache License, Version 2.0 (the "License"); you may    */
+/* not use this file except in compliance with the License. You may obtain    */
+/* a copy of the License at                                                   */
+/*                                                                            */
+/* http://www.apache.org/licenses/LICENSE-2.0                                 */
+/*                                                                            */
+/* Unless required by applicable law or agreed to in writing, software        */
+/* distributed under the License is distributed on an "AS IS" BASIS,          */
+/* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.   */
+/* See the License for the specific language governing permissions and        */
+/* limitations under the License.                                             */
+/* -------------------------------------------------------------------------- */
+
+#ifndef SCHEDULER_FAILURE_H_
+#define SCHEDULER_FAILURE_H_
+
+#include <string>
+#include <map>
+#include <set>
+#include <iostream>
+
+class SchedulerFailure
+{
+public:
+    /**
+     * Type of failure
+     */
+    enum FailureType
+    {
+        NONE              = 0,
+        HOST_NULL         = 1,
+        HOST_REQUIREMENTS = 2,
+        HOST_CPU          = 3,
+        HOST_MEMORY       = 4,
+        HOST_NUMA         = 5,
+        HOST_PCI          = 6,
+        HOST_DISPATCH     = 7,
+        HOST_AFFINITY     = 8,
+        DS_NULL           = 9,
+        DS_CLUSTER        = 10,
+        DS_CAPACITY       = 11,
+        DS_NONE           = 12,
+        DS_MONITOR        = 13,
+        NET_NULL          = 14,
+        NET_CLUSTER       = 15,
+        NET_LEASES        = 16,
+        NET_ROLLBACK      = 17
+    };
+
+    /**
+     *  Return the string representation of a FailureType
+     *    @param ft the failure
+     *    @return the string
+     */
+    static std::string failure_to_string(FailureType ft);
+
+    /**
+     *  Return the string representation of a FailureType
+     *    @param str_type string representing the FailureType
+     *    @return the FailureType (defaults to NONE)
+     */
+    static FailureType str_to_failure_type(std::string& str_type);
+
+    /**
+     * Logs all the failures associated to a VM that has failed to be scheduled
+     *    @param host_failures map of failures per host
+     *    @return the log
+     */
+    static std::ostringstream log_failures(std::map<FailureType, std::set<int>> &host_failures);
+};
+
+#endif // SCHEDULER_FAILURE_H_

src/schedm_mad/remotes/rank/src/pool/HostXML.cc

@@ -84,7 +84,9 @@ void HostShareXML::init_attributes(ObjectXML * host)
 /* -------------------------------------------------------------------------- */
 /* -------------------------------------------------------------------------- */
 
-bool HostShareXML::test_capacity(HostShareCapacity &sr, string & error)
+bool HostShareXML::test_capacity(HostShareCapacity &sr,
+                                string & error,
+                                SchedulerFailure::FailureType & ft)
 {
     bool pci_fit  = pci.test(sr.pci);
     bool numa_fit = numa.test(sr);
@@ -102,18 +104,22 @@ bool HostShareXML::test_capacity(HostShareCapacity &sr, string & error)
 
     if (!cpu_fit)
     {
+        ft = SchedulerFailure::HOST_CPU;
         oss << "Not enough CPU capacity: " << sr.cpu << "/" << max_cpu  - cpu_usage;
     }
     else if (!mem_fit)
     {
+        ft = SchedulerFailure::HOST_MEMORY;
         oss << "Not enough memory: " << sr.mem << "/" << max_mem  - mem_usage;
     }
     else if (!numa_fit)
     {
+        ft = SchedulerFailure::HOST_NUMA;
         oss << "Cannot allocate NUMA topology";
     }
     else if (!pci_fit)
     {
+        ft = SchedulerFailure::HOST_PCI;
         oss <<  "Unavailable PCI device.";
     }
 

src/schedm_mad/remotes/rank/src/sched/SConstruct

@@ -21,7 +21,7 @@ import os
 
 lib_name='scheduler_sched'
 
-source_files=['Scheduler.cc' , 'SchedulerTemplate.cc']
+source_files=['Scheduler.cc', 'SchedulerFailure.cc', 'SchedulerTemplate.cc']
 
 # Build library
 sched_env.StaticLibrary(lib_name, source_files)