Error frames still sent to display, causing video loop on signal loss

[TheCryxh]

I noticed that when the video signal degrades, the display loops through old frames instead of just freezing on the last good one. This is pretty dangerous and annoying.

Looking at the code in src/main.cpp, I saw that __FRAME_THREAD__ already checks for errinfo and discard flags (lines 332-344) and logs them, but then still sends those bad frames to the display anyway at line 351:

MppBuffer buffer = mpp_frame_get_buffer(frame);
if (buffer) {

Changing that to:

if (buffer && !errinfo && !discard) {

fixes it.

[henkwiedig]

Does it make sense or does it work with only

if (buffer && !discard) {

I am thinking it might make sense to display "something" instead of nothing. As far as i understand it errinfo frames may contain usable data.

[TheCryxh]

You were right, I just tested it using only: if (buffer && !discard) {

Now it's better as it just shows pixelation when the signal gets weak.