Skip to content

Latest commit

ย 

History

History
49 lines (44 loc) ยท 1.58 KB

File metadata and controls

49 lines (44 loc) ยท 1.58 KB

๊ธฐ์—ฌํ•˜๊ธฐ

์–ด๋–ค Pull Request๋“  ํ™˜์˜ํ•ฉ๋‹ˆ๋‹ค. ๋‹น์‹ ์€ ์ด๋Ÿฌํ•œ ๋ฐฉ๋ฒ•์œผ๋กœ ํ”„๋กœ์ ํŠธ์— ์ฝ”๋”ฉ์„ ์‹œ์ž‘ํ• ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

  • ํ”„๋กœ์ ํŠธ๋ฅผ Forkํ•ฉ๋‹ˆ๋‹ค.
  • ๋‹น์‹ ์˜ Repositoty์— Cloneํ•ฉ๋‹ˆ๋‹ค.
  • npm install ์„ ์‹คํ–‰ํ•ฉ๋‹ˆ๋‹ค.
  • ๊ฐœ๋ฐœ ์›น์„œ๋ฒ„๋ฅผ ์„ค์น˜ํ•˜๊ธฐ ์œ„ํ•ด ๋ฉ”์ธ ํด๋”์—์„œ npm start๋ฅผ ์‹คํ–‰ํ•ฉ๋‹ˆ๋‹ค.
  • ๋ฆฌ๋“ฌ์„ ์ฆ๊ธฐ์„ธ์š”!

์ƒˆ๋กœ์šด ๋Œ„์Šค ์ถ”๊ฐ€ํ•˜๊ธฐ

2.2.x ๋ฒ„์ „์—์„œ ๋Œ„์Šค ์ถ”๊ฐ€๋Š” ์‰ฝ์Šต๋‹ˆ๋‹ค,

  • src\dances์— ์ƒˆ๋กœ์šด ํด๋”๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.
  • ์ด ํŒŒ์ผ์€ ๋‹น์‹ ์˜ ์ƒˆ๋กœ์šด ์ถค ํ•จ์ˆ˜๋ฅผ ๋ฐ˜๋“œ์‹œ exportํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
  • ์ด ํŒŒ์ผ์€ reset ํ•จ์ˆ˜๋ฅผ ๋ฐ˜๋“œ์‹œ exportํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

์—ฌ๊ธฐ์— jump.js์˜ ์˜ˆ์‹œ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

/* The function signature is :
 * @elem: ๋‹น์‹ ์ด ํšจ๊ณผ๋ฅผ ์ง€์ •ํ•  html ์š”์†Œ
 * @value: ํ˜„์žฌ pulse ๋น„์œจ (0๋ถ€ํ„ฐ 1๊นŒ์ง€ ์„ค์ •๊ฐ€๋Šฅ)
 * @options: ๋‹น์‹ ์ด ๋งˆ์ง€๋ง‰ ์ธ์ž๋กœ ์ค„ ์ˆ˜ ์žˆ๋Š” ์˜ต์…˜
 */
export default (elem, value, options = {}) => {
  const max = options.max || 30
  const min = options.min || 0
  const jump = (max - min) * value
  elem.style.transform = `translateY(${-jump}px)`
}

/* The reset function signature is :
 * @elem: The element to reset
 */
export const reset = elem => {
  elem.style.transform = ''
}
  • Import ํ•˜๊ณ  Dancer.jsํŒŒ์ผ์˜ ์ƒ์„ฑ์ž์— ๋“ฑ๋กํ•ฉ๋‹ˆ๋‹ค.
import jump, { reset as resetJump } from './dances/jump.js'
class Dancer {
  constructor() {
    this.registerDance('jump', jump, resetJump)
  }
}
  • Commit์„ ํ•˜๊ณ  PR๋ฅผ ๋งŒ๋“œ์„ธ์š”. ๊ทธ๋ฆฌ๊ณ  ๋ชจ๋‘๊ฐ€ ๋‹น์‹ ์˜ ๊ธฐ์—ฌ๋ฅผ ์ฆ๊ธฐ๋Š” ๊ฒƒ์„ ๋ณด์„ธ์š”! :)