2.9 BUG : Can't locate Time/HiRes.pm in @INC

[Krysztophe]

A dependency was added in 2.9, and this library may be missing

Can't locate Time/HiRes.pm in @INC (you may need to install the Time::HiRes module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./check_pgactivity line 52.
BEGIN failed--compilation aborted at ./check_pgactivity line 52.

• on Debian, it is part of libperl5.40 and this a dependency of PG packages anyway
• on RH8 : sudo dnf install perl-Time-HiRes.x86_64

[Krysztophe]

Shall we accept and document this dependency, or is a small patch possible ?

[gleu]

@blogh Do you think we could get rid of the dependency? Thanks.

[blogh]

I dont know It was introduced here and is used in other places (eg: temp file)

https://github.com/OPMDG/check_pgactivity/pull/390/changes

[gleu]

I guess it would be better to just document this change. I can work on a patch for this.

[gleu]

PR #424 adds the two dependencies to the spec file. I don't see any dependencies on the README file, so why add one now?

[ioguix]

I dont know It was introduced here and is used in other places (eg: temp file)

https://github.com/OPMDG/check_pgactivity/pull/390/changes

This has been reverted in a01279f.

It seems the Time::HiRes dependency is hold from another commit from you in january: d401880

Do you think we really need to use gettimeofday in this patch, or a simple time like in other places would be just fine?

use Time::HiRes qw(gettimeofday tv_interval);

As tv_interval is not used in current code, we could remove the Time::HiRes dependency if we remove this only use of gettimeofday.

[gleu]

I tried it, and "perl t/01-settings.t" worked ok.