Skip to content

Commit ec1eaaf

Browse files
committed
TEMP(ci:windows-tools): exercise tool-disable on PR — REVERT BEFORE MERGE
Mirrors the TEMP pattern from #360 but scoped to `build-llvm/action.yml` only (this branch doesn't touch solc): 1. `if: false` on the LLVM artifact cache restore → forces Build LLVM to always run, so the Windows tool-disable change is actually exercised. Without this, the args-hash in the cache key only triggers miss on the first push (when no entry exists); subsequent pushes to this branch would hit the entry we just saved and skip the build, masking any regression. 2. `save: true` on the ccache-action → populates ccache in this branch's cache scope even on PR events, so a follow-up push can observe warm-ccache + tool-disable together (the actual target configuration). Revert both before merge. The end-state behaviour (artifact cache restore works, ccache saves only on non-PR events) is what ships.
1 parent 010b23b commit ec1eaaf

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/actions/build-llvm/action.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,11 @@ runs:
110110
KEY="${KEY}-args${{ steps.build-config.outputs.args-hash }}-${SHA}"
111111
echo "key=${KEY}" | tee -a "${GITHUB_OUTPUT}"
112112
113+
# TEMP(ci:windows-tools): forced-miss so Build LLVM always runs and the
114+
# Windows tool-disable change is actually exercised. REVERT BEFORE MERGE.
113115
- name: Restore LLVM artifact cache
114116
id: llvm-artifact-cache
117+
if: false
115118
uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
116119
with:
117120
path: ${{ inputs.working-dir != '.' && format('{0}/target-llvm/target-final', inputs.working-dir) || 'target-llvm/target-final' }}
@@ -178,7 +181,7 @@ runs:
178181
append-timestamp: true
179182
max-size: "10G"
180183
verbose: 2
181-
save: ${{ github.event_name != 'pull_request' }}
184+
save: true # TEMP(ci:windows-tools): populate ccache on PR events so a follow-up push to this branch can measure warm-ccache + tool-disable. REVERT BEFORE MERGE to `${{ github.event_name != 'pull_request' }}`.
182185

183186
- name: Build LLVM
184187
if: steps.llvm-artifact-cache.outputs.cache-hit != 'true'

0 commit comments

Comments
 (0)