Skip to content

Commit 90df14b

Browse files
committed
Revert "ci(cache): disable LLVM tools on Windows to cut link-bound wall-clock"
This reverts commit 3106d1e.
1 parent 97e864f commit 90df14b

1 file changed

Lines changed: 1 addition & 20 deletions

File tree

.github/actions/build-llvm/action.yml

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -173,28 +173,9 @@ runs:
173173
LINK_JOBS=1
174174
fi
175175
176-
# Windows disables LLVM's own tool binaries (opt, llc, llvm-objdump, ...)
177-
# because `lld-link` is slow per-executable and those ~200 tool links
178-
# dominate Windows wall-clock even at 100% ccache hits on compiles. solx
179-
# consumes LLVM via inkwell FFI and never invokes a tool from
180-
# target-llvm/target-final/bin/; distro/Xcode packages provide
181-
# llvm-cov / llvm-symbolizer / etc. Scoped Windows-only so non-Windows
182-
# runs stay identical pending independent validation on those platforms.
183-
EXTRA_ARGS=(
184-
"-DCMAKE_EXPORT_COMPILE_COMMANDS='Off'"
185-
"-DLLVM_PARALLEL_LINK_JOBS='${LINK_JOBS}'"
186-
"-DLLVM_OPTIMIZED_TABLEGEN='On'"
187-
)
188-
if [ "${{ runner.os }}" = "Windows" ]; then
189-
EXTRA_ARGS+=(
190-
"-DLLVM_BUILD_TOOLS='Off'"
191-
"-DLLVM_INCLUDE_TOOLS='Off'"
192-
)
193-
fi
194-
195176
./target/release/solx-dev llvm build --build-type ${{ inputs.build-type }} \
196177
--ccache-variant=ccache ${ENABLE_TESTS} ${ENABLE_VALGRIND} ${VALGRIND_OPTIONS} ${ENABLE_ASSERTIONS} ${ENABLE_COVERAGE} ${ENABLE_MLIR} ${SANITIZER} \
197-
--extra-args "${EXTRA_ARGS[@]}"
178+
--extra-args "-DCMAKE_EXPORT_COMPILE_COMMANDS='Off'" "-DLLVM_PARALLEL_LINK_JOBS='${LINK_JOBS}'" "-DLLVM_OPTIMIZED_TABLEGEN='On'"
198179
199180
# `continue-on-error` keeps a failing ccache install (→ ccache not on PATH)
200181
# from masking the real Build LLVM failure in the step summary.

0 commit comments

Comments
 (0)