Merge pull request #8168 from NomicFoundation/plugin-from-resolution

Add `from` config tests and rename gas-config tests to network-config

Author: schaable

packages/hardhat-ethers/src/internal/signers/signers.ts

@@ -252,7 +252,10 @@ export class HardhatEthersSigner implements HardhatEthersSignerI {
 
     const promises: Array<Promise<void>> = [];
 
-    // Make sure the from matches the sender
+    // Mirror stock ethers: ENS-resolve `from` and assert it matches the
+    // signer. Hardhat can be pointed at mainnet/testnets via --network, where
+    // ENS works and users expect ethers-compatible `from` handling. Don't
+    // "simplify" this by letting the node handle the mismatch.
     if (resolvedTx.from !== null && resolvedTx.from !== undefined) {
       const _from = resolvedTx.from;
       promises.push(

…ckages/hardhat-ethers/test/gas-config.ts …es/hardhat-ethers/test/network-config.tspackages/hardhat-ethers/test/gas-config.ts renamed to packages/hardhat-ethers/test/network-config.ts packages/hardhat-ethers/test/gas-config.ts renamed to packages/hardhat-ethers/test/network-config.ts

@@ -16,9 +16,9 @@ interface InitResult {
   networkConfig: NetworkConfig;
 }
 
-describe("gas config behavior", () => {
+describe("network config behavior", () => {
   describe("in-process hardhat network", () => {
-    defineGasConfigTests(() => initializeTestEthers(ARTIFACTS));
+    defineNetworkConfigTests(() => initializeTestEthers(ARTIFACTS));
   });
 
   describe("local http node", () => {
@@ -34,7 +34,7 @@ describe("gas config behavior", () => {
       await server.close();
     });
 
-    defineGasConfigTests(() =>
+    defineNetworkConfigTests(() =>
       initializeTestEthers(ARTIFACTS, {
         networks: {
           localhost: { type: "http", url: `http://${address}:${port}` },
@@ -44,7 +44,7 @@ describe("gas config behavior", () => {
   });
 });
 
-function defineGasConfigTests(initEthers: () => Promise<InitResult>) {
+function defineNetworkConfigTests(initEthers: () => Promise<InitResult>) {
   describe("gas: auto (default)", () => {
     let ethers: HardhatEthers;
 
@@ -254,6 +254,48 @@ function defineGasConfigTests(initEthers: () => Promise<InitResult>) {
     });
   });
 
+  describe("from config", () => {
+    let ethers: HardhatEthers;
+
+    before(async () => {
+      ({ ethers } = await initEthers());
+    });
+
+    it("default signer sends from its own address", async () => {
+      const [firstSigner, secondSigner] = await ethers.getSigners();
+      const tx = await firstSigner.sendTransaction({ to: secondSigner });
+      assert.equal(tx.from, firstSigner.address);
+    });
+
+    it("non-first signer sends from its own address", async () => {
+      const [firstSigner, secondSigner] = await ethers.getSigners();
+      const tx = await secondSigner.sendTransaction({ to: firstSigner });
+      assert.equal(tx.from, secondSigner.address);
+    });
+
+    it("respects explicit from matching the signer", async () => {
+      const [firstSigner, secondSigner] = await ethers.getSigners();
+      const tx = await firstSigner.sendTransaction({
+        to: secondSigner,
+        from: firstSigner.address,
+      });
+      assert.equal(tx.from, firstSigner.address);
+    });
+
+    it("throws when explicit from doesn't match the signer", async () => {
+      const [firstSigner, secondSigner] = await ethers.getSigners();
+
+      // eslint-disable-next-line no-restricted-syntax -- it tests a non Hardhat error
+      await assert.rejects(
+        firstSigner.sendTransaction({
+          to: firstSigner,
+          from: secondSigner.address,
+        }),
+        /from address mismatch/,
+      );
+    });
+  });
+
   describe("non-interference with explicit gas-related calls", () => {
     let ethers: HardhatEthers;
     let provider: EthereumProvider;

packages/hardhat-viem/test/gas-config.ts …ages/hardhat-viem/test/network-config.tspackages/hardhat-viem/test/gas-config.ts renamed to packages/hardhat-viem/test/network-config.ts packages/hardhat-viem/test/gas-config.ts renamed to packages/hardhat-viem/test/network-config.ts

@@ -19,7 +19,7 @@ interface InitResult {
   networkConfig: NetworkConfig;
 }
 
-describe("gas config behavior", () => {
+describe("network config behavior", () => {
   useEphemeralFixtureProject("default-ts-project");
 
   let hre: HardhatRuntimeEnvironment;
@@ -35,7 +35,7 @@ describe("gas config behavior", () => {
   });
 
   describe("in-process hardhat network", () => {
-    defineGasConfigTests(async () => {
+    defineNetworkConfigTests(async () => {
       const conn = await hre.network.create();
       return {
         viem: conn.viem,
@@ -59,7 +59,7 @@ describe("gas config behavior", () => {
       await server.close();
     });
 
-    defineGasConfigTests(async () => {
+    defineNetworkConfigTests(async () => {
       const conn = await hre.network.create({
         network: "localhost",
         override: { url: `http://${address}:${port}` },
@@ -73,7 +73,7 @@ describe("gas config behavior", () => {
   });
 });
 
-function defineGasConfigTests(initViem: () => Promise<InitResult>) {
+function defineNetworkConfigTests(initViem: () => Promise<InitResult>) {
   describe("gas: auto (default)", () => {
     let viem: HardhatViemHelpers;
 
@@ -367,6 +367,42 @@ function defineGasConfigTests(initViem: () => Promise<InitResult>) {
     });
   });
 
+  describe("from config", () => {
+    let viem: HardhatViemHelpers;
+
+    before(async () => {
+      ({ viem } = await initViem());
+    });
+
+    it("default wallet client sends from its own address", async () => {
+      const publicClient = await viem.getPublicClient();
+      const [firstClient, secondClient] = await viem.getWalletClients();
+      const hash = await firstClient.sendTransaction({
+        to: secondClient.account.address,
+        value: 0n,
+      });
+      const tx = await publicClient.getTransaction({ hash });
+      assert.equal(
+        tx.from.toLowerCase(),
+        firstClient.account.address.toLowerCase(),
+      );
+    });
+
+    it("non-first wallet client sends from its own address", async () => {
+      const publicClient = await viem.getPublicClient();
+      const [firstClient, secondClient] = await viem.getWalletClients();
+      const hash = await secondClient.sendTransaction({
+        to: firstClient.account.address,
+        value: 0n,
+      });
+      const tx = await publicClient.getTransaction({ hash });
+      assert.equal(
+        tx.from.toLowerCase(),
+        secondClient.account.address.toLowerCase(),
+      );
+    });
+  });
+
   describe("non-interference with RPC calls", () => {
     let viem: HardhatViemHelpers;
     let provider: EthereumProvider;