Write out StrongPresenter

This gem was originally written by Ronald (one of the original authors
of this repo) but now looks to be abandoned and definitely doesn't
support Rails >= 5.0.

We only had one major usage, which I just replaced by generating the
table manually, which IMO is more readable anyway.

Author: bagedevimo

Gemfile

@@ -25,7 +25,6 @@ gem "whenever", require: false # for cron jobs
 gem "tilt"
 gem "simple-navigation", "3.11.0"
 gem "simple_form", "3.2.1"
-gem "strong_presenter", "~> 0.2.2"
 gem "render_anywhere"
 gem "pygments.rb", "~> 2.0"
 gem "ranked-model", "< 0.4.3" # pinned because 0.4.3-0.4.4 are broken (see https://github.com/brendon/ranked-model/issues/139; we also need the fix in https://github.com/brendon/ranked-model/pull/152); we can't update to 0.4.5 yet because it requires activerecord >= 4.2

Gemfile.lock

@@ -51,8 +51,8 @@ GEM
       minitest (~> 5.1)
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.8.1)
-      public_suffix (>= 2.0.2, < 6.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
     afm (0.2.2)
     arel (6.0.4)
     ast (2.4.3)
@@ -71,15 +71,15 @@ GEM
       debug_inspector (>= 0.0.1)
     builder (3.2.4)
     byebug (9.1.0)
-    capybara (2.17.0)
+    capybara (3.9.0)
       addressable
       mini_mime (>= 0.1.3)
-      nokogiri (>= 1.3.3)
-      rack (>= 1.0.0)
-      rack-test (>= 0.5.4)
-      xpath (>= 2.0, < 4.0)
-    capybara-email (2.5.0)
-      capybara (~> 2.4)
+      nokogiri (~> 1.8)
+      rack (>= 1.6.0)
+      rack-test (>= 0.6.3)
+      xpath (~> 3.1)
+    capybara-email (3.0.2)
+      capybara (>= 2.4, < 4.0)
       mail
     carrierwave (1.3.2)
       activemodel (>= 4.0.0)
@@ -275,7 +275,6 @@ GEM
     regexp_parser (2.10.0)
     render_anywhere (0.0.12)
       rails (>= 3.0.7)
-    request_store (1.0.8)
     responders (2.4.1)
       actionpack (>= 4.2.0, < 6.0)
       railties (>= 4.2.0, < 6.0)
@@ -366,14 +365,6 @@ GEM
       rubocop (= 1.12.1)
       rubocop-performance (= 1.10.1)
     statsd-ruby (1.5.0)
-    strong_attributes (0.0.2)
-      activesupport (>= 3.0)
-    strong_presenter (0.2.2)
-      actionpack (>= 3.0)
-      activemodel (>= 3.0)
-      activesupport (>= 3.0)
-      request_store (~> 1.0.3)
-      strong_attributes (~> 0.0.2)
     superfish-rails (1.6.0.1)
     test_after_commit (1.2.2)
       activerecord (>= 3.2, < 5.0)
@@ -406,8 +397,8 @@ GEM
     world-flags (0.6.5)
       hashie (>= 1.2)
       i18n (>= 0.6)
-    xpath (2.1.0)
-      nokogiri (~> 1.3)
+    xpath (3.2.0)
+      nokogiri (~> 1.8)
     yui-compressor (0.12.0)
 
 PLATFORMS
@@ -463,7 +454,6 @@ DEPENDENCIES
   sinatra
   spring
   standard
-  strong_presenter (~> 0.2.2)
   superfish-rails (~> 1.6.0)
   test_after_commit (~> 1.2)
   tilt

app/controllers/problems_controller.rb

@@ -14,14 +14,6 @@ def submit_params
     params.require(:submission).permit(*submit_attributes).merge(user_id: current_user.id, problem_id: params[:id])
   end
 
-  def visible_attributes
-    visible_attributes = [:linked_name, :input, :output, :memory_limit, :time_limit, :linked_owner, :progress_bar]
-    visible_attributes << :edit_link if policy(@problem).update?
-    visible_attributes << :destroy_link if policy(@problem).destroy?
-    visible_attributes << :test_status if policy(@problem).inspect?
-    visible_attributes
-  end
-
   def index
     raise Pundit::NotAuthorizedError if current_user.nil?
     case params[:filter].to_s
@@ -34,8 +26,6 @@ def index
     end
     @problems = @problems.order(id: :desc)
     authorize @problem, :update?
-
-    @problems_presenter = ProblemPresenter::Collection.new(@problems).permit!(*visible_attributes)
   end
 
   def show

app/helpers/problems_helper.rb

@@ -40,4 +40,18 @@ def markdown_parse(str, relative_root: request.path + "/")
     end
     content.to_s.html_safe
   end
+
+  def test_status(problem)
+    colour = case problem.test_status
+             when -1 then "#FF0000"
+             when -2 then "#FF8000"
+             when 0 then "#808080"
+             when 1 then "#FFFF00"
+             when 2 then "#80FF00"
+             when 3 then "#00C000"
+             else; "#808080"
+    end
+
+    content_tag :div, " ", style: "border-radius: 50%; width: 15px; height: 15px; background-color: #{colour}; display: inline-block"
+  end
 end

app/presenters/application_presenter.rb

@@ -72,7 +72,7 @@
               </td>
               <td>
                 <% if !imported_problem.nil? %>
-                  <%= ProblemPresenter.new(imported_problem).test_status  %>
+                  <%= test_status(imported_problem)  %>
                   <%= link_to imported_problem.try(:name), problem_path(problem[:problem_id]) %>
                   (<%= imported_problem.problem_set_associations.detect{|psa| psa.problem_set_id == issue[:problem_set_id].to_i}.try(:weighting) %>)
                   <%= imported_problem.memory_limit || '?' %> MB, <%= imported_problem.time_limit || '?' %> s

app/presenters/problem_presenter.rb

@@ -27,7 +27,16 @@
         <tbody>
           <% problems.each do |problem| %>
             <tr>
-              <td width="100%">&nbsp;&nbsp;&nbsp;<%= ProblemPresenter.new(problem).test_status + "&nbsp;".html_safe if policy(problem).inspect? %><%= link_to problem.name, problem %></td>
+              <td width="100%">&nbsp;&nbsp;&nbsp;
+
+                <% if policy(problem).inspect? %>
+                  <%= test_status(problem) %>
+                  &nbsp;
+                <% end %>
+
+                <%= link_to problem.name, problem %>
+              </td>
+
               <td>
                 <%= weighted ? progress_bar(problem.weighted_score, problem.weighting) : progress_bar(problem.weighted_score) %>
               </td>

app/views/importers/problem_series/index.html.erb

@@ -1,34 +1,49 @@
 <% content_for :title, "Problems" %>
 <% toolbox_push :new, new_problem_path if policy(Problem).create? %>
 
-<% columns = {:test_status => "",
-              :linked_name => "Name",
-              :input => "Input",
-              :output => "Output",
-              :memory_limit => "Memory Limt",
-              :time_limit => "Time Limit",
-              :linked_owner => "Owner",
-              :progress_bar => "Progress",
-              :edit_link => "",
-              :destroy_link => ""} %>
 <table class="main_table">
   <thead>
     <tr>
-      <% @problems_presenter.select_permitted(*columns.keys).each do |key| %>
-        <th><%= columns[key] %></th>
-      <% end %>
+      <% if policy(Problem.new).inspect? %><th></th><% end %>
+      <th>Name</th>
+      <th>Input</th>
+      <th>Output</th>
+      <th>Memory limit</th>
+      <th>Time limit</th>
+      <th>Owner</th>
+      <th>Progress</th>
+      <% if policy(Problem.new).update? %><th></th><% end %>
+      <% if policy(Problem.new).destroy? %><th></th><% end %>
     </tr>
   </thead>
+
   <tbody>
-<% @problems_presenter.each do |problem_presenter| %>
-  <tr>
-    <% problem_presenter.presents(*columns.keys).each do |value| %>
-      <%= content_tag :td, value %>
+    <% @problems.each do |problem| %>
+      <tr>
+        <% if policy(problem).inspect? %>
+          <td><%= test_status(problem) %></td>
+        <% end %>
+
+        <td><%= link_to(problem.name, problem) %></td>
+        <td><%= problem.input || "stdin" %></td>
+        <td><%= problem.output || "stdout" %></td>
+        <td><%= problem.memory_limit %> MB</td>
+        <td><%= problem.time_limit %> s</td>
+        <td><%= link_to(problem.owner.username, problem.owner) if problem.owner.present? %></td>
+        <td><%= progress_bar(problem.score) if problem.score %></td>
+
+        <% if policy(problem).update? %>
+          <td><%= link_to("Edit", problem_path(problem)) %></td>
+        <% end %>
+
+        <% if policy(problem).destroy? %>
+          <td>
+            <%= link_to("Destroy", problem_path(problem), method: :delete, data: { confirm: "Are you sure?" }) %>
+          </td>
+        <% end %>
+      </tr>
     <% end %>
-  </tr>
-<% end %>
   </tbody>
 </table>
 
 <br />
-

app/views/problem_sets/_item.html.erb

@@ -11,7 +11,7 @@
 
     headers = find(".main_table > thead > tr").all("th").map(&:text)
     rows = find(".main_table > tbody").all("tr").map { |r| r.all("td").map(&:text) }
-    expect(headers).to eq(["", "Name", "Input", "Output", "Memory Limt", "Time Limit", "Owner", "Progress", "", ""])
+    expect(headers).to eq(["", "Name", "Input", "Output", "Memory limit", "Time limit", "Owner", "Progress", "", ""])
     expect(rows.length).to eq(Problem.count)
 
     expect(rows[0]).to eq(["", problem.name, problem.input, problem.output, "1 MB", "1.0 s", "System", "", "Edit", "Destroy"])