Skip to content

Replace taplo-pre-commit with check-toml (taplo has no Linux aarch64 wheels) #8345

@bdice

Description

@bdice

Problem

taplo-pre-commit (v0.9.3) does not ship pre-built wheels for Linux aarch64. When pre-commit run -a is invoked on an aarch64 host, the hook falls back to building from source — automatically downloading and installing a Rust toolchain via puccinialin — then fails because the source tarball is missing crates/taplo-lsp/Cargo.toml:

Computed rustc target triple: aarch64-unknown-linux-gnu
Rust not found, installing into a temporary directory
...
error: failed to load manifest for workspace member `.../crates/taplo-cli`
  Caused by: failed to read `.../crates/taplo-lsp/Cargo.toml`
  Caused by: No such file or directory (os error 2)

This means contributors on Linux aarch64 cannot run pre-commit at all.

Proposal

Remove the taplo-pre-commit hook entry from .pre-commit-config.yaml and rely on the existing check-toml hook (from pre-commit-hooks, already configured on line 22) for TOML syntax validation. check-toml is a pure-Python hook that works on every platform without a Rust toolchain.

check-toml validates TOML syntax but does not format. If TOML formatting enforcement is desired in the future, it could be added as a separate CI step using a pinned taplo binary that supports aarch64, rather than through a pre-commit hook that requires compilation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions