Added numeric_limits for matx types#1149
Conversation
|
/build |
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge; all previously-flagged P1 issues are resolved and only a minor convention suggestion remains. All concerns from the prior review thread (missing has_denorm/has_denorm_loss fields, incorrect fltflt denorm_min invariant) have been addressed. The only remaining finding is a P2 style suggestion about setting both NaN components in fltflt::quiet_NaN/signaling_NaN. No P0 or P1 issues remain. include/matx/kernels/fltflt.h — minor NaN-initialization convention issue on lines 748-749. Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class `numeric_limits~matxFp16~` {
+_Base = numeric_limits~__half~
+bool is_specialized
+float_denorm_style has_denorm
+bool has_denorm_loss
+min() matxFp16
+max() matxFp16
+epsilon() matxFp16
+denorm_min() matxFp16
}
class `numeric_limits~matxBf16~` {
+_Base = numeric_limits~__nv_bfloat16~
+bool is_specialized
+float_denorm_style has_denorm
+bool has_denorm_loss
+min() matxBf16
+max() matxBf16
+epsilon() matxBf16
+denorm_min() matxBf16
}
class `numeric_limits~matxFp16Complex~` {
+_ScalarLimits = numeric_limits~matxFp16~
+bool is_specialized
+min() matxFp16Complex
+signaling_NaN() matxFp16Complex
}
class `numeric_limits~matxBf16Complex~` {
+_ScalarLimits = numeric_limits~matxBf16~
+bool is_specialized
+min() matxBf16Complex
+signaling_NaN() matxBf16Complex
}
class `numeric_limits~fltflt~` {
+bool is_specialized
+int digits = 48
+float_denorm_style has_denorm = denorm_present
+min() fltflt
+max() fltflt
+epsilon() fltflt
+denorm_min() fltflt
}
`numeric_limits~matxFp16~` --> `numeric_limits~matxFp16Complex~` : delegated by
`numeric_limits~matxBf16~` --> `numeric_limits~matxBf16Complex~` : delegated by
Reviews (5): Last reviewed commit: "Fix signaling_NaN per code review" | Re-trigger Greptile |
|
/build |
No description provided.