From 8b0e41c7b5f8c2fce2d3c305a80f7d82033608fd Mon Sep 17 00:00:00 2001
From: Simon Hsiao <simon.hsiao@noaa.gov>
Date: Tue, 5 May 2026 17:14:36 +0000
Subject: [PATCH 1/2] git training - adding ush/item_31.sh

---
 ush/item_31.sh | 142 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 142 insertions(+)
 create mode 100755 ush/item_31.sh

diff --git a/ush/item_31.sh b/ush/item_31.sh
new file mode 100755
index 0000000..249e426
--- /dev/null
+++ b/ush/item_31.sh
@@ -0,0 +1,142 @@
+#!/usr/bin/env bash
+
+#####
+# Purpose:
+# This script checks if " Have all modules been loaded in ecf scripts and nowhere else? "
+# item #31 in the EE2 Checklist
+#
+# Usage:
+# $ sh item_31.sh /path/to/package
+#
+# Written by: Simon Hsiao 2026/05/05
+#####
+
+# Temporary file to store the current list of loaded modules
+tmpfile=$(mktemp)
+
+# Save the currently loaded modules
+module list > "$tmpfile" 2>&1
+
+# Function to extract module names from the saved list
+extract_loaded_modules() {
+    grep -oP '^\s*\d+\)\s*\K[^ ]+' "$tmpfile" | grep -v '(H)'
+}
+
+# Reset all modules to start with a clean environment
+#module reset
+#module load intel
+
+# Ensure that the package directory is provided as an argument
+if [ $# -lt 1 ]; then
+    echo "Usage: $0 /path/to/package"
+    exit 1
+fi
+
+package_dir=$1
+build_ver_file="$package_dir/versions/build.ver"
+run_ver_file="$package_dir/versions/run.ver"
+
+# Check if the build.ver file exists
+if [ ! -f "$run_ver_file" ]; then
+    echo "Error: $run_ver_file not found."
+    exit 1
+fi
+
+# Function to extract versions from the build.ver file
+extract_versions() {
+    local ver_file=$1
+    
+    # Extract lines with 'export', remove 'export', split by '=', and format
+    grep '^export ' "$ver_file" | while IFS="=" read -r var_name version; do
+        software=$(echo "$var_name" | sed 's/^export //; s/_ver$//')  # Remove 'export ' and '_ver'
+	version=$(echo "$version" | sed 's/^"//; s/"$//')  # Strip surrounding quotes from version
+        echo "$software:$version"
+    done
+}
+
+# Function to strip non-numeric characters from version strings
+strip_non_numeric() {
+    echo "$1" | sed 's/[^0-9.]//g'
+}
+
+# Function to get the latest version from lmod (using module spider)
+get_latest_version() {
+    local software=$1
+
+    # Replace underscores with hyphens for module names only if it is PrgEnv
+    if [[ $software == PrgEnv* || $software == cray* ]]; then
+        module_name=$(echo "$software" | sed 's/_/-/g')
+    else
+        module_name="$software"
+    fi
+    # Use module spider to get available versions for the given software
+    spider_output=$(module spider $module_name 2>&1)
+
+    # Check if module spider returned valid data
+    if [[ $spider_output == *"No module matches"* ]]; then
+        return
+    fi
+
+    # Try to extract the version from the output
+    latest_version=$(echo "$spider_output" | grep -Eo "$module_name/[0-9.]+" | sort -V | tail -1 | awk -F'/' '{print $2}')
+    
+    # Return the latest version
+    echo "$latest_version"
+}
+
+# Function to compare the installed version with the latest available version
+compare_versions() {
+    local software=$1
+    local current_version=$2
+
+    # Get the latest version
+    latest_version=$(get_latest_version "$software")
+    
+    if [ -z "$latest_version" ]; then
+        printf "Error, missed    %-15s : No version information availabl in lmod \n" $software
+        return
+    fi
+
+    # Strip non-numeric characters from versions
+    stripped_current_version=$(strip_non_numeric "$current_version")
+    stripped_latest_version=$(strip_non_numeric "$latest_version")
+
+    if [[ "$stripped_current_version" == "$stripped_latest_version" ]]; then
+        printf "Up to date       %-15s : $current_version \n" $software
+    else
+        printf "Error, Outdated  %-15s : current=$stripped_current_version vs latest=$stripped_latest_version \n" $software
+    fi
+}
+
+# Main script logic to extract and compare versions
+echo "Extracting versions from $run_ver_file..."
+echo "==========================================="
+extract_versions "$run_ver_file"
+echo
+echo "Checking module load in the $package_dir ... "
+echo "==========================================="
+cd $package_dir
+pwd
+echo "checking jobs/ ..."
+grep -l -e "module load " jobs/* jobs/*/* 2>/dev/null
+echo "checking scripts/ ..."
+grep -l -e "module load " scripts/*sh scripts/*/*sh  scripts/*/*/*sh 2>/dev/null
+echo "checking ush/ ..."
+grep -l -e "module load " ush/* ush/*/* ush/*/*/* ush/*/*/*/*  2>/dev/null
+
+
+#extract_versions "$run_ver_file" | while IFS=":" read -r software version; do 
+#    compare_versions "$software" "$version"
+#done
+
+# Restore the previously loaded modules
+echo "==========================================="
+#echo "Restoring original modules..."
+#for mod in $(extract_loaded_modules); do
+#    module load "$mod"
+#done
+
+# Cleanup temporary file
+rm -f "$tmpfile"
+
+echo "$0 Script completed."

From 3559f4b7d1fdfa06287cbb0c77d144a203715d15 Mon Sep 17 00:00:00 2001
From: "Xiaoxue.Wang" <Xiaoxue.Wang@noaa.gov>
Date: Tue, 5 May 2026 18:58:38 +0000
Subject: [PATCH 2/2] add item_32 by Xiaoxue

---
 ush/item_32.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 ush/item_32.sh

diff --git a/ush/item_32.sh b/ush/item_32.sh
new file mode 100644
index 0000000..bab1518
--- /dev/null
+++ b/ush/item_32.sh
@@ -0,0 +1,16 @@
+#!/bin/bash
+set -x
+
+target_add=$1
+
+for dir in jobs scripts ush versions
+do
+  for file in `find ${target_add}/$dir`
+  do
+    grep "export .*_ver=" $file
+    err=$?
+    if [ $err -eq 0 -a $dir != versions ]; then
+      echo "ERROR: version number in ${target_add}/$dir/$file!"
+    fi
+  done
+done