Merge pull request #42 from MozillaSecurity/skip-reports-without-category

Skip importing reports without a breakage_category set

Author: denschub

server/frontend/src/components/Buckets/ReportPreviewRow.vue

@@ -11,7 +11,7 @@
     </td>
     <td class="wrap-normal comments-col">
       <div>
-        <strong>{{ report.breakage_category }}</strong
+        <strong>{{ report.breakage_category ?? "unknown" }}</strong
         >: {{ maybeTranslatedComments(report) }}
       </div>
     </td>

server/reportmanager/management/commands/import_reports_from_bigquery.py

@@ -33,12 +33,19 @@ def handle(self, *args, **options):
             )
 
         client = bigquery.Client(**params)
+
+        # For importing, we ignore reports that have no URL or no comment. In
+        # theory, a NULL URL shouldn't even be possible, but we have a few
+        # reports like that. Reports without a comment are very unlikely to be
+        # actionable.
         result = client.query_and_wait(
             f"""SELECT r.*, t.language_code, t.translated_text
                 FROM `{settings.BIGQUERY_TABLE}` as r
                 LEFT JOIN `{settings.BIGQUERY_TRANSLATIONS_TABLE}` t
                     ON r.uuid = t.report_uuid
-                WHERE r.reported_at >= @since;""",
+                WHERE r.url IS NOT NULL
+                    AND r.comments IS NOT NULL
+                    AND r.reported_at >= @since;""",
             job_config=bigquery.QueryJobConfig(
                 query_parameters=[
                     bigquery.ScalarQueryParameter("since", "DATETIME", options["since"])
@@ -47,8 +54,6 @@ def handle(self, *args, **options):
         )
 
         for row in result:
-            if row.comments is None:
-                continue
             report_obj = Report(
                 app_name=row.app_name,
                 app_channel=row.app_channel,

server/reportmanager/serializers.py

@@ -185,7 +185,9 @@ class ReportEntrySerializer(serializers.ModelSerializer):
     app_name = serializers.CharField(source="app.name")
     app_channel = serializers.CharField(source="app.channel")
     app_version = serializers.CharField(source="app.version")
-    breakage_category = serializers.CharField(source="breakage_category.value")
+    breakage_category = serializers.CharField(
+        source="breakage_category.value", allow_null=True
+    )
     os = serializers.CharField(source="os.name", max_length=63)
 
     class Meta: