refactor: use addAndTrack consistently for all load process registration

Use addAndTrack() in initHost() and initClient() as well, not just the
post-context-switch steps. This makes maxProgress tracking consistent
across all phases and removes the now-redundant loop in init() that
was double-counting.

BSA review feedback on PR #5313.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: Cervator

engine/src/main/java/org/terasology/engine/core/modes/StateLoading.java

@@ -145,10 +145,6 @@ public void init(GameEngine engine) {
         }
 
         progress = 0;
-        maxProgress = 0;
-        for (LoadProcess process : loadProcesses) {
-            maxProgress += process.getExpectedCost();
-        }
 
         popStep();
         if (nuiManager != null) {
@@ -159,54 +155,54 @@ public void init(GameEngine engine) {
     }
 
     private void initClient(GameEngine engine, ServiceRegistry serviceRegistry) {
-        loadProcesses.add(new JoinServer(context, gameManifest, joinStatus));
+        addAndTrack(new JoinServer(context, gameManifest, joinStatus));
         if (!headless) {
-            loadProcesses.add(new InitialiseRendering(serviceRegistry));
+            addAndTrack(new InitialiseRendering(serviceRegistry));
         }
-        loadProcesses.add(new InitialiseEntitySystem(context, serviceRegistry));
-        loadProcesses.add(new RegisterBlocks(context, serviceRegistry));
+        addAndTrack(new InitialiseEntitySystem(context, serviceRegistry));
+        addAndTrack(new RegisterBlocks(context, serviceRegistry));
         if (!headless) {
-            loadProcesses.add(new InitialiseGraphics(context));
+            addAndTrack(new InitialiseGraphics(context));
         }
-//        loadProcesses.add(new LoadPrefabs(context));
-//        loadProcesses.add(new ProcessBlockPrefabs(context));
-        loadProcesses.add(new LoadExtraBlockData(serviceRegistry));
-        loadProcesses.add(new InitialiseComponentSystemManager(serviceRegistry));
-//        loadProcesses.add(new RegisterSystems(context, netMode));
-//        loadProcesses.add(new RegisterWorldSystems(gameManifest, context));
-        loadProcesses.add(new InitialiseCommandSystem(serviceRegistry));
-        loadProcesses.add(new InitialiseRemoteWorld(context, serviceRegistry, gameManifest));
-        loadProcesses.add(new InitialisePhysics(context, serviceRegistry));
-//        loadProcesses.add(new InitialiseSystems(context));
-//        loadProcesses.add(new PreBeginSystems(context));
-//        loadProcesses.add(new CreateRemoteWorldEntity(context));
-//        loadProcesses.add(new PostBeginSystems(context));
-//        loadProcesses.add(new SetupRemotePlayer(context));
-//        loadProcesses.add(new AwaitCharacterSpawn(context));
-//        loadProcesses.add(new RegisterBlockFamilies(context));
-//        loadProcesses.add(new PrepareWorld(context));
-        loadProcesses.add(new SwitchToContextStep(engine));
-        loadProcesses.add(new AddClientPostLoadProcessesStep());
+//        addAndTrack(new LoadPrefabs(context));
+//        addAndTrack(new ProcessBlockPrefabs(context));
+        addAndTrack(new LoadExtraBlockData(serviceRegistry));
+        addAndTrack(new InitialiseComponentSystemManager(serviceRegistry));
+//        addAndTrack(new RegisterSystems(context, netMode));
+//        addAndTrack(new RegisterWorldSystems(gameManifest, context));
+        addAndTrack(new InitialiseCommandSystem(serviceRegistry));
+        addAndTrack(new InitialiseRemoteWorld(context, serviceRegistry, gameManifest));
+        addAndTrack(new InitialisePhysics(context, serviceRegistry));
+//        addAndTrack(new InitialiseSystems(context));
+//        addAndTrack(new PreBeginSystems(context));
+//        addAndTrack(new CreateRemoteWorldEntity(context));
+//        addAndTrack(new PostBeginSystems(context));
+//        addAndTrack(new SetupRemotePlayer(context));
+//        addAndTrack(new AwaitCharacterSpawn(context));
+//        addAndTrack(new RegisterBlockFamilies(context));
+//        addAndTrack(new PrepareWorld(context));
+        addAndTrack(new SwitchToContextStep(engine));
+        addAndTrack(new AddClientPostLoadProcessesStep());
     }
 
     private void initHost(GameEngine engine, ServiceRegistry serviceRegistry) {
-        loadProcesses.add(new RegisterMods(context, serviceRegistry, gameManifest));
+        addAndTrack(new RegisterMods(context, serviceRegistry, gameManifest));
         if (!headless) {
-            loadProcesses.add(new InitialiseRendering(serviceRegistry));
+            addAndTrack(new InitialiseRendering(serviceRegistry));
         }
-        loadProcesses.add(new InitialiseEntitySystem(context, serviceRegistry));
-        loadProcesses.add(new RegisterBlocks(context, serviceRegistry));
+        addAndTrack(new InitialiseEntitySystem(context, serviceRegistry));
+        addAndTrack(new RegisterBlocks(context, serviceRegistry));
         if (!headless) {
-            loadProcesses.add(new InitialiseGraphics(context));
+            addAndTrack(new InitialiseGraphics(context));
         }
-        loadProcesses.add(new InitialiseComponentSystemManager(serviceRegistry));
-        loadProcesses.add(new InitialiseCommandSystem(serviceRegistry));
-        loadProcesses.add(new LoadExtraBlockData(serviceRegistry));
-        loadProcesses.add(new InitialiseWorld(gameManifest, context, serviceRegistry));
-        loadProcesses.add(new InitialisePhysics(context, serviceRegistry));
-        loadProcesses.add(new SwitchToContextStep(engine));
+        addAndTrack(new InitialiseComponentSystemManager(serviceRegistry));
+        addAndTrack(new InitialiseCommandSystem(serviceRegistry));
+        addAndTrack(new LoadExtraBlockData(serviceRegistry));
+        addAndTrack(new InitialiseWorld(gameManifest, context, serviceRegistry));
+        addAndTrack(new InitialisePhysics(context, serviceRegistry));
+        addAndTrack(new SwitchToContextStep(engine));
         // Post-Init processes
-        loadProcesses.add(new AddHostPostLoadProcessesStep());
+        addAndTrack(new AddHostPostLoadProcessesStep());
     }
 
     private void addAndTrack(LoadProcess process) {