fix: graceful degradation when MCP server fails to connect#1769
Open
he-yufeng wants to merge 1 commit into
Open
fix: graceful degradation when MCP server fails to connect#1769he-yufeng wants to merge 1 commit into
he-yufeng wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
When an MCP server fails to start (e.g. port conflict between TUI and Web UI sessions), the MCPRuntimeError propagated uncaught through _agent_loop(), crashing the worker process and leaving the frontend message stuck in 'thinking' state forever. Two changes: 1. kimisoul.py: catch MCPRuntimeError in _agent_loop() so the conversation continues without the failed MCP server's tools. 2. process.py: on unexpected _read_loop exceptions, clear in-flight prompt IDs and emit 'error' status so the frontend can recover instead of hanging indefinitely. Fixes MoonshotAI#1766
he-yufeng
force-pushed
the
fix/mcp-graceful-degradation
branch
from
08aaf2e to
fdacf08
Compare
Author
|
Rebased onto current main and resolved the MCP loading conflict by keeping the new telemetry path while preserving the MCPRuntimeError graceful-degradation behavior. The web read-loop recovery hunk is already present upstream, so the rebased PR now only changes kimisoul.py. Validation: pytest tests/web/test_session_error_recovery.py -q passed (4 passed); ruff check on touched files passed; py_compile on touched files passed; git diff --check upstream/main..HEAD passed. |
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPRuntimeErrorpropagates uncaught through_agent_loop(), crashing the worker and leaving the frontend stuck in "thinking" foreverMCPRuntimeErrorin_agent_loop()so the conversation continues without the failed MCP server's tools_read_loopexceptions, clear in-flight prompt IDs and emit"error"status so the frontend can recoverTest plan
/webFixes #1766