Fix T_2M/TD_2M error by sourcing lead times 1–6 from previous INCA run#163
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dnerini
changed the title
frazane
reviewed
May 29, 2026
Comment on lines
+440
to
+441
| elif u == "mm/h": | ||
| da = da.assign_attrs({**da.attrs, "units": "kg m-2"}) |
Contributor
There was a problem hiding this comment.
Is this correct? We are converting from a rate to an accumulation. This particular conversion only works if values are for hourly accumulations. Is that always the case?
Contributor
Author
There was a problem hiding this comment.
Yes, good point, this work only for hourly accumulations, for 6h and 10min we have to do an additional conversion, I think it make sense to do it, so that we afterwards ready also for 10min accumulations. ANyway, we still have to compute the accumulations (now the algorithm just take the corresponding 10 min intensity). Probably make sense to open a new PR with accumulations and cooresponding units.
dnerini
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INCA runs in the archive have a known bug where T_2M and TD_2M are incorrect at lead times 1–6 for runs initialized at full hours. This PR works around it by loading those steps from the run 10 minutes prior (at :50), while keeping step 0 from the current reftime.
The fix applies only to hourly frequency and the two affected parameters. A helper
_open_convert()was extracted to reduce duplication in the loading logic.