Skip to content

Commit 533df24

Browse files
Fedrclaude
andauthored
ci(windows): generate_win.bat — fail loudly when MSYS2 isn't installed (#6082)
Before: when `%MSYS2_DIR%` doesn't exist, the script printed an error message and then exited 0, so callers (CI workflows, devs) thought binding generation succeeded with no output. After: print the error and `exit /b 1`. De-nest the success path so the success branch is the script's normal flow rather than the `else` branch of the missing-MSYS2 check. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 4c52126 commit 533df24

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

scripts/mrbind/generate_win.bat

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ set args=%*
1515

1616
if not exist %MSYS2_DIR% (
1717
echo MSYS2 was NOT found at `%MSYS2_DIR%`. Run `install_deps_windows_msys2.bat` to build it.
18-
) else (
19-
echo Found MSYS2 at `%MSYS2_DIR%`.
20-
call %MSYS2_DIR%\msys2_shell.cmd -no-start -defterm -full-path -here -clang64 -c "time make -f '%~dp0generate.mk' %args:"=""% "
18+
exit /b 1
2119
)
20+
21+
echo Found MSYS2 at `%MSYS2_DIR%`.
22+
call %MSYS2_DIR%\msys2_shell.cmd -no-start -defterm -full-path -here -clang64 -c "time make -f '%~dp0generate.mk' %args:"=""% "

0 commit comments

Comments
 (0)