Added a delay before switching skin/theme after user profile change. This was done to avoid skin switching during profile change which caused exceptions and crashes

Author: morpheusxx

MediaPortal/Source/UI/SkinEngine/SkinEnginePlugin.cs

@@ -23,6 +23,7 @@ You should have received a copy of the GNU General Public License
 #endregion
 
 using System;
+using System.Threading;
 using MediaPortal.UI.Control.InputManager;
 using MediaPortal.Common;
 using MediaPortal.Common.Logging;
@@ -214,6 +215,8 @@ private void UserChanged(object sender, EventArgs e)
       var skinSettings = ServiceRegistration.Get<ISettingsManager>().Load<SkinSettings>();
       if (screenManager.SkinName != skinSettings.Skin || screenManager.ThemeName != skinSettings.Theme)
       {
+        // Wait a while to allow all other parts to react on user context changes
+        Thread.Sleep(500);
         IWorkflowManager workflowManager = ServiceRegistration.Get<IWorkflowManager>();
         // Exclusively lock WF manager while changing skin, otherwise it will fail when models try to get lock.
         if (!workflowManager.Lock.TryEnterWriteLock(2000))

MediaPortal/Source/UI/SkinEngine/SkinManagement/SkinResources.cs

@@ -23,6 +23,7 @@ You should have received a copy of the GNU General Public License
 #endregion
 
 using System;
+using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
@@ -162,7 +163,7 @@ public object GetOrLoadModel(Guid modelId)
     /// <summary>
     /// Models currently loaded for the style.
     /// </summary>
-    protected IDictionary<Guid, object> _styleGUIModels = new Dictionary<Guid, object>();
+    protected IDictionary<Guid, object> _styleGUIModels = new ConcurrentDictionary<Guid, object>();
 
     #endregion