Merge pull request #263 from eyupcanakman/fix/fwrite-null-deprecation-254

goetas · web-flow · commit a2633d97339a · 2026-03-04T21:50:16.000+01:00
Fix fwrite() null deprecation in OutputRules::wr() on PHP 8.1+
diff --git a/src/HTML5/Serializer/OutputRules.php b/src/HTML5/Serializer/OutputRules.php
@@ -454,7 +454,7 @@ protected function closeTag($ele)
      */
     protected function wr($text)
     {
-        fwrite($this->out, $text);
+        fwrite($this->out, (string) $text);
 
         return $this;
     }
diff --git a/test/HTML5/Serializer/OutputRulesTest.php b/test/HTML5/Serializer/OutputRulesTest.php
@@ -382,6 +382,16 @@ public function testWr()
         $this->assertEquals('foo', stream_get_contents($s, -1, 0));
     }
 
+    public function testWrWithNullNodeValue()
+    {
+        // Namespace nodes with an empty URI (xmlns:w="") can expose a null nodeValue; verify no error on serialization.
+        $this->html5 = $this->getInstance(array('xmlNamespaces' => true));
+        $input = '<!doctype html><html><body><span xmlns:w="" data-x="1"></span></body></html>';
+        $dom = $this->html5->loadHTML($input);
+        $result = $this->html5->saveHTML($dom);
+        $this->assertTrue(false !== strpos($result, 'xmlns:w=""'));
+    }
+
     public function getEncData()
     {
         return array(

Original file line number	Diff line number	Diff line change
`@@ -454,7 +454,7 @@ protected function closeTag($ele)`
`454`	`454`	`*/`
`455`	`455`	`protected function wr($text)`
`456`	`456`	`{`
`457`		`- fwrite($this->out, $text);`
	`457`	`+ fwrite($this->out, (string) $text);`
`458`	`458`
`459`	`459`	`return $this;`
`460`	`460`	`}`