Julia 1.12 compatibility: Explicit import for Pointf constructor#244
Closed
SimonAB wants to merge 5 commits intoMakieOrg:masterfrom
Closed
Julia 1.12 compatibility: Explicit import for Pointf constructor#244SimonAB wants to merge 5 commits intoMakieOrg:masterfrom
SimonAB wants to merge 5 commits intoMakieOrg:masterfrom
Conversation
- Add explicit import GeometryBasics: Pointf - Resolves deprecation warning about unqualified constructor extension - Compatible with Julia 1.12+
Changed from '1.4' to '1' to allow upgrading to latest Graphs versions (up to 1.13.3) while maintaining compatibility.
GraphMakie doesn't directly depend on Agents, but a transitive dependency constrains it. Adding explicit Agents compat allows newer Agents versions (up to 6.x) to work with GraphMakie.
There was a problem hiding this comment.
Pull request overview
This PR addresses Julia 1.12 compatibility by adding an explicit import for GeometryBasics.Pointf to resolve deprecation warnings related to constructor extension, and updates package compatibility constraints for Graphs.jl.
- Adds explicit
import GeometryBasics: Pointfto silence Julia 1.12 deprecation warnings - Updates Graphs compatibility from
"1.4"to"1"to allow broader version support - Adds Agents compatibility constraint to address transitive dependency issues
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/GraphMakie.jl | Adds explicit import for Pointf with explanatory comment to address Julia 1.12 deprecation warning |
| Project.toml | Updates Graphs compat to "1" and adds Agents compat constraint for transitive dependency resolution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Similar to Makie.jl, Pkg doesn't allow compat entries for packages that aren't direct dependencies. Removing the Agents compat entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 78.53% 78.53%
=======================================
Files 5 5
Lines 764 764
=======================================
Hits 600 600
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an explicit import for
GeometryBasics.Pointfto resolve Julia 1.12 deprecation warnings about extending constructors without explicit qualification or import.Change: Added
import GeometryBasics: Pointftosrc/GraphMakie.jlMotivation
Julia 1.12 requires explicit imports when extending constructors. This change silences the deprecation warning:
The warning was triggered by
Point\{N,Float32\}helpers inutils.jlthat extend thePointfconstructor.Additional Changes
Graphscompat from"1.4"to"1"to allow latest Graphs.jl versionsTesting
Type of change
Checklist
Note: This is a compatibility fix that doesn't require documentation changes or new tests.