Commit a3db5d5
committed
fix(charts): histogram emits PowerPoint's auto-binning form (no binCount child) — issue #14 Phase C
Pareto fixed (b3a2207) but histogram still triggered repair. Precise
byte-diff vs the PowerPoint-authored histogram: the sole histogram-specific
delta was our <cx:binCount>N</cx:binCount> child. dml-chartex.xsd models
binCount/binSize as child elements (our emission was schema-valid) but
PowerPoint's reader rejects that form; PowerPoint's own histogram uses
automatic binning: bare <cx:binning intervalClosed="r"/>.
No PowerPoint ground-truth exists for an explicit-bin form, so per the
no-inference discipline (memory #25: only ground-truth-verified structure
ships) histogram now emits exactly PowerPoint's accepted auto-binning
structure. HistogramChartData still accepts bin_count/bin_size for API
stability but they no longer emit the rejected child — PowerPoint computes
bins from the data (its own default). add_histogram_series signature
simplified; slide.py caller updated.
Verified via uat/chartex_groundtruth_diff.py: histogram now matches the
PowerPoint-authored chart structurally (only delta = PowerPoint's optional
<cx:title>). Trinity: pytest 3887 passed 0 failed, ruff clean + fixed
point, behave 1109 scenarios 0 failed. Refs #14.1 parent b3a2207 commit a3db5d5
2 files changed
Lines changed: 15 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
391 | 391 | | |
392 | 392 | | |
393 | 393 | | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
| 394 | + | |
400 | 395 | | |
401 | 396 | | |
402 | 397 | | |
403 | | - | |
404 | | - | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
405 | 409 | | |
406 | 410 | | |
407 | 411 | | |
| |||
411 | 415 | | |
412 | 416 | | |
413 | 417 | | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | 418 | | |
423 | 419 | | |
424 | 420 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
250 | 245 | | |
251 | 246 | | |
252 | 247 | | |
| |||
0 commit comments