Dispose of contained views onClose

[mazz]

How do I dispose of contained views when I close the popup view? I have a KSPlayer/KSVideoPlayerView inside the Swiftui LNPopupUI and it continues playing after I close the popup:

2023-11-24.15.37.00.mp4

[LeoNatan]

Do you mean playback continues when you close the popup (but the bar is still presented), or when the bar is dismissed?

[LeoNatan]

I just looked into the code, and some stuff isn't released properly. I will push a new version with a fix, so you can try. @mazz

[mazz]

I saw your second reply(thank you for the actionable response) but I will answer your first question anyway. So I mean when the bar is dismissed. I hope you’d agree that semantically the contained views are “gone” after the bar is no longer visible/dismissed.

[LeoNatan]

Yes, agree. Please test with the latest release. Thanks

[mazz]

1.6.3 fixes the issue. The contained KSPlayer stops playing when I tap the X popupbar item and is cleaned-up.

But I did find another issue, which may be a side-effect of this change: the popup bar items do not appear the next time I show the popup bar. I'll attach a video to demonstrate.

I'll also leave a gist of my popup bar view code(it's basically your example code with some minor modifications).

2023-11-25.13.34.09.mp4

https://gist.github.com/mazz/f256ae5cdf373b7f5e73d5ccc914b2a2

[LeoNatan]

Ugh. I'll look into it soon. Thanks!

[LeoNatan]

Good news. I think I’ve solved all the issues. I’ll create a new release of LNPopupUI in a few minutes.

[LeoNatan]

Also, since you are using a TabView, consider setting the material for your tab bar, so there is contrast between the tab bar and the popup bar.

tabContent.toolbarBackground(Material.thin, for: .tabBar)

Unfortunately, you need to do this for each tab content view.

It will look like this:

[LeoNatan]

1.6.4 is out with the fix.

[mazz]

Confirmed the fix in 1.6.4. Thanks for all your help!