Skip to content

Commit d81e45c

Browse files
committed
Add test for ace dependency
1 parent 6c9da4b commit d81e45c

2 files changed

Lines changed: 11 additions & 6 deletions

File tree

example/mrhankey.html

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@
3333
</style>
3434
</head>
3535
<body>
36-
<script
37-
src="https://cdnjs.cloudflare.com/ajax/libs/ace/1.2.6/ace.js"
38-
></script>
39-
4036
<div class="wrapper">
4137
<div class="text">
4238
<h1>Help Mr Hankey</h1>
@@ -272,6 +268,11 @@ <h1>Help Mr Hankey</h1>
272268
data-fiddlestick-type="render"
273269
></div>
274270

275-
<script src="../fiddlestick-ace.js"></script>
271+
<script
272+
src="https://cdnjs.cloudflare.com/ajax/libs/ace/1.2.6/ace.js"
273+
></script>
274+
<script
275+
src="../fiddlestick-ace.js"
276+
></script>
276277
</body>
277278
</html>

fiddlestick-ace.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
(function () {
22

3-
// TODO: test for ace editor dependency.
3+
// Test for ace editor dependency.
4+
if (typeof ace === 'undefined') {
5+
console.error('You have to load Ace editor (https://ace.c9.io) before FiddleStick or use fiddlestick.js instead of fiddlestick-ace.js.');
6+
return;
7+
}
48

59
function init() {
610
// Init fiddles mapping.

0 commit comments

Comments
 (0)