use ldiv!, formatter version 1

Author: mateuszbaran

.github/workflows/format.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Install JuliaFormatter and format
         run: |
           using Pkg
-          Pkg.add(PackageSpec(name="JuliaFormatter"))
+          Pkg.add(PackageSpec(name="JuliaFormatter", version="1"))
           using JuliaFormatter
           format("."; verbose=true)
         shell: julia --color=yes {0}

src/Manopt.jl

@@ -26,6 +26,7 @@ using LinearAlgebra:
     eigen,
     eigen!,
     eigvals,
+    ldiv!,
     tril,
     Symmetric,
     dot,

src/solvers/LevenbergMarquardt.jl

@@ -210,14 +210,15 @@ end
 
 function default_lm_lin_solve!(sk, JJ, grad_f_c)
     try
-        sk .= cholesky(JJ) \ -grad_f_c
+        ldiv!(sk, cholesky(JJ), grad_f_c)
     catch e
         if e isa PosDefException
-            sk .= JJ \ -grad_f_c
+            sk .= Symmetric(JJ) \ grad_f_c
         else
             rethrow()
         end
     end
+    sk .*= -1
     return sk
 end
 

test/solvers/test_Levenberg_Marquardt.jl

@@ -283,6 +283,6 @@ end
         sk = similar(grad_f_c)
         Manopt.default_lm_lin_solve!(sk, JJ, grad_f_c)
         @test isapprox(sk, [-0.5, -1.0])
-        @test_throws ArgumentError Manopt.default_lm_lin_solve!(sk, NaN .* JJ, grad_f_c)
+        @test_throws SingularException Manopt.default_lm_lin_solve!(sk, NaN .* JJ, grad_f_c)
     end
 end