fix convergence indication of StopWhenChangeLess

Author: kellertuer

Changelog.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 * Line searches consistently respect `stop_when_stepsize_exceeds` keyword argument as a hard limit. (#554)
+* `StopWhenChangeLess` falsely claimed to indicate convergence. This is now fixed.
 
 ## [0.5.32] January 15, 2026
 

src/plans/stopping_criterion.jl

@@ -323,7 +323,7 @@ function status_summary(c::StopWhenChangeLess)
     s = has_stopped ? "reached" : "not reached"
     return "|Δp| < $(c.threshold): $s"
 end
-indicates_convergence(c::StopWhenChangeLess) = true
+indicates_convergence(c::StopWhenChangeLess) = false
 function show(io::IO, c::StopWhenChangeLess)
     s = ismissing(c.outer_norm) ? "" : "and outer norm $(c.outer_norm)"
     return print(

test/plans/test_stopping_criteria.jl

@@ -8,21 +8,18 @@ end
 
 @testset "StoppingCriteria" begin
     @testset "Generic Tests" begin
-        @test_throws ErrorException get_stopping_criteria(
-            Manopt.Test.DummyStoppingCriteriaSet()
-        )
+        @test_throws ErrorException get_stopping_criteria(Manopt.Test.DummyStoppingCriteriaSet())
 
         s = StopWhenAll(StopAfterIteration(10), StopWhenChangeLess(Euclidean(), 0.1))
-        @test Manopt.indicates_convergence(s) #due to all and change this is true
+        @test !Manopt.indicates_convergence(s) # Neither of the two indicates convergence
         @test startswith(repr(s), "StopWhenAll with the")
         @test get_reason(s) === ""
         # Trigger second one manually
         s.criteria[2].last_change = 0.05
         s.criteria[2].at_iteration = 3
         @test length(get_reason(s.criteria[2])) > 0
         s2 = StopWhenAll([StopAfterIteration(10), StopWhenChangeLess(Euclidean(), 0.1)])
-        @test get_stopping_criteria(s)[1].max_iterations ==
-            get_stopping_criteria(s2)[1].max_iterations
+        @test get_stopping_criteria(s)[1].max_iterations == get_stopping_criteria(s2)[1].max_iterations
 
         s3 = StopWhenCostLess(0.1)
         p = DefaultManoptProblem(