Make Rayleigh tests more robust to eigenvectors switching sign.

Author: kellertuer

test/solvers/test_trust_regions.jl

@@ -183,15 +183,15 @@ include("../utils/example_tasks.jl")
 
         @testset "Allocating Variant" begin
             q = trust_regions(M, f, grad_f, Hess_f, p)
-            @test isapprox(M, q, p_star)
+            @test isapprox(M, q, p_star) || isapprox(M, q, -p_star)
             q2 = copy(M, p)
             trust_regions!(M, f, grad_f, Hess_f, q2)
-            @test isapprox(M, q2, p_star)
+            @test isapprox(M, q2, p_star) || isapprox(M, q2, -p_star)
             # random start point
             q3 = trust_regions(M, f, grad_f, Hess_f)
             # remove ambiguity
             q3 = (sign(q3[1]) == sign(p_star[1])) ? q3 : -q3
-            @test isapprox(M, q3, p_star)
+            @test isapprox(M, q3, p_star) || isapprox(M, q3, -p_star)
 
             # a Default
             qaAoor = trust_regions(M, f, grad_f)
@@ -211,7 +211,7 @@ include("../utils/example_tasks.jl")
                 retraction_method=ProjectionRetraction(),
                 evaluation=InplaceEvaluation(),
             )
-            @test isapprox(M, qaHSR1, p_star)
+            @test isapprox(M, qaHSR1, p_star) || isapprox(M, qaHSR1, -p_star)
 
             qaHSR1_2 = copy(M, p)
             trust_regions!(
@@ -227,7 +227,7 @@ include("../utils/example_tasks.jl")
                 κ=0.9,
                 retraction_method=ProjectionRetraction(),
             )
-            @test isapprox(M, qaHSR1_2, p_star)
+            @test isapprox(M, qaHSR1_2, p_star) || isapprox(M, qaHSR1_2, -p_star)
 
             qaHBFGS = trust_regions(
                 M,
@@ -242,7 +242,7 @@ include("../utils/example_tasks.jl")
                 κ=0.9,
                 retraction_method=ProjectionRetraction(),
             )
-            @test isapprox(M, qaHBFGS, p_star)
+            @test isapprox(M, qaHBFGS, p_star) || isapprox(M, qaHBFGS, -p_star)
 
             qaHBFGS_2 = copy(M, p)
             trust_regions!(
@@ -258,7 +258,7 @@ include("../utils/example_tasks.jl")
                 κ=0.9,
                 retraction_method=ProjectionRetraction(),
             )
-            @test isapprox(M, qaHBFGS_2, p_star)
+            @test isapprox(M, qaHBFGS_2, p_star) || isapprox(M, qaHBFGS_2, -p_star)
         end
         @testset "Mutating" begin
             q3 = copy(M, p)
@@ -271,7 +271,7 @@ include("../utils/example_tasks.jl")
                 trust_region_radius=1.0,
                 evaluation=InplaceEvaluation(),
             )
-            @test isapprox(M, q3, p_star)
+            @test isapprox(M, q3, p_star) || isapprox(M, q3, -p_star)
 
             q4 = copy(M, p)
             trust_regions!(
@@ -283,7 +283,7 @@ include("../utils/example_tasks.jl")
                 trust_region_radius=1.0,
                 evaluation=InplaceEvaluation(),
             )
-            @test isapprox(M, q4, p_star)
+            @test isapprox(M, q4, p_star) || isapprox(M, q4, -p_star)
 
             qaHSR1_3 = copy(M, p)
 
@@ -303,7 +303,7 @@ include("../utils/example_tasks.jl")
                 retraction_method=ProjectionRetraction(),
                 evaluation=InplaceEvaluation(),
             )
-            @test isapprox(M, qaHSR1_3, p_star)
+            @test isapprox(M, qaHSR1_3, p_star) || isapprox(M, qaHSR1_3, -p_star)
 
             qaHBFGS_3 = copy(M, p)
             trust_regions!(
@@ -320,7 +320,7 @@ include("../utils/example_tasks.jl")
                 retraction_method=ProjectionRetraction(),
                 evaluation=InplaceEvaluation(),
             )
-            @test isapprox(M, qaHBFGS_3, p_star)
+            @test isapprox(M, qaHBFGS_3, p_star) || isapprox(M, qaHBFGS_3, -p_star)
         end
     end
     @testset "on the Circle" begin