adapt one new StoppingCriterion to the new show/repr/status_summary style and fix one further bug.

Author: kellertuer

src/plans/stopping_criterion.jl

@@ -903,14 +903,18 @@ function get_reason(c::StopWhenProjectedNegativeGradientNormLess)
     end
     return ""
 end
-function status_summary(c::StopWhenProjectedNegativeGradientNormLess)
+function status_summary(c::StopWhenProjectedNegativeGradientNormLess; context::Symbol = :default)
+    (context === :short) && return repr(c)
     has_stopped = (c.at_iteration >= 0)
     s = has_stopped ? "reached" : "not reached"
-    return "|proj (-grad f)| < $(c.threshold): $s"
+    (context === :inline) && return "|proj (-grad f)| < $(c.threshold): $s"
+    return "A StoppingCriterion to stop when the negative projected gradient norm is less than a threshold of $(c.threshold):\n$(_MANOPT_INDENT)$s"
 end
 indicates_convergence(c::StopWhenProjectedNegativeGradientNormLess) = true
 function show(io::IO, c::StopWhenProjectedNegativeGradientNormLess)
-    return print(io, "StopWhenProjectedNegativeGradientNormLess($(c.threshold))\n    $(status_summary(c))")
+    print(io, "StopWhenProjectedNegativeGradientNormLess(", c.threshold, "; norm = ", c.norm)
+    !ismissing(c.outer_norm) && print(io, ", outer_norm = ", c.outer_norm)
+    return print(io, ")")
 end
 
 """

test/plans/test_stopping_criteria.jl

@@ -424,9 +424,9 @@ end
 
         @test startswith(
             to_display_string(sc),
-            "StopWhenProjectedNegativeGradientNormLess(1.0e-10)\n",
+            "A StoppingCriterion to stop when the negative projected gradient norm is less than",
         )
-        @test startswith(Manopt.status_summary(sc), "|proj (-grad f)| < 1.0e-10")
+        @test startswith(Manopt.status_summary(sc; context = :inline), "|proj (-grad f)| < 1.0e-10")
 
         Manopt.set_parameter!(sc, Val(:MinGradNorm), 1.0e-5)
         @test sc.threshold == 1.0e-5

test/solvers/test_quasi_Newton.jl

@@ -248,7 +248,7 @@ end
 
         x = [0.7011245948687502, -0.1726003159556036, 0.38798265967671103, -0.5728026616491424]
         x_lrbfgs = quasi_Newton(
-            M, F, grad_f, x; memory_size = -1,
+            M, F, grad_f, x;
             basis = get_basis(M, x, DefaultOrthonormalBasis()),
             memory_size = -1,
             stopping_criterion = StopWhenGradientNormLess(1.0e-9) | StopAfterIteration(1000),