Skip to content

Remove convert method piracy, avoiding downstream invalidations.#3126

Merged
maleadt merged 1 commit intomasterfrom
tb/convert
May 4, 2026
Merged

Remove convert method piracy, avoiding downstream invalidations.#3126
maleadt merged 1 commit intomasterfrom
tb/convert

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented May 4, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.41%. Comparing base (5e4118b) to head (2f0c78a).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/cusparse/src/types.jl 0.00% 1 Missing ⚠️
lib/custatevec/src/types.jl 0.00% 1 Missing ⚠️
lib/cutensor/src/types.jl 0.00% 1 Missing ⚠️
lib/cutensornet/src/types.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   16.43%   16.41%   -0.03%     
==========================================
  Files         123      123              
  Lines        9678     9678              
==========================================
- Hits         1591     1589       -2     
- Misses       8087     8089       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA.jl Benchmarks

Details
Benchmark suite Current: 2f0c78a Previous: d627b3e Ratio
array/accumulate/Float32/1d 100744 ns 100853 ns 1.00
array/accumulate/Float32/dims=1 75838 ns 76362 ns 0.99
array/accumulate/Float32/dims=1L 1584211 ns 1585357 ns 1.00
array/accumulate/Float32/dims=2 143021 ns 143506 ns 1.00
array/accumulate/Float32/dims=2L 656934 ns 657416 ns 1.00
array/accumulate/Int64/1d 118555 ns 118459.5 ns 1.00
array/accumulate/Int64/dims=1 79352.5 ns 79599 ns 1.00
array/accumulate/Int64/dims=1L 1694159 ns 1694409 ns 1.00
array/accumulate/Int64/dims=2 155424 ns 155450.5 ns 1.00
array/accumulate/Int64/dims=2L 960848 ns 960958 ns 1.00
array/broadcast 20268 ns 20282 ns 1.00
array/construct 1254.7 ns 1328.2 ns 0.94
array/copy 17699 ns 17911 ns 0.99
array/copyto!/cpu_to_gpu 213792 ns 212984 ns 1.00
array/copyto!/gpu_to_cpu 284399 ns 280259 ns 1.01
array/copyto!/gpu_to_gpu 10697 ns 10684 ns 1.00
array/iteration/findall/bool 134162 ns 134327 ns 1.00
array/iteration/findall/int 148496 ns 149222 ns 1.00
array/iteration/findfirst/bool 80262 ns 81163 ns 0.99
array/iteration/findfirst/int 82838 ns 82984 ns 1.00
array/iteration/findmin/1d 83845 ns 85430.5 ns 0.98
array/iteration/findmin/2d 116160 ns 116921 ns 0.99
array/iteration/logical 198614.5 ns 196920 ns 1.01
array/iteration/scalar 67100 ns 67453 ns 0.99
array/permutedims/2d 52172 ns 52024.5 ns 1.00
array/permutedims/3d 52360 ns 52690 ns 0.99
array/permutedims/4d 51236 ns 51921.5 ns 0.99
array/random/rand/Float32 12577 ns 12625 ns 1.00
array/random/rand/Int64 24773 ns 24502 ns 1.01
array/random/rand!/Float32 8335.666666666666 ns 8842 ns 0.94
array/random/rand!/Int64 21632 ns 21520 ns 1.01
array/random/randn/Float32 36524.5 ns 38339 ns 0.95
array/random/randn!/Float32 30676 ns 30558 ns 1.00
array/reductions/mapreduce/Float32/1d 33804.5 ns 34493 ns 0.98
array/reductions/mapreduce/Float32/dims=1 39571.5 ns 39238 ns 1.01
array/reductions/mapreduce/Float32/dims=1L 50937 ns 51115 ns 1.00
array/reductions/mapreduce/Float32/dims=2 56160 ns 56362 ns 1.00
array/reductions/mapreduce/Float32/dims=2L 68866 ns 68855 ns 1.00
array/reductions/mapreduce/Int64/1d 41912.5 ns 41840 ns 1.00
array/reductions/mapreduce/Int64/dims=1 42044 ns 43041.5 ns 0.98
array/reductions/mapreduce/Int64/dims=1L 86929 ns 87062 ns 1.00
array/reductions/mapreduce/Int64/dims=2 59208 ns 59400.5 ns 1.00
array/reductions/mapreduce/Int64/dims=2L 84267 ns 84650 ns 1.00
array/reductions/reduce/Float32/1d 34069 ns 34748 ns 0.98
array/reductions/reduce/Float32/dims=1 48947 ns 42567 ns 1.15
array/reductions/reduce/Float32/dims=1L 50929 ns 51269 ns 0.99
array/reductions/reduce/Float32/dims=2 56260 ns 56421.5 ns 1.00
array/reductions/reduce/Float32/dims=2L 69436 ns 69423 ns 1.00
array/reductions/reduce/Int64/1d 41743 ns 41786 ns 1.00
array/reductions/reduce/Int64/dims=1 47664.5 ns 41701 ns 1.14
array/reductions/reduce/Int64/dims=1L 86938 ns 87004 ns 1.00
array/reductions/reduce/Int64/dims=2 59067 ns 59173 ns 1.00
array/reductions/reduce/Int64/dims=2L 84074 ns 84474 ns 1.00
array/reverse/1d 17666.5 ns 17689 ns 1.00
array/reverse/1dL 68290 ns 68239 ns 1.00
array/reverse/1dL_inplace 65638 ns 65528 ns 1.00
array/reverse/1d_inplace 10288.666666666666 ns 8294.666666666666 ns 1.24
array/reverse/2d 20263 ns 20296 ns 1.00
array/reverse/2dL 72296 ns 72502 ns 1.00
array/reverse/2dL_inplace 65661 ns 65556 ns 1.00
array/reverse/2d_inplace 9845 ns 9743 ns 1.01
array/sorting/1d 2735029 ns 2734808 ns 1.00
array/sorting/2d 1068427 ns 1071711 ns 1.00
array/sorting/by 3304485.5 ns 3304331 ns 1.00
cuda/synchronization/context/auto 1148.9 ns 1162.7 ns 0.99
cuda/synchronization/context/blocking 931.5652173913044 ns 928.3666666666667 ns 1.00
cuda/synchronization/context/nonblocking 7163.1 ns 6978.1 ns 1.03
cuda/synchronization/stream/auto 980.875 ns 994.2105263157895 ns 0.99
cuda/synchronization/stream/blocking 843.1770833333334 ns 840.6543209876543 ns 1.00
cuda/synchronization/stream/nonblocking 8188 ns 7241.299999999999 ns 1.13
integration/byval/reference 143654 ns 143552.5 ns 1.00
integration/byval/slices=1 145489 ns 145385 ns 1.00
integration/byval/slices=2 284131 ns 284202.5 ns 1.00
integration/byval/slices=3 422637 ns 422620 ns 1.00
integration/cudadevrt 102271 ns 102213 ns 1.00
integration/volumerhs 23470755 ns 23474593 ns 1.00
kernel/indexing 12967 ns 12944 ns 1.00
kernel/indexing_checked 13760 ns 13691.5 ns 1.01
kernel/launch 2090.6666666666665 ns 2106.5555555555557 ns 0.99
kernel/occupancy 690.4076433121019 ns 665.54375 ns 1.04
kernel/rand 15422 ns 13998 ns 1.10
latency/import 3827527281.5 ns 3829156614.5 ns 1.00
latency/precompile 4584449187.5 ns 4603348569 ns 1.00
latency/ttfp 4397123386 ns 4403053778.5 ns 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@maleadt maleadt merged commit 568d85c into master May 4, 2026
2 checks passed
@maleadt maleadt deleted the tb/convert branch May 4, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant