Exclude device-side sorting code from coverage#2704
Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/sorting.jl b/src/sorting.jl
index 00f7c39a6..dc95f4a25 100644
--- a/src/sorting.jl
+++ b/src/sorting.jl
@@ -38,7 +38,7 @@ using ..CUDA: i32
end
-## COV_EXCL_START
+ ## COV_EXCL_START
# Batch partitioning
"""
Performs in-place cumsum using shared memory. Intended for use with indexes
@@ -119,7 +119,7 @@ function partition_batches_kernel(values::AbstractArray{T}, pivot, lo, hi, parit
return
end
-## COV_EXCL_STOP
+ ## COV_EXCL_STOP
# Batch consolidation
@@ -143,7 +143,7 @@ function find_partition(array, pivot, lo, hi, parity, lt::F1, by::F2) where {F1,
return low - 1
end
-## COV_EXCL_START
+ ## COV_EXCL_START
"""
This assumes the region of `vals` of length `L` starting after `lo`
has been batch partitioned with respect to `pivot`. Further, it assumes that
@@ -458,7 +458,7 @@ function qsort_kernel(vals::AbstractArray{T,N}, lo, hi, parity, sync::Val{S}, sy
return
end
-## COV_EXCL_STOP
+ ## COV_EXCL_STOP
function sort_args(args, partial_k::Nothing)
return args |
3792d36 to
06dfcf7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 83.60% 86.63% +3.03%
==========================================
Files 153 153
Lines 13588 13116 -472
==========================================
+ Hits 11360 11363 +3
+ Misses 2228 1753 -475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
CUDA.jl Benchmarks
Details
| Benchmark suite | Current: 06dfcf7 | Previous: 7fdd9e0 | Ratio |
|---|---|---|---|
latency/precompile |
45908865281.5 ns |
45683028153.5 ns |
1.00 |
latency/ttfp |
6560596429.5 ns |
6565374818 ns |
1.00 |
latency/import |
3191861618.5 ns |
3199458367.5 ns |
1.00 |
integration/volumerhs |
9614850 ns |
9625606 ns |
1.00 |
integration/byval/slices=1 |
147018 ns |
146708 ns |
1.00 |
integration/byval/slices=3 |
425133.5 ns |
425185 ns |
1.00 |
integration/byval/reference |
145151 ns |
145038 ns |
1.00 |
integration/byval/slices=2 |
286207 ns |
285862 ns |
1.00 |
integration/cudadevrt |
103531 ns |
103315 ns |
1.00 |
kernel/indexing |
14279 ns |
14074 ns |
1.01 |
kernel/indexing_checked |
14698.5 ns |
14777.5 ns |
0.99 |
kernel/occupancy |
683.5903614457832 ns |
673.5333333333333 ns |
1.01 |
kernel/launch |
2100.7 ns |
2091.2 ns |
1.00 |
kernel/rand |
14742 ns |
15853.5 ns |
0.93 |
array/reverse/1d |
19575.5 ns |
19669 ns |
1.00 |
array/reverse/2d |
25084.5 ns |
23622 ns |
1.06 |
array/reverse/1d_inplace |
11285 ns |
9923 ns |
1.14 |
array/reverse/2d_inplace |
12722 ns |
11511 ns |
1.11 |
array/copy |
21145 ns |
21077 ns |
1.00 |
array/iteration/findall/int |
157876.5 ns |
157492 ns |
1.00 |
array/iteration/findall/bool |
138808 ns |
138370 ns |
1.00 |
array/iteration/findfirst/int |
154384 ns |
154134 ns |
1.00 |
array/iteration/findfirst/bool |
155098 ns |
155050.5 ns |
1.00 |
array/iteration/scalar |
73512 ns |
71906 ns |
1.02 |
array/iteration/logical |
210605 ns |
213074 ns |
0.99 |
array/iteration/findmin/1d |
41600 ns |
41644.5 ns |
1.00 |
array/iteration/findmin/2d |
93795 ns |
94043.5 ns |
1.00 |
array/reductions/reduce/1d |
40727.5 ns |
35292 ns |
1.15 |
array/reductions/reduce/2d |
51146 ns |
51061 ns |
1.00 |
array/reductions/mapreduce/1d |
39095 ns |
33511 ns |
1.17 |
array/reductions/mapreduce/2d |
42795 ns |
41204 ns |
1.04 |
array/broadcast |
20969 ns |
20524 ns |
1.02 |
array/copyto!/gpu_to_gpu |
13629 ns |
11637 ns |
1.17 |
array/copyto!/cpu_to_gpu |
208457 ns |
207801 ns |
1.00 |
array/copyto!/gpu_to_cpu |
242495 ns |
244455 ns |
0.99 |
array/accumulate/1d |
108790 ns |
109057 ns |
1.00 |
array/accumulate/2d |
80247 ns |
79689 ns |
1.01 |
array/construct |
1320.85 ns |
1275.1 ns |
1.04 |
array/random/randn/Float32 |
43149.5 ns |
43977.5 ns |
0.98 |
array/random/randn!/Float32 |
26558 ns |
26667 ns |
1.00 |
array/random/rand!/Int64 |
27222 ns |
27133 ns |
1.00 |
array/random/rand!/Float32 |
8670 ns |
8642.333333333334 ns |
1.00 |
array/random/rand/Int64 |
29989 ns |
29842.5 ns |
1.00 |
array/random/rand/Float32 |
13113 ns |
12971 ns |
1.01 |
array/permutedims/4d |
61244 ns |
60954 ns |
1.00 |
array/permutedims/2d |
55807 ns |
54987.5 ns |
1.01 |
array/permutedims/3d |
56470.5 ns |
55653 ns |
1.01 |
array/sorting/1d |
2776187 ns |
2775426 ns |
1.00 |
array/sorting/by |
3367772 ns |
3366795.5 ns |
1.00 |
array/sorting/2d |
1085165 ns |
1084590 ns |
1.00 |
cuda/synchronization/stream/auto |
1049.5 ns |
1034.8 ns |
1.01 |
cuda/synchronization/stream/nonblocking |
6616.2 ns |
6443 ns |
1.03 |
cuda/synchronization/stream/blocking |
835.1975308641976 ns |
802.8020833333334 ns |
1.04 |
cuda/synchronization/context/auto |
1213.3 ns |
1172.6 ns |
1.03 |
cuda/synchronization/context/nonblocking |
6761.8 ns |
6645.8 ns |
1.02 |
cuda/synchronization/context/blocking |
964.25 ns |
954.2142857142857 ns |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
maleadt
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICT this code is all device-side only and so we can/should exclude it from coverage for now.