Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/libraries/cusparse/conversions.jl b/test/libraries/cusparse/conversions.jl
index 674755df7..981e442dd 100644
--- a/test/libraries/cusparse/conversions.jl
+++ b/test/libraries/cusparse/conversions.jl
@@ -68,7 +68,7 @@ end
@testset "CuSparseMatrix(::Adjoint/::Transpose)" begin
for typ in (Float32, ComplexF32, Float64, ComplexF64), (outer_T, T) in ((CuSparseMatrixCSC, CuSparseMatrixCSR{typ}), (CuSparseMatrixCSR, CuSparseMatrixCSC{typ}))
A = sprand(typ, 5, 5, 0.2)
- d_A = outer_T(A)
+ d_A = outer_T(A)
for f in (transpose, adjoint)
dA = T(f(d_A))
@test Array(dA) == f(A) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 83.25% 83.38% +0.13%
==========================================
Files 153 153
Lines 13606 13606
==========================================
+ Hits 11328 11346 +18
+ Misses 2278 2260 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
CUDA.jl Benchmarks
Details
| Benchmark suite | Current: 07be73e | Previous: e656414 | Ratio |
|---|---|---|---|
latency/precompile |
45608352592 ns |
46184695283 ns |
0.99 |
latency/ttfp |
6472884075 ns |
7102287310 ns |
0.91 |
latency/import |
3129088469 ns |
3740030164 ns |
0.84 |
integration/volumerhs |
9625046.5 ns |
9625749.5 ns |
1.00 |
integration/byval/slices=1 |
147158 ns |
146958 ns |
1.00 |
integration/byval/slices=3 |
425597 ns |
425220.5 ns |
1.00 |
integration/byval/reference |
145167 ns |
145179 ns |
1.00 |
integration/byval/slices=2 |
286411 ns |
286124 ns |
1.00 |
integration/cudadevrt |
103480 ns |
103528 ns |
1.00 |
kernel/indexing |
14310 ns |
14235 ns |
1.01 |
kernel/indexing_checked |
15009 ns |
14900 ns |
1.01 |
kernel/occupancy |
682.0848484848485 ns |
671.246835443038 ns |
1.02 |
kernel/launch |
2173 ns |
2207.5555555555557 ns |
0.98 |
kernel/rand |
14820 ns |
17974 ns |
0.82 |
array/reverse/1d |
20180 ns |
19747 ns |
1.02 |
array/reverse/2d |
25187 ns |
23841 ns |
1.06 |
array/reverse/1d_inplace |
10480 ns |
10823 ns |
0.97 |
array/reverse/2d_inplace |
12055 ns |
13333 ns |
0.90 |
array/copy |
21359 ns |
21108 ns |
1.01 |
array/iteration/findall/int |
159220 ns |
158270.5 ns |
1.01 |
array/iteration/findall/bool |
139378 ns |
138384 ns |
1.01 |
array/iteration/findfirst/int |
168177.5 ns |
153893 ns |
1.09 |
array/iteration/findfirst/bool |
171470 ns |
155197 ns |
1.10 |
array/iteration/scalar |
71518 ns |
71501 ns |
1.00 |
array/iteration/logical |
211360.5 ns |
214739.5 ns |
0.98 |
array/iteration/findmin/1d |
41664.5 ns |
41669.5 ns |
1.00 |
array/iteration/findmin/2d |
94202 ns |
94392 ns |
1.00 |
array/reductions/reduce/1d |
36423 ns |
57479.5 ns |
0.63 |
array/reductions/reduce/2d |
41260 ns |
52722 ns |
0.78 |
array/reductions/mapreduce/1d |
34314 ns |
50274.5 ns |
0.68 |
array/reductions/mapreduce/2d |
41641 ns |
52783 ns |
0.79 |
array/broadcast |
21287 ns |
20863 ns |
1.02 |
array/copyto!/gpu_to_gpu |
13825 ns |
11866 ns |
1.17 |
array/copyto!/cpu_to_gpu |
211361 ns |
209806.5 ns |
1.01 |
array/copyto!/gpu_to_cpu |
244393 ns |
245475.5 ns |
1.00 |
array/accumulate/1d |
109541 ns |
108861 ns |
1.01 |
array/accumulate/2d |
80520 ns |
80316 ns |
1.00 |
array/construct |
1294 ns |
1316.4 ns |
0.98 |
array/random/randn/Float32 |
44708 ns |
44869 ns |
1.00 |
array/random/randn!/Float32 |
26734 ns |
26707 ns |
1.00 |
array/random/rand!/Int64 |
27200 ns |
27172 ns |
1.00 |
array/random/rand!/Float32 |
8613.333333333334 ns |
8730.666666666666 ns |
0.99 |
array/random/rand/Int64 |
36164.5 ns |
38012 ns |
0.95 |
array/random/rand/Float32 |
13168 ns |
12966 ns |
1.02 |
array/permutedims/4d |
62034 ns |
61729.5 ns |
1.00 |
array/permutedims/2d |
55971 ns |
55273.5 ns |
1.01 |
array/permutedims/3d |
56885 ns |
56236 ns |
1.01 |
array/sorting/1d |
2777285 ns |
2775903.5 ns |
1.00 |
array/sorting/by |
3369803 ns |
3366504 ns |
1.00 |
array/sorting/2d |
1085534 ns |
1085191 ns |
1.00 |
cuda/synchronization/stream/auto |
1039.2 ns |
1022.9 ns |
1.02 |
cuda/synchronization/stream/nonblocking |
6450.2 ns |
6571.2 ns |
0.98 |
cuda/synchronization/stream/blocking |
830.5098039215686 ns |
797.87 ns |
1.04 |
cuda/synchronization/context/auto |
1199.9 ns |
1238.6 ns |
0.97 |
cuda/synchronization/context/nonblocking |
6783.5 ns |
6761.2 ns |
1.00 |
cuda/synchronization/context/blocking |
956.3243243243244 ns |
942.1891891891892 ns |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
maleadt
approved these changes
Mar 18, 2025
07be73e to
4316e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked locally that this will hit https://app.codecov.io/gh/JuliaGPU/CUDA.jl/blob/ksh%2Fsparse_tests/lib%2Fcusparse%2Fconversions.jl#L280 and co.