Skip to content

Commit b7caf67

Browse files
Merge pull request #405 from Juinjang/fix/#398
[fix/#398] 임장 나누기 화면에서 bcode null일 경우 나오지 않도록 쿼리 fix
2 parents ad8d8bb + 4999a3c commit b7caf67

6 files changed

Lines changed: 17 additions & 5 deletions

File tree

src/main/java/umc/th/juinjang/api/limjang/service/NoteFinder.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,10 @@ protected List<Limjang> getAllByMemberWithAddressAndNotePriceWhereIsSharableIsTr
3838
return limjangRepository.findAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalse(
3939
member);
4040
}
41+
42+
protected List<Limjang> getAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalseAndAddressBcodeIsNotNull(
43+
Member member) {
44+
return limjangRepository.findAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalseAndAddressBcodeIsNotNull(
45+
member);
46+
}
4147
}

src/main/java/umc/th/juinjang/api/limjang/service/NoteQueryServiceV2.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public UserNotesShareableGetResponse findNotesShareable(Member member) {
6868
}
6969

7070
private List<Limjang> findUnsharedSharableNotes(Member member) {
71-
List<Limjang> notes = noteFinder.getAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalse(
71+
List<Limjang> notes = noteFinder.getAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalseAndAddressBcodeIsNotNull(
7272
member);
7373
Set<Long> noteIdInSharedNotes = sharedNoteFinder.findLimjangIdsByDeletedAtIsNullAndLimjang(notes);
7474

src/main/java/umc/th/juinjang/domain/limjang/repository/LimjangRepository.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,8 @@ Optional<Limjang> findByLimjangIdAndMemberIdWithLimjangPriceAndDeletedIsFalse(@P
6363
@Query("SELECT l FROM Limjang l join fetch l.addressEntity join fetch l.limjangPrice left join fetch l.report WHERE l.memberId = :member AND l.deleted = false AND l.isSharable = true")
6464
List<Limjang> findAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalse(
6565
@Param("member") Member member);
66+
67+
@Query("SELECT l FROM Limjang l join fetch l.addressEntity join fetch l.limjangPrice left join fetch l.report WHERE l.memberId = :member AND l.deleted = false AND l.addressEntity.bcode is not null AND l.isSharable = true")
68+
List<Limjang> findAllByMemberWithAddressAndNotePriceWhereIsSharableIsTrueAndDeletedIsFalseAndAddressBcodeIsNotNull(
69+
@Param("member") Member member);
6670
}

src/main/java/umc/th/juinjang/domain/note/liked/model/repository/LikedNoteQueryDSLRepositoryImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ public List<LikedNote> findAllByMemberAndDynamicWhereDeletedAtIsNull(Member user
4444
getWhereByPropertyType(propertyType),
4545
getWhereByPriceType(priceType),
4646
keywordCondition(keyword),
47-
sharedNote.deletedAt.isNull()
47+
sharedNote.deletedAt.isNull(),
48+
limjang.deleted.isFalse()
4849
)
4950
.orderBy(likedNote.likedNoteId.desc())
5051
.fetch();

src/main/java/umc/th/juinjang/domain/note/shared/repository/SharedNoteQueryDSLRepositoryImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ public Page<SharedNote> findSharedNoteInExployer(List<String> code, ExploreSortT
5555
getWhereByPropertyType(propertyType),
5656
getWhereByPriceType(priceType),
5757
keywordCondition(keyword),
58-
sharedNote.deletedAt.isNull()
58+
sharedNote.deletedAt.isNull(),
59+
limjang.deleted.isFalse()
5960
)
6061
.orderBy(getOrderBySortOptions(sort))
6162
.offset(pageable.getOffset())
@@ -109,7 +110,7 @@ private OrderSpecifier<?>[] getOrderByNoteType(NoteType noteType) {
109110
private BooleanExpression getWhereByNoteType(Member user, NoteType noteType, List<Long> ids) {
110111
return switch (noteType) {
111112
case OWNED -> sharedNote.sharedNoteId.in(ids);
112-
case SHARED -> sharedNote.member.eq(user).and(sharedNote.deletedAt.isNull());
113+
case SHARED -> sharedNote.member.eq(user).and(sharedNote.deletedAt.isNull()).and(limjang.deleted.isFalse());
113114
default -> null;
114115
};
115116
}

src/main/java/umc/th/juinjang/domain/note/shared/repository/SharedNoteRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public interface SharedNoteRepository extends JpaRepository<SharedNote, Long>, S
4747

4848
boolean existsByDeletedAtIsNullAndLimjang(Limjang limjang);
4949

50-
@Query("SELECT s.limjang.limjangId FROM SharedNote s WHERE s.limjang in :limjangs AND s.deletedAt is null ")
50+
@Query("SELECT s.limjang.limjangId FROM SharedNote s WHERE s.limjang in :limjangs AND s.deletedAt is null")
5151
Set<Long> findLimjangIdsByDeletedAtIsNullAndLimjang(@Param("limjangs") List<Limjang> limjangs);
5252
}

0 commit comments

Comments
 (0)